mirror of
https://github.com/MariaDB/server.git
synced 2025-04-22 23:25:37 +02:00
ea4bcb9d98
Fix some random test failures following MDEV-32168 push. Don't blindly set $rpl_only_running_threads in many places. Instead explicit stop only the IO or SQL thread, as appropriate. Setting it interfered with rpl_end.inc in some cases. Rather than clearing it afterwards, better to not set it at all when it is not needed, removing ambiguity in the test about the state of the replication threads. Don't fail the test if include/stop_slave_io.inc finds an error in the IO thread after stop. Such errors can be simply because slave stop happened in the middle of the IO thread's initial communication with the master. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
170 lines
5.1 KiB
Text
170 lines
5.1 KiB
Text
source include/have_debug.inc;
|
|
source include/have_innodb.inc;
|
|
-- source include/have_binlog_format_statement.inc
|
|
source include/master-slave.inc;
|
|
# MDEV-17614 INSERT on dup key update is replication unsafe
|
|
#
|
|
# The following cases are tested below:
|
|
# 1. 2 unique key, replication is UNSAFE
|
|
# 2. 2 unique key, with one auto increment key and implicit value to it.
|
|
# It is UNSAFE because autoinc column values of being inserted records
|
|
# are revealed dynamically, so unknown at the binlog-format decision time
|
|
# and hence this pessimistic expectation
|
|
# 3. 2 unique keys
|
|
# A. insert is only in 1 unique key, still all colums are specified => UNSAFE
|
|
# B. both unique keys are specified => UNSAFE
|
|
# C. only one unique key is specified => SAFE (motivated by MDEV-28310)
|
|
# 4. 2 unique key, with one auto increment key(but user gives auto inc value) =>
|
|
# UNSAFE to replicate
|
|
|
|
--echo # Case 1: UNSAFE
|
|
call mtr.add_suppression("Unsafe statement written to the binary log using statement format");
|
|
CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY , b INT,
|
|
UNIQUE(b), c int) engine=innodb;
|
|
sync_slave_with_master;
|
|
connection master;
|
|
INSERT INTO t1 VALUES (1, 1, 1);
|
|
BEGIN;
|
|
INSERT INTO t1 VALUES (2, 1, 2) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master1
|
|
INSERT INTO t1 VALUES(2, 2, 3) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master
|
|
COMMIT;
|
|
SELECT * FROM t1;
|
|
--connection slave
|
|
# show the error message
|
|
--let $slave_sql_errno= 1062
|
|
--let $show_slave_sql_error= 1
|
|
--source include/wait_for_slave_sql_error.inc
|
|
--echo #Different value from server
|
|
SELECT * FROM t1;
|
|
|
|
# restart replication for the next testcase
|
|
--source include/stop_slave_io.inc
|
|
reset slave;
|
|
connection master;
|
|
reset master;
|
|
drop table t1;
|
|
connection slave;
|
|
start slave;
|
|
--source include/wait_for_slave_to_start.inc
|
|
|
|
--echo # Case 2: UNSAFE
|
|
--connection master
|
|
CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY auto_increment, b INT,
|
|
UNIQUE(b), c int) engine=innodb;
|
|
sync_slave_with_master;
|
|
connection master;
|
|
INSERT INTO t1 VALUES (default, 1, 1);
|
|
BEGIN;
|
|
INSERT INTO t1 VALUES (default, 1, 2) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master1
|
|
INSERT INTO t1 VALUES(default, 2, 3) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master
|
|
COMMIT;
|
|
SELECT * FROM t1;
|
|
--sync_slave_with_master
|
|
--echo #same data as master
|
|
SELECT * FROM t1;
|
|
|
|
connection master;
|
|
drop table t1;
|
|
--sync_slave_with_master
|
|
|
|
--echo # Case 3A: UNSAFE
|
|
--connection master
|
|
CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY, b INT,
|
|
UNIQUE(b), c int, d int ) engine=innodb;
|
|
sync_slave_with_master;
|
|
connection master;
|
|
INSERT INTO t1 VALUES (1, 1, 1, 1);
|
|
BEGIN;
|
|
INSERT INTO t1 VALUES (2, NULL, 2, 2) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master1
|
|
INSERT INTO t1 VALUES(3, NULL, 2, 3) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master
|
|
COMMIT;
|
|
SELECT * FROM t1;
|
|
--sync_slave_with_master
|
|
--echo #same data as master
|
|
SELECT * FROM t1;
|
|
connection master;
|
|
drop table t1;
|
|
--sync_slave_with_master
|
|
|
|
--echo # Case 3B: UNSAFE - all column specified.
|
|
--connection master
|
|
CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY, b INT,
|
|
UNIQUE(b), c int, d int ) engine=innodb;
|
|
sync_slave_with_master;
|
|
connection master;
|
|
INSERT INTO t1 VALUES (1, 1, 1, 1);
|
|
BEGIN;
|
|
INSERT INTO t1 VALUES (2, NULL, 2, 2) ON DUPLICATE KEY UPDATE c=VALUES(c);
|
|
--connection master1
|
|
INSERT INTO t1 VALUES(3, NULL, 2, 3) ON DUPLICATE KEY UPDATE c=VALUES(c);
|
|
--connection master
|
|
COMMIT;
|
|
SELECT * FROM t1;
|
|
--sync_slave_with_master
|
|
--echo #same data as master
|
|
SELECT * FROM t1;
|
|
connection master;
|
|
drop table t1;
|
|
--sync_slave_with_master
|
|
|
|
|
|
--echo # Case 3C: SAFE - only one unique key (PK) specified.
|
|
--connection master
|
|
CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY, b INT,
|
|
UNIQUE(b), c int, d int ) engine=innodb;
|
|
sync_slave_with_master;
|
|
connection master;
|
|
INSERT INTO t1 VALUES (1, 1, 1, 1);
|
|
BEGIN;
|
|
INSERT INTO t1 (`a`, `c`, `d`) VALUES (2, 2, 2) ON DUPLICATE KEY UPDATE c=99;
|
|
--connection master1
|
|
INSERT INTO t1 (`a`, `c`, `d`) VALUES(3, 2, 3) ON DUPLICATE KEY UPDATE c=100;
|
|
--connection master
|
|
COMMIT;
|
|
SELECT * FROM t1;
|
|
--sync_slave_with_master
|
|
--echo #same data as master
|
|
SELECT * FROM t1;
|
|
connection master;
|
|
drop table t1;
|
|
--sync_slave_with_master
|
|
|
|
--echo # Case 4: UNSAFE
|
|
--connection master
|
|
CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY auto_increment, b INT,
|
|
UNIQUE(b), c int) engine=innodb;
|
|
sync_slave_with_master;
|
|
connection master;
|
|
INSERT INTO t1 VALUES (1, 1, 1);
|
|
BEGIN;
|
|
INSERT INTO t1 VALUES (2, 1, 2) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master1
|
|
INSERT INTO t1 VALUES(2, 2, 3) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master
|
|
COMMIT;
|
|
SELECT * FROM t1;
|
|
--connection slave
|
|
# show the error message
|
|
--let $slave_sql_errno= 1062
|
|
--let $show_slave_sql_error= 1
|
|
--source include/wait_for_slave_sql_error.inc
|
|
--echo #Different value from server
|
|
SELECT * FROM t1;
|
|
|
|
# restart replication for the next testcase
|
|
--source include/stop_slave_io.inc
|
|
reset slave;
|
|
connection master;
|
|
reset master;
|
|
drop table t1;
|
|
connection slave;
|
|
start slave;
|
|
--source include/wait_for_slave_to_start.inc
|
|
|
|
--source include/rpl_end.inc
|