mariadb/storage/rocksdb
Marko Mäkelä 82d7419e06 MDEV-34388: Stack overflow on Alpine Linux
page_is_corrupted(): Do not allocate the buffers from stack,
but from the heap, in xb_fil_cur_open().

row_quiesce_write_cfg(): Issue one type of message when we
fail to create the .cfg file.

update_statistics_for_table(), read_statistics_for_table(),
delete_statistics_for_table(), rename_table_in_stat_tables():
Use a common stack buffer for Index_stat, Column_stat, Table_stat.

ha_connect::FileExists(): Invoke push_warning_printf() so that
we can avoid allocating a buffer for snprintf().

translog_init_with_table(): Do not duplicate TRANSLOG_PAGE_SIZE_BUFF.

Let us also globally enable the GCC 4.4 and clang 3.0 option
-Wframe-larger-than=16384 to reduce the possibility of introducing
such stack overflow in the future.  For RocksDB and Mroonga we relax
these limits.

Reviewed by: Vladislav Lesin
2025-05-20 17:27:05 +03:00
..
mysql-test mysqltest: fix --sorted_results 2025-01-09 10:00:36 +01:00
rocksdb@bba5e7bc21 MDEV-21930 RocksDB does not compile anymore, with Visual Studio 2020-03-23 11:25:01 +01:00
tools
unittest
.clang-format
.gitignore
atomic_stat.h
build_rocksdb.cmake Merge branch '10.5' into 10.6 2024-05-08 20:06:00 +02:00
CMakeLists.txt MDEV-34388: Stack overflow on Alpine Linux 2025-05-20 17:27:05 +03:00
event_listener.cc
event_listener.h
get_rocksdb_files.sh
ha_rocksdb.cc Merge 10.5 into 10.6 2024-06-24 13:09:47 +03:00
ha_rocksdb.h Merge 10.5 into 10.6 2024-06-24 13:09:47 +03:00
ha_rocksdb_proto.h
logger.h
myrocks_hotbackup.py
nosql_access.cc
nosql_access.h
properties_collector.cc
properties_collector.h MDEV-33746 Supply missing override markings 2024-06-20 11:32:13 -04:00
rdb_buff.h
rdb_cf_manager.cc
rdb_cf_manager.h
rdb_cf_options.cc
rdb_cf_options.h
rdb_compact_filter.h MDEV-33746 Supply missing override markings 2024-06-20 11:32:13 -04:00
rdb_comparator.h
rdb_converter.cc MDEV-22641: Provide SIMD optimized wrapper for zlib crc32() (#1558) 2020-06-01 11:34:06 +03:00
rdb_converter.h
rdb_datadic.cc Optimize performance of my_bitmap 2024-02-27 14:51:33 +02:00
rdb_datadic.h Merge 10.5 into 10.6 2024-06-24 13:09:47 +03:00
rdb_global.h MDEV-17171: RocksDB Tables do not have "Creation Date" 2019-10-31 19:45:25 +03:00
rdb_i_s.cc Merge commit '10.4' into 10.5 2023-07-20 11:54:52 +02:00
rdb_i_s.h
rdb_index_merge.cc
rdb_index_merge.h
rdb_io_watchdog.cc
rdb_io_watchdog.h
rdb_mariadb_port.h
rdb_mariadb_server_port.cc
rdb_mariadb_server_port.h
rdb_mutex_wrapper.cc
rdb_mutex_wrapper.h MDEV-33746 Supply missing override markings 2024-06-20 11:32:13 -04:00
rdb_perf_context.cc
rdb_perf_context.h
rdb_psi.cc
rdb_psi.h
rdb_source_revision.h.in
rdb_sst_info.cc Merge 10.2 into 10.3 2020-03-30 11:12:56 +03:00
rdb_sst_info.h
rdb_threads.cc
rdb_threads.h MDEV-33746 Supply missing override markings 2024-06-20 11:32:13 -04:00
rdb_utils.cc This commit is a fixup for MDEV-22189. 2021-07-26 22:59:10 +05:30
rdb_utils.h
README
rocksdb-range-access.txt
ut0counter.h Merge branch '10.5' into 10.6 2023-05-03 09:51:25 +02:00

== Summary ==
This directory contains RocksDB-based Storage Engine (RDBSE) for MySQL,
also known as "MyRocks".

== Resources ==
https://github.com/facebook/mysql-5.6/wiki/Getting-Started-with-MyRocks
https://www.facebook.com/groups/MyRocks/

== Coding Conventions ==
The baseline for MyRocks coding conventions for the code in storage/rocksdb/
is based on the default clang format with a few minor changes.  The file
storage/rocksdb/.clang-format describes conventions and can be integrated
with Vim or Emacs as described here:
http://releases.llvm.org/3.6.0/tools/clang/docs/ClangFormat.html#vim-integration

All code outside of storage/rocksdb/ should conform to the MySQL coding
conventions:
http://dev.mysql.com/doc/internals/en/coding-guidelines.html.

Several refinements:
  0. There is an umbrella C++ namespace named "myrocks" for all MyRocks code.
  1. We introduced "RDB" as the super-short abbreviation for "RocksDB". We will
     use it as a name prefix, with different capitalization (see below), to ease
     up code navigation with ctags and grep.
     N.B. For ease of matching, we'll keep the variables and functions dealing
          with sysvars as close as possible to the outside visible names of
          sysvars, which start with "rocksdb_" prefix, the outward storage
          engine name.
  2. The names for classes, interfaces, and C++ structures (which act as
     classes), start with prefix "Rdb_".
     NB: For historical reasons, we'll keep the "ha_<storage_engine_name>" class
         name for ha_rocksdb class, which is an exception to the rule.
  3. The names for global objects and functions start with prefix "rdb_".
  4. The names for macros and constants start with prefix "RDB_".
  5. Regular class member names start with "m_".
  6. Static class member names start with "s_".
  7. Given the 80 character per line limit, we'll not always use full English
     words in names, when a well known or easily recognizable abbreviation
     exists (like "tx" for "transaction" or "param" for "parameter" etc).
  8. When needing to disambiguate, we use different suffixes for that, like
     "_arg" for a function argument/parameter, "_arr" for a C style array, and
     "_vect" for a std::vector etc.

== Running Tests ==
To run tests from rocksdb, rocksdb_rpl or other rocksdb_* packages, use the
following parameters:
  --default-storage-engine=rocksdb
  --skip-innodb
  --default-tmp-storage-engine=MyISAM
  --rocksdb