mirror of
https://github.com/MariaDB/server.git
synced 2025-04-05 23:05:34 +02:00
969669767b
The root cause is the WAL logging of file operation when the actual operation fails afterwards. It creates a situation with a log entry for a operation that would always fail. I could simulate both the backup scenario error and Innodb recovery failure exploiting the weakness. We are following WAL for file rename operation and once logged the operation must eventually complete successfully, or it is a major catastrophe. Right now, we fail for rename and handle it as normal error and it is the problem. I created a patch to address RENAME operation to a non existing schema where the destination schema directory is missing. The patch checks for the missing schema before logging in an attempt to avoid the failure after WAL log is written/flushed. I also checked that the schema cannot be dropped or there cannot be any race with other rename to the same file. This is protected by the MDL lock in SQL today. The patch should this be a good improvement over the current situation and solves the issue at hand.
74 lines
1.6 KiB
Text
74 lines
1.6 KiB
Text
CREATE TABLE t1(i int) ENGINE INNODB;
|
|
INSERT into t1 values(1);
|
|
CREATE TABLE t2(i int) ENGINE INNODB;
|
|
INSERT INTO t2 values(2);
|
|
CREATE TABLE t3(i int) ENGINE INNODB;
|
|
CREATE TABLE t4(i int) ENGINE INNODB;
|
|
CREATE TABLE t5(i int) ENGINE INNODB;
|
|
INSERT INTO t5 VALUES(5);
|
|
CREATE TABLE a(a int) ENGINE INNODB;
|
|
INSERT INTO a values(1);
|
|
CREATE TABLE b(b CHAR(1)) ENGINE INNODB;
|
|
INSERT INTO b VALUES('b');
|
|
CREATE TABLE a1(a1 int) ENGINE INNODB;
|
|
INSERT INTO a1 VALUES(1);
|
|
CREATE TABLE b1(b1 CHAR(2)) ENGINE INNODB;
|
|
INSERT INTO b1 VALUES('b1');
|
|
# xtrabackup prepare
|
|
# shutdown server
|
|
# remove datadir
|
|
# xtrabackup move back
|
|
# restart
|
|
CREATE TABLE t1(i int);
|
|
DROP TABLE t1;
|
|
SELECT * from t1_renamed;
|
|
i
|
|
1
|
|
DROP TABLE t1_renamed;
|
|
CREATE TABLE t2(i int);
|
|
DROP TABLE t2;
|
|
SELECT * from t2_renamed;
|
|
i
|
|
2
|
|
DROP TABLE t2_renamed;
|
|
SELECT * from t3;
|
|
i
|
|
3
|
|
DROP TABLE t3;
|
|
SELECT * from t4;
|
|
i
|
|
DROP TABLE t4;
|
|
CREATE TABLE tmp(i int);
|
|
DROP TABLE tmp;
|
|
SELECT * FROM a;
|
|
b
|
|
b
|
|
SELECT * FROM b;
|
|
a
|
|
1
|
|
SELECT * FROM a1;
|
|
b1
|
|
b1
|
|
SELECT * FROM b1;
|
|
a1
|
|
1
|
|
DROP TABLE a,b,a1,b1;
|
|
SELECT * from t5;
|
|
i
|
|
DROP TABLE t5;
|
|
SELECT * from t6;
|
|
i
|
|
5
|
|
DROP TABLE t6;
|
|
#
|
|
# MDEV-33011 mariabackup --backup: FATAL ERROR: ... Can't open datafile cool_down/t3
|
|
#
|
|
# Simulate zero initialized page to defer tablespace load after rename log is found
|
|
SET @save_dbug = @@SESSION.debug_dbug;
|
|
SET DEBUG_DBUG="+d,checkpoint_after_file_create";
|
|
CREATE TABLE t1(f1 INT NOT NULL)ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES(1);
|
|
# RENAME that fails after redo log entry is written and flushed
|
|
RENAME TABLE t1 TO non_existing_db.t1;
|
|
ERROR HY000: Error on rename of './test/t1' to './non_existing_db/t1' (errno: 168 "Unknown (generic) error from engine")
|
|
DROP TABLE t1;
|