mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-12-03 19:06:32 +01:00
Code Issues Projects Releases Packages Wiki Activity
mariadb/storage/innobase/rem
History
Exact
Jan Lindström fb49d8aa42 MDEV-30732 : wsrep_store_key_val_for_row() may invoke memcpy() on nullptr 
Problem was that row_mysql_read_blob_ref can return NULL
in case when blob datatype is used in a key and its real
value is NULL. This NULL pointer is then used in memcpy
function in wsrep_store_key_val_for_row. However,
memcpy is defined so that argument 2 must not be NULL.

Fixed by adding conditions before memcpy functions so
that argument 2 is always non NULL.

Additional fixes after review
- Removed unnecessary copying key data from one buffer to another.
Use original key data buffer as input and temporary buffer as output.
Extra output buffer is needed because strnxfrm might expand input buffer
contents.
- Removed unnecessary initialization of variables and move
declaration where first time needed.
- Removed unnecessary intitialization of temporary buffer because
we already keep track actual filled length.
- Remove unneccessary extra call to charset->strnxfrm
2025-11-11 12:43:19 +02:00
..
rem0cmp.cc Merge 10.6 into 10.8 2023-04-12 15:50:08 +03:00
rem0rec.cc MDEV-30732 : wsrep_store_key_val_for_row() may invoke memcpy() on nullptr 2025-11-11 12:43:19 +02:00