mirror of
https://github.com/MariaDB/server.git
synced 2025-09-23 01:19:30 +02:00
3ee1991645
Ever since commit685d958e38(MDEV-14425) mariadb-backup --backup had some trouble to keep up with write workloads of the mariadbd server. Debarun Banerjee found out that mariadb-backup --backup was copying the log in the wrong way and not pausing when it made sense to do so. This change includes his fix as well as some dead code removal from xtrabackup_copy_mmap_logfile(). Some earlier changes to the default behaviour of mariadb-backup --backup will be reverted, by making the configuration parameters OFF by default. These parameters were basically working around this bug: * commit652f33e0a4(MDEV-30000) introduced --innodb-log-checkpoint-now and made it ON by default. Making the server execute a log checkpoint can be really I/O intensive. * commit6acada713a(MDEV-34062) introduced --innodb-log-file-mmap and made it ON by default on Linux and FreeBSD. There are no documented semantics what should happen to a memory mapping when there are concurrent pwrite(2) operations by other processes. While it appears to work, it is safer to default to clearly documented semantics. xtrabackup_copy_logfile(): Add a parameter early_exit. Always read a log snippet to the start of recv_sys.buf and assign recv_sys.len to the read length. We used to shift recv_sys.buf with memmove(). However, on recv_sys_t::PREMATURE_EOF we cannot know which part of the mini-transaction was correctly read, because that part of the ib_logfile0 may be concurrently modified by the server. So, we will reread everything from the start of the mini-transaction. xtrabackup_backup_func(): Invoke xtrabackup_copy_logfile(true), allowing it to stop on every recv_sys_t::PREMATURE_EOF. This will also avoid repeated "Retry" messages when there is no more redo log to copy. get_current_lsn(): Execute FLUSH ENGINE LOGS to ensure that InnoDB will complete any buffered writes to the ib_logfile0 and ensure that everything up to the current LSN has been written. backup_wait_for_commit_lsn(): Wait for as much as is really needed. This avoids an extra 5-second wait at the end of the backup. xtrabackup_copy_mmap_logfile(): Remove some dead code, and add debug assertions to demonstrate that the parser can only return recv_sys_t::OK or recv_sys_t::GOT_EOF.
70 lines
2.3 KiB
Text
70 lines
2.3 KiB
Text
--source include/innodb_page_size.inc
|
|
|
|
CREATE TABLE t(i INT) ENGINE INNODB;
|
|
INSERT INTO t VALUES(1);
|
|
SET GLOBAL innodb_max_purge_lag_wait=0;
|
|
echo # xtrabackup backup;
|
|
let $targetdir=$MYSQLTEST_VARDIR/tmp/backup;
|
|
--let $backup_log=$MYSQLTEST_VARDIR/tmp/backup.log
|
|
|
|
--disable_result_log
|
|
--error 1
|
|
exec $XTRABACKUP --defaults-file=$MYSQLTEST_VARDIR/my.cnf --backup --target-dir=$targetdir --parallel=10 --innodb-log-write-ahead-size=4095 > $backup_log 2>&1;
|
|
exec $XTRABACKUP --defaults-file=$MYSQLTEST_VARDIR/my.cnf --backup --target-dir=$targetdir --parallel=10 --innodb-log-write-ahead-size=10000 --innodb_log_checkpoint_now=1 > $backup_log 2>&1;
|
|
--enable_result_log
|
|
|
|
# The following warning must not appear after MDEV-27343 fix
|
|
--let SEARCH_PATTERN=InnoDB: Allocated tablespace ID
|
|
--let SEARCH_FILE=$backup_log
|
|
--source include/search_pattern_in_file.inc
|
|
--remove_file $backup_log
|
|
|
|
SELECT variable_value FROM information_schema.global_status
|
|
WHERE variable_name = 'INNODB_BUFFER_POOL_PAGES_DIRTY';
|
|
INSERT INTO t VALUES(2);
|
|
|
|
|
|
echo # xtrabackup prepare;
|
|
--disable_result_log
|
|
exec $XTRABACKUP --prepare --target-dir=$targetdir;
|
|
-- source include/restart_and_restore.inc
|
|
--enable_result_log
|
|
|
|
SELECT * FROM t;
|
|
DROP TABLE t;
|
|
rmdir $targetdir;
|
|
|
|
--echo #
|
|
--echo # MDEV-27121 mariabackup incompatible with disabled dedicated
|
|
--echo # undo log tablespaces
|
|
--echo #
|
|
call mtr.add_suppression("InnoDB: innodb_undo_tablespaces=0 disables dedicated undo log tablespaces");
|
|
call mtr.add_suppression("InnoDB: Cannot change innodb_undo_tablespaces=0 because previous shutdown was not with innodb_fast_shutdown=0");
|
|
call mtr.add_suppression("Found 1 prepared XA transactions");
|
|
|
|
CREATE TABLE t(f1 INT NOT NULL)ENGINE=InnoDB;
|
|
XA START 'zombie';
|
|
INSERT INTO t VALUES(1);
|
|
XA END 'zombie';
|
|
XA PREPARE 'zombie';
|
|
|
|
let $restart_parameters=--innodb_undo_tablespaces=0;
|
|
--source include/restart_mysqld.inc
|
|
|
|
echo # xtrabackup backup;
|
|
--disable_result_log
|
|
exec $XTRABACKUP --defaults-file=$MYSQLTEST_VARDIR/my.cnf --backup --target-dir=$targetdir;
|
|
--enable_result_log
|
|
|
|
echo # xtrabackup prepare;
|
|
--disable_result_log
|
|
exec $XTRABACKUP --prepare --target-dir=$targetdir;
|
|
-- source include/restart_and_restore.inc
|
|
--enable_result_log
|
|
|
|
--echo # Display undo log files from target directory
|
|
list_files $targetdir undo*;
|
|
|
|
XA COMMIT 'zombie';
|
|
DROP TABLE t;
|
|
rmdir $targetdir;
|