mirror of
https://github.com/MariaDB/server.git
synced 2025-08-07 11:01:34 +02:00
76c79d4fd8
MSAN found that `mariadb-binlog --force-read` checks encrypted events too for whether `--do-server-ids`/`ignore-server-ids` includes any of their (uninitialized) Server IDs. This fix extends the condition to stop skipping `UNKNOWN_EVENT`s by Server ID in addition to `ROTATE_EVENT`s. An alternative solution is to zero-initialize the `server_id` field of `Unknown_log_event` or even its supertype, `Log_event`. Though to avoid hiding `use-of-uninitialized-value` mistakes in the future, leaving unset fields uninitialized is more assured; not to mention the potential of ID 0 still in use. Reviewed-by: Brandon Nesterenko <brandon.nesterenko@mariadb.com> Acked-by: Daniel Black <daniel@mariadb.org> |
||
|---|---|---|
| .. | ||
| async_example.c | ||
| client_metadata.h | ||
| client_priv.h | ||
| CMakeLists.txt | ||
| completion_hash.cc | ||
| completion_hash.h | ||
| echo.c | ||
| mariadb-conv.cc | ||
| my_readline.h | ||
| mysql.cc | ||
| mysql_plugin.c | ||
| mysql_upgrade.c | ||
| mysqladmin.cc | ||
| mysqlbinlog.cc | ||
| mysqlcheck.c | ||
| mysqldump.c | ||
| mysqlimport.c | ||
| mysqlshow.c | ||
| mysqlslap.c | ||
| mysqltest.cc | ||
| readline.cc | ||