mirror of
https://github.com/MariaDB/server.git
synced 2025-02-09 23:24:11 +01:00
6400b199ac
The crash inside my_vsnprintf_utf32() happened correctly, because the caller methods: Field_string::sql_rpl_type() Field_varstring::sql_rpl_type() mis-used the charset library and sent pure ASCII data to the virtual function snprintf() of a utf32 CHARSET_INFO. It was wrong to use Field::charset() in sql_rpl_type(). We're printing the metadata (the data type) here, not the column data. The string contraining the data type of a CHAR/VARCHAR column is a pure ASCII string. Fixing to use res->charset() to print, like all virtual implementations of sql_type() do. Review was done by Andrei Elkin. Thanks to Andrei for proposing MTR test improvents.
113 lines
2.6 KiB
Text
113 lines
2.6 KiB
Text
-- source include/have_binlog_format_row.inc
|
|
-- source include/have_utf32.inc
|
|
-- source include/master-slave.inc
|
|
|
|
#
|
|
# BUG#51787 Assertion `(n % 4) == 0' on slave upon INSERT into a table with UTF32
|
|
#
|
|
|
|
SET SQL_LOG_BIN=0;
|
|
CREATE TABLE t1 (c1 char(255) DEFAULT NULL, KEY c1 (c1)) DEFAULT CHARSET=utf32;
|
|
SET SQL_LOG_BIN=1;
|
|
|
|
-- connection slave
|
|
|
|
SET @saved_slave_type_conversions= @@global.slave_type_conversions;
|
|
|
|
#
|
|
# Force test to cover conversion execution path in the
|
|
# slave, which also makes use of sql_type method, thence
|
|
# can ultimately trigger the assertion.
|
|
#
|
|
-- source include/stop_slave.inc
|
|
SET GLOBAL SLAVE_TYPE_CONVERSIONS='ALL_NON_LOSSY';
|
|
-- source include/start_slave.inc
|
|
|
|
SET SQL_LOG_BIN=0;
|
|
CREATE TABLE t1 ( c1 varchar(255) DEFAULT NULL, KEY c1 (c1)) DEFAULT CHARSET=utf32;
|
|
SET SQL_LOG_BIN=1;
|
|
|
|
-- connection master
|
|
|
|
INSERT INTO t1(c1) VALUES ('insert into t1');
|
|
DROP TABLE t1;
|
|
|
|
--sync_slave_with_master
|
|
|
|
--echo #
|
|
--echo # MDEV-32249 strings/ctype-ucs2.c:2336: my_vsnprintf_utf32: Assertion `(n
|
|
--echo #
|
|
|
|
--echo #
|
|
--echo # Testing with VARCHAR
|
|
--echo #
|
|
|
|
-- connection slave
|
|
-- source include/stop_slave.inc
|
|
SET GLOBAL SLAVE_TYPE_CONVERSIONS= '';
|
|
-- source include/start_slave.inc
|
|
|
|
--connection master
|
|
CREATE TABLE t1 (a INT);
|
|
|
|
--sync_slave_with_master
|
|
ALTER TABLE t1 MODIFY a VARCHAR(1) CHARACTER SET utf32;
|
|
|
|
--connection master
|
|
INSERT INTO t1 VALUES (1);
|
|
|
|
--connection slave
|
|
# ER_SLAVE_CONVERSION_FAILED
|
|
--let $slave_sql_errno= 1677
|
|
--source include/wait_for_slave_sql_error.inc
|
|
SHOW CREATE TABLE t1;
|
|
SELECT * FROM t1 ORDER BY a;
|
|
SET GLOBAL SQL_SLAVE_SKIP_COUNTER = 1;
|
|
START SLAVE;
|
|
|
|
--connection master
|
|
DROP TABLE t1;
|
|
--sync_slave_with_master
|
|
|
|
--echo #
|
|
--echo # Testing with CHAR
|
|
--echo #
|
|
|
|
-- connection slave
|
|
-- source include/stop_slave.inc
|
|
SET GLOBAL SLAVE_TYPE_CONVERSIONS= '';
|
|
-- source include/start_slave.inc
|
|
|
|
--connection master
|
|
CREATE TABLE t1 (a INT);
|
|
|
|
--sync_slave_with_master
|
|
ALTER TABLE t1 MODIFY a CHAR(1) CHARACTER SET utf32;
|
|
|
|
--connection master
|
|
INSERT INTO t1 VALUES (1);
|
|
|
|
--connection slave
|
|
# ER_SLAVE_CONVERSION_FAILED
|
|
--let $slave_sql_errno= 1677
|
|
--source include/wait_for_slave_sql_error.inc
|
|
SHOW CREATE TABLE t1;
|
|
SELECT * FROM t1 ORDER BY a;
|
|
SET GLOBAL SQL_SLAVE_SKIP_COUNTER = 1;
|
|
START SLAVE;
|
|
|
|
--connection master
|
|
DROP TABLE t1;
|
|
--sync_slave_with_master
|
|
|
|
|
|
# assertion: the slave woul hit an/several assertions:
|
|
# before and during slave conversion procedure
|
|
# Now that is fixed, it wont.
|
|
|
|
-- connection slave
|
|
SET GLOBAL SLAVE_TYPE_CONVERSIONS= @saved_slave_type_conversions;
|
|
-- source include/stop_slave.inc
|
|
-- source include/start_slave.inc
|
|
-- connection master
|
|
--source include/rpl_end.inc
|