mirror of
https://github.com/MariaDB/server.git
synced 2025-02-09 23:24:11 +01:00
![Daniele Sciascia](/assets/img/avatar_default.png)
Remove calls to wsrep_append_fk_parent_table() during REPAIR/OPTIMIZE TABLE processing. It turns out that REPAIR or OPTIMIZE commands on table t, do not acquire MDL locks on parent tables of t (as shown in the included test). Thus making wsrep_append_fk_parent_table() unnecessary for OPTIMIZE and REPAIR. This also fixes MDEV-24446 and reenables test galera.mysql-wsrep#198. Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>
274 lines
8.7 KiB
Text
274 lines
8.7 KiB
Text
connection node_2;
|
|
connection node_1;
|
|
connect node_1a, 127.0.0.1, root, , test, $NODE_MYPORT_1;
|
|
connection node_1a;
|
|
SET SESSION wsrep_sync_wait=0;
|
|
connect node_1b, 127.0.0.1, root, , test, $NODE_MYPORT_1;
|
|
connection node_1b;
|
|
SET SESSION wsrep_sync_wait=0;
|
|
######################################################################
|
|
# Test for ALTER ENGINE=INNODB
|
|
######################################################################
|
|
######################################################################
|
|
#
|
|
# Scenario #1: DML working on FK parent table BF aborted by DDL
|
|
# over child table
|
|
#
|
|
######################################################################
|
|
connection node_1;
|
|
SET SESSION wsrep_sync_wait=0;
|
|
CREATE TABLE p1 (pk INTEGER PRIMARY KEY, f2 CHAR(30));
|
|
INSERT INTO p1 VALUES (1, 'INITIAL VALUE');
|
|
CREATE TABLE p2 (pk INTEGER PRIMARY KEY, f2 CHAR(30));
|
|
INSERT INTO p2 VALUES (1, 'INITIAL VALUE');
|
|
INSERT INTO p2 VALUES (2, 'INITIAL VALUE');
|
|
CREATE TABLE c1 (pk INTEGER PRIMARY KEY, fk INTEGER, FOREIGN KEY (fk) REFERENCES p1(pk));
|
|
INSERT INTO c1 VALUES (1,1);
|
|
CREATE TABLE c2 (pk INTEGER PRIMARY KEY, fk1 INTEGER, fk2 INTEGER, FOREIGN KEY (fk1) REFERENCES p1(pk), FOREIGN KEY (fk2) REFERENCES p2(pk));
|
|
INSERT INTO c2 VALUES (1,1,1), (2,1,2);
|
|
connection node_1;
|
|
SET AUTOCOMMIT=ON;
|
|
START TRANSACTION;
|
|
UPDATE p1 SET f2 = 'TO DEADLOCK' WHERE pk = 1;
|
|
connection node_2;
|
|
SET SESSION wsrep_sync_wait=0;
|
|
ALTER TABLE c1 ENGINE=INNODB;
|
|
connection node_1;
|
|
COMMIT;
|
|
ERROR 40001: Deadlock found when trying to get lock; try restarting transaction
|
|
SELECT COUNT(*) AS EXPECT_1 FROM p1 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_1
|
|
1
|
|
SELECT COUNT(*) AS EXPECT_2 FROM p2 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_2
|
|
2
|
|
connection node_2;
|
|
SELECT COUNT(*) AS EXPECT_1 FROM p1 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_1
|
|
1
|
|
SELECT COUNT(*) AS EXPECT_2 FROM p2 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_2
|
|
2
|
|
######################################################################
|
|
#
|
|
# Scenario #2: DML working on FK parent table tries to replicate, but
|
|
# fails in certification for earlier DDL on child table
|
|
#
|
|
######################################################################
|
|
connection node_1;
|
|
BEGIN;
|
|
SET GLOBAL wsrep_provider_options = 'dbug=d,apply_monitor_slave_enter_sync';
|
|
connection node_2;
|
|
ALTER TABLE c1 ENGINE=INNODB;
|
|
connection node_1a;
|
|
SET SESSION wsrep_on = 0;
|
|
SET SESSION wsrep_on = 1;
|
|
SET GLOBAL wsrep_provider_options = 'dbug=';
|
|
connection node_1;
|
|
UPDATE p1 SET f2 = 'TO DEADLOCK' WHERE pk = 1;
|
|
COMMIT;
|
|
connection node_1a;
|
|
SET GLOBAL wsrep_provider_options = 'signal=apply_monitor_slave_enter_sync';
|
|
connection node_1;
|
|
ERROR 40001: Deadlock found when trying to get lock; try restarting transaction
|
|
SELECT 'I deadlocked';
|
|
I deadlocked
|
|
I deadlocked
|
|
SELECT COUNT(*) AS EXPECT_1 FROM p1 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_1
|
|
1
|
|
SELECT COUNT(*) AS EXPECT_2 FROM p2 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_2
|
|
2
|
|
connection node_2;
|
|
SELECT COUNT(*) AS EXPECT_1 FROM p1 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_1
|
|
1
|
|
SELECT COUNT(*) AS EXPECT_2 FROM p2 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_2
|
|
2
|
|
######################################################################
|
|
#
|
|
# Scenario #3: 2 DMLs working on two FK parent tables try to replicate,
|
|
# but fails in certification for earlier DDL on child table
|
|
# which is child to both FK parents
|
|
#
|
|
######################################################################
|
|
connection node_1;
|
|
BEGIN;
|
|
connection node_1b;
|
|
BEGIN;
|
|
connection node_1a;
|
|
SET GLOBAL wsrep_provider_options = 'dbug=d,apply_monitor_slave_enter_sync';
|
|
connection node_2;
|
|
ALTER TABLE c2 ENGINE=INNODB;
|
|
connection node_1a;
|
|
SET SESSION wsrep_on = 0;
|
|
SET SESSION wsrep_on = 1;
|
|
SET GLOBAL wsrep_provider_options = 'dbug=';
|
|
connection node_1;
|
|
UPDATE p1 SET f2 = 'TO DEADLOCK' WHERE pk = 1;
|
|
COMMIT;
|
|
connection node_1b;
|
|
UPDATE p2 SET f2 = 'TO DEADLOCK' WHERE pk = 2;
|
|
COMMIT;
|
|
connection node_1a;
|
|
SET GLOBAL wsrep_provider_options = 'signal=apply_monitor_slave_enter_sync';
|
|
connection node_1;
|
|
ERROR 40001: Deadlock found when trying to get lock; try restarting transaction
|
|
SELECT 'I deadlocked';
|
|
I deadlocked
|
|
I deadlocked
|
|
connection node_1b;
|
|
ERROR 40001: Deadlock found when trying to get lock; try restarting transaction
|
|
SELECT 'I deadlocked';
|
|
I deadlocked
|
|
I deadlocked
|
|
SELECT COUNT(*) AS EXPECT_1 FROM p1 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_1
|
|
1
|
|
SELECT COUNT(*) AS EXPECT_2 FROM p2 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_2
|
|
2
|
|
connection node_2;
|
|
SELECT COUNT(*) AS EXPECT_1 FROM p1 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_1
|
|
1
|
|
SELECT COUNT(*) AS EXPECT_2 FROM p2 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_2
|
|
2
|
|
DROP TABLE c1, c2;
|
|
DROP TABLE p1, p2;
|
|
######################################################################
|
|
# Test for TRUNCATE
|
|
######################################################################
|
|
######################################################################
|
|
#
|
|
# Scenario #1: DML working on FK parent table BF aborted by DDL
|
|
# over child table
|
|
#
|
|
######################################################################
|
|
connection node_1;
|
|
SET SESSION wsrep_sync_wait=0;
|
|
CREATE TABLE p1 (pk INTEGER PRIMARY KEY, f2 CHAR(30));
|
|
INSERT INTO p1 VALUES (1, 'INITIAL VALUE');
|
|
CREATE TABLE p2 (pk INTEGER PRIMARY KEY, f2 CHAR(30));
|
|
INSERT INTO p2 VALUES (1, 'INITIAL VALUE');
|
|
INSERT INTO p2 VALUES (2, 'INITIAL VALUE');
|
|
CREATE TABLE c1 (pk INTEGER PRIMARY KEY, fk INTEGER, FOREIGN KEY (fk) REFERENCES p1(pk));
|
|
INSERT INTO c1 VALUES (1,1);
|
|
CREATE TABLE c2 (pk INTEGER PRIMARY KEY, fk1 INTEGER, fk2 INTEGER, FOREIGN KEY (fk1) REFERENCES p1(pk), FOREIGN KEY (fk2) REFERENCES p2(pk));
|
|
INSERT INTO c2 VALUES (1,1,1), (2,1,2);
|
|
connection node_1;
|
|
SET AUTOCOMMIT=ON;
|
|
START TRANSACTION;
|
|
UPDATE p1 SET f2 = 'TO DEADLOCK' WHERE pk = 1;
|
|
connection node_2;
|
|
SET SESSION wsrep_sync_wait=0;
|
|
TRUNCATE TABLE c1 ;
|
|
connection node_1;
|
|
COMMIT;
|
|
ERROR 40001: Deadlock found when trying to get lock; try restarting transaction
|
|
SELECT COUNT(*) AS EXPECT_1 FROM p1 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_1
|
|
1
|
|
SELECT COUNT(*) AS EXPECT_2 FROM p2 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_2
|
|
2
|
|
connection node_2;
|
|
SELECT COUNT(*) AS EXPECT_1 FROM p1 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_1
|
|
1
|
|
SELECT COUNT(*) AS EXPECT_2 FROM p2 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_2
|
|
2
|
|
######################################################################
|
|
#
|
|
# Scenario #2: DML working on FK parent table tries to replicate, but
|
|
# fails in certification for earlier DDL on child table
|
|
#
|
|
######################################################################
|
|
connection node_1;
|
|
BEGIN;
|
|
SET GLOBAL wsrep_provider_options = 'dbug=d,apply_monitor_slave_enter_sync';
|
|
connection node_2;
|
|
TRUNCATE TABLE c1 ;
|
|
connection node_1a;
|
|
SET SESSION wsrep_on = 0;
|
|
SET SESSION wsrep_on = 1;
|
|
SET GLOBAL wsrep_provider_options = 'dbug=';
|
|
connection node_1;
|
|
UPDATE p1 SET f2 = 'TO DEADLOCK' WHERE pk = 1;
|
|
COMMIT;
|
|
connection node_1a;
|
|
SET GLOBAL wsrep_provider_options = 'signal=apply_monitor_slave_enter_sync';
|
|
connection node_1;
|
|
ERROR 40001: Deadlock found when trying to get lock; try restarting transaction
|
|
SELECT 'I deadlocked';
|
|
I deadlocked
|
|
I deadlocked
|
|
SELECT COUNT(*) AS EXPECT_1 FROM p1 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_1
|
|
1
|
|
SELECT COUNT(*) AS EXPECT_2 FROM p2 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_2
|
|
2
|
|
connection node_2;
|
|
SELECT COUNT(*) AS EXPECT_1 FROM p1 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_1
|
|
1
|
|
SELECT COUNT(*) AS EXPECT_2 FROM p2 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_2
|
|
2
|
|
######################################################################
|
|
#
|
|
# Scenario #3: 2 DMLs working on two FK parent tables try to replicate,
|
|
# but fails in certification for earlier DDL on child table
|
|
# which is child to both FK parents
|
|
#
|
|
######################################################################
|
|
connection node_1;
|
|
BEGIN;
|
|
connection node_1b;
|
|
BEGIN;
|
|
connection node_1a;
|
|
SET GLOBAL wsrep_provider_options = 'dbug=d,apply_monitor_slave_enter_sync';
|
|
connection node_2;
|
|
TRUNCATE TABLE c2 ;
|
|
connection node_1a;
|
|
SET SESSION wsrep_on = 0;
|
|
SET SESSION wsrep_on = 1;
|
|
SET GLOBAL wsrep_provider_options = 'dbug=';
|
|
connection node_1;
|
|
UPDATE p1 SET f2 = 'TO DEADLOCK' WHERE pk = 1;
|
|
COMMIT;
|
|
connection node_1b;
|
|
UPDATE p2 SET f2 = 'TO DEADLOCK' WHERE pk = 2;
|
|
COMMIT;
|
|
connection node_1a;
|
|
SET GLOBAL wsrep_provider_options = 'signal=apply_monitor_slave_enter_sync';
|
|
connection node_1;
|
|
ERROR 40001: Deadlock found when trying to get lock; try restarting transaction
|
|
SELECT 'I deadlocked';
|
|
I deadlocked
|
|
I deadlocked
|
|
connection node_1b;
|
|
ERROR 40001: Deadlock found when trying to get lock; try restarting transaction
|
|
SELECT 'I deadlocked';
|
|
I deadlocked
|
|
I deadlocked
|
|
SELECT COUNT(*) AS EXPECT_1 FROM p1 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_1
|
|
1
|
|
SELECT COUNT(*) AS EXPECT_2 FROM p2 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_2
|
|
2
|
|
connection node_2;
|
|
SELECT COUNT(*) AS EXPECT_1 FROM p1 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_1
|
|
1
|
|
SELECT COUNT(*) AS EXPECT_2 FROM p2 WHERE f2 = 'INITIAL VALUE';
|
|
EXPECT_2
|
|
2
|
|
DROP TABLE c1, c2;
|
|
DROP TABLE p1, p2;
|