mirror of
https://github.com/MariaDB/server.git
synced 2025-02-04 21:02:17 +01:00
902ace0968
The problem resided in this branch of the "option_value_no_option_type" rule:
| '@' '@' opt_var_ident_type internal_variable_name equal set_expr_or_default
Summary:
1. internal_variable_name initialized tmp.var to trg_new_row_fake_var (0x01).
2. The condition "if (tmp.var == NULL)" did not check
the special case with trg_new_row_fake_var,
so Lex->set_system_variable(&tmp, $3, $6) was
called with tmp.var pointing to trg_new_row_fake_var,
which created a sys_var instance pointing to 0x01 instead of
a real system variable.
3. Later, at the trigger invocation time, this method was called:
sys_var::do_deprecated_warning (this=0x1, thd=0x7ffe6c000a98)
Notice, "this" is equal to trg_new_row_fake_var (0x01)
Solution:
The old implementation with separate rules
internal_variable_name (in sql_yacc.yy and sql_yacc_ora.yy) and
internal_variable_name_directly_assignable (in sql_yacc_ora.yy only)
was too complex and hard to follow.
Rewriting the code in a more straightforward way.
1. Changing LEX::set_system_variable()
from:
bool set_system_variable(struct sys_var_with_base *, enum_var_type, Item *);
to:
bool set_system_variable(enum_var_type, sys_var *, const LEX_CSTRING *, Item *);
2. Adding new methods in LEX, which operate with variable names:
bool set_trigger_field(const LEX_CSTRING *, const LEX_CSTRING *, Item *);
bool set_system_variable(enum_var_type var_type, const LEX_CSTRING *name,
Item *val);
bool set_system_variable(THD *thd, enum_var_type var_type,
const LEX_CSTRING *name1,
const LEX_CSTRING *name2,
Item *val);
bool set_default_system_variable(enum_var_type var_type,
const LEX_CSTRING *name,
Item *val);
bool set_variable(const LEX_CSTRING *name, Item *item);
3. Changing the grammar to call the new methods directly
in option_value_no_option_type,
Removing rules internal_variable_name and
internal_variable_name_directly_assignable.
4. Removing "struct sys_var_with_base" and trg_new_row_fake_var.
Good side effect:
- The code in /sql reduced from 314 to 183 lines.
- MDEV-15615 Unexpected syntax error instead of "Unknown system variable" ...
was also fixed automatically
100 lines
2.7 KiB
Text
100 lines
2.7 KiB
Text
set sql_mode=ORACLE;
|
|
:NEW.a := 1;
|
|
ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':NEW.a := 1' at line 1
|
|
:OLD.a := 1;
|
|
ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':OLD.a := 1' at line 1
|
|
:OLa.a := 1;
|
|
ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ':OLa.a := 1' at line 1
|
|
SELECT :NEW.a;
|
|
ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'a' at line 1
|
|
SELECT :OLD.a;
|
|
ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'a' at line 1
|
|
SELECT :OLa.a;
|
|
ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'a' at line 1
|
|
CREATE TABLE t1 (a INT);
|
|
CREATE TRIGGER tr1 BEFORE INSERT ON t1 FOR EACH ROW NEW.a:= 10;
|
|
INSERT INTO t1 VALUES ();
|
|
SELECT * FROM t1;
|
|
a
|
|
10
|
|
DROP TRIGGER tr1;
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1 (a INT);
|
|
CREATE TRIGGER tr1 BEFORE INSERT ON t1 FOR EACH ROW :NEW.a:= 10;
|
|
INSERT INTO t1 VALUES ();
|
|
SELECT * FROM t1;
|
|
a
|
|
10
|
|
DROP TRIGGER tr1;
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1 (a INT);
|
|
CREATE TRIGGER tr1 BEFORE INSERT ON t1 FOR EACH ROW
|
|
BEGIN
|
|
IF :NEW.a IS NULL
|
|
THEN
|
|
:NEW.a:= 10;
|
|
END IF;
|
|
END;
|
|
/
|
|
INSERT INTO t1 VALUES (NULL);
|
|
SELECT * FROM t1;
|
|
a
|
|
10
|
|
DROP TRIGGER tr1;
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1 (a INT);
|
|
CREATE TRIGGER tr1 BEFORE UPDATE ON t1 FOR EACH ROW
|
|
BEGIN
|
|
IF :OLD.a IS NULL
|
|
THEN
|
|
:NEW.a:= 10;
|
|
END IF;
|
|
END;
|
|
/
|
|
INSERT INTO t1 VALUES (NULL);
|
|
UPDATE t1 SET a=NULL;
|
|
SELECT * FROM t1;
|
|
a
|
|
10
|
|
DROP TRIGGER tr1;
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1 (a INT, b INT, c INT);
|
|
CREATE TRIGGER tr1 BEFORE INSERT ON t1
|
|
FOR EACH ROW
|
|
DECLARE
|
|
cnt INT := 0;
|
|
BEGIN
|
|
IF :NEW.a IS NULL THEN cnt:=cnt+1; END IF;
|
|
IF :NEW.b IS NULL THEN cnt:=cnt+1; END IF;
|
|
IF :NEW.c IS NULL THEN :NEW.c:=cnt; END IF;
|
|
END;
|
|
/
|
|
INSERT INTO t1 VALUES ();
|
|
INSERT INTO t1 VALUES (1, NULL, NULL);
|
|
INSERT INTO t1 VALUES (NULL, 1, NULL);
|
|
INSERT INTO t1 VALUES (1, 1, NULL);
|
|
SELECT * FROM t1;
|
|
a b c
|
|
NULL NULL 2
|
|
1 NULL 1
|
|
NULL 1 1
|
|
1 1 0
|
|
DROP TABLE t1;
|
|
#
|
|
# MDEV-10577 sql_mode=ORACLE: %TYPE in variable declarations
|
|
#
|
|
CREATE TABLE t1 (a INT, b INT, total INT);
|
|
CREATE TRIGGER tr1 BEFORE INSERT ON t1
|
|
FOR EACH ROW
|
|
DECLARE
|
|
va t1.a%TYPE:= :NEW.a;
|
|
vb t1.b%TYPE:= :NEW.b;
|
|
BEGIN
|
|
:NEW.total:= va + vb;
|
|
END;
|
|
$$
|
|
INSERT INTO t1 (a,b) VALUES (10, 20);
|
|
SELECT * FROM t1;
|
|
a b total
|
|
10 20 30
|
|
DROP TABLE t1;
|