mirror of
https://github.com/MariaDB/server.git
synced 2025-02-09 23:24:11 +01:00
2b6d241ee4
The crash happened with an indexed virtual column whose value is evaluated using a function that has a different meaning in sql_mode='' vs sql_mode=ORACLE: - DECODE() - LTRIM() - RTRIM() - LPAD() - RPAD() - REPLACE() - SUBSTR() For example: CREATE TABLE t1 ( b VARCHAR(1), g CHAR(1) GENERATED ALWAYS AS (SUBSTR(b,0,0)) VIRTUAL, KEY g(g) ); So far we had replacement XXX_ORACLE() functions for all mentioned function, e.g. SUBSTR_ORACLE() for SUBSTR(). So it was possible to correctly re-parse SUBSTR_ORACLE() even in sql_mode=''. But it was not possible to re-parse the MariaDB version of SUBSTR() after switching to sql_mode=ORACLE. It was erroneously mis-interpreted as SUBSTR_ORACLE(). As a result, this combination worked fine: SET sql_mode=ORACLE; CREATE TABLE t1 ... g CHAR(1) GENERATED ALWAYS AS (SUBSTR(b,0,0)) VIRTUAL, ...; INSERT ... FLUSH TABLES; SET sql_mode=''; INSERT ... But the other way around it crashed: SET sql_mode=''; CREATE TABLE t1 ... g CHAR(1) GENERATED ALWAYS AS (SUBSTR(b,0,0)) VIRTUAL, ...; INSERT ... FLUSH TABLES; SET sql_mode=ORACLE; INSERT ... At CREATE time, SUBSTR was instantiated as Item_func_substr and printed in the FRM file as substr(). At re-open time with sql_mode=ORACLE, "substr()" was erroneously instantiated as Item_func_substr_oracle. Fix: The fix proposes a symmetric solution. It provides a way to re-parse reliably all sql_mode dependent functions to their original CREATE TABLE time meaning, no matter what the open-time sql_mode is. We take advantage of the same idea we previously used to resolve sql_mode dependent data types. Now all sql_mode dependent functions are printed by SHOW using a schema qualifier when the current sql_mode differs from the function sql_mode: SET sql_mode=''; CREATE TABLE t1 ... SUBSTR(a,b,c) ..; SET sql_mode=ORACLE; SHOW CREATE TABLE t1; -> mariadb_schema.substr(a,b,c) SET sql_mode=ORACLE; CREATE TABLE t2 ... SUBSTR(a,b,c) ..; SET sql_mode=''; SHOW CREATE TABLE t1; -> oracle_schema.substr(a,b,c) Old replacement names like substr_oracle() are still understood for backward compatibility and used in FRM files (for downgrade compatibility), but they are not printed by SHOW any more.
71 lines
2.8 KiB
Text
71 lines
2.8 KiB
Text
SET sql_mode=ORACLE;
|
|
#
|
|
# MDEV-15739 - sql_mode=ORACLE: Make LPAD and RPAD return NULL instead of empty string
|
|
#
|
|
SELECT RPAD('a',0), RPAD('abc',1), RPAD('abc',2) ;
|
|
RPAD('a',0) RPAD('abc',1) RPAD('abc',2)
|
|
NULL a ab
|
|
SELECT RPAD('a',0,'.'), RPAD('abc',1,'.'), RPAD('abc',2,'.') ;
|
|
RPAD('a',0,'.') RPAD('abc',1,'.') RPAD('abc',2,'.')
|
|
NULL a ab
|
|
SELECT LPAD('a',0), LPAD('abc',1), LPAD('abc',2) ;
|
|
LPAD('a',0) LPAD('abc',1) LPAD('abc',2)
|
|
NULL a ab
|
|
SELECT LPAD('a',0,'.'), LPAD('abc',1,'.'), LPAD('abc',2,'.') ;
|
|
LPAD('a',0,'.') LPAD('abc',1,'.') LPAD('abc',2,'.')
|
|
NULL a ab
|
|
CREATE TABLE t1 (c1 VARCHAR(10),c2 INTEGER, c3 VARCHAR(10), ord INTEGER);
|
|
INSERT INTO t1 VALUES ('a',1,null,1);
|
|
INSERT INTO t1 VALUES ('a',null,'.',2);
|
|
INSERT INTO t1 VALUES (null,1,'.',3);
|
|
INSERT INTO t1 VALUES ('a',-1,'.',4);
|
|
INSERT INTO t1 VALUES ('a',0,'.',5);
|
|
INSERT INTO t1 VALUES ('a',1,'.',6);
|
|
INSERT INTO t1 VALUES ('a',2,'.',7);
|
|
SELECT LPAD(c1,c2,c3), LPAD(c1,c2) FROM t1 ORDER BY ord;
|
|
LPAD(c1,c2,c3) LPAD(c1,c2)
|
|
NULL a
|
|
NULL NULL
|
|
NULL NULL
|
|
NULL NULL
|
|
NULL NULL
|
|
a a
|
|
.a a
|
|
SELECT RPAD(c1,c2,c3), RPAD(c1,c2) FROM t1 ORDER BY ord;
|
|
RPAD(c1,c2,c3) RPAD(c1,c2)
|
|
NULL a
|
|
NULL NULL
|
|
NULL NULL
|
|
NULL NULL
|
|
NULL NULL
|
|
a a
|
|
a. a
|
|
EXPLAIN EXTENDED SELECT RPAD('a',0,'.'), LPAD('a',0,'.'), LPAD(c1,c2,c3), LPAD(c1,c2), RPAD(c1,c2,c3), RPAD(c1,c2) FROM t1 ORDER BY ord;
|
|
id select_type table type possible_keys key key_len ref rows filtered Extra
|
|
1 SIMPLE t1 ALL NULL NULL NULL NULL 7 100.00 Using filesort
|
|
Warnings:
|
|
Note 1003 select rpad('a',0,'.') AS "RPAD('a',0,'.')",lpad('a',0,'.') AS "LPAD('a',0,'.')",lpad("test"."t1"."c1","test"."t1"."c2","test"."t1"."c3") AS "LPAD(c1,c2,c3)",lpad("test"."t1"."c1","test"."t1"."c2") AS "LPAD(c1,c2)",rpad("test"."t1"."c1","test"."t1"."c2","test"."t1"."c3") AS "RPAD(c1,c2,c3)",rpad("test"."t1"."c1","test"."t1"."c2") AS "RPAD(c1,c2)" from "test"."t1" order by "test"."t1"."ord"
|
|
CREATE VIEW v1 AS SELECT RPAD('a',0,'.') AS "C1", LPAD('a',0,'.') AS "C2", LPAD(c1,c2,c3) AS "C3", LPAD(c1,c2) AS "C4", RPAD(c1,c2,c3) AS "C5", RPAD(c1,c2) AS "C6" FROM t1 ORDER BY ord;
|
|
SHOW CREATE VIEW v1;
|
|
View Create View character_set_client collation_connection
|
|
v1 CREATE VIEW "v1" AS select rpad('a',0,'.') AS "C1",lpad('a',0,'.') AS "C2",lpad("t1"."c1","t1"."c2","t1"."c3") AS "C3",lpad("t1"."c1","t1"."c2") AS "C4",rpad("t1"."c1","t1"."c2","t1"."c3") AS "C5",rpad("t1"."c1","t1"."c2") AS "C6" from "t1" order by "t1"."ord" latin1 latin1_swedish_ci
|
|
SELECT * FROM v1;
|
|
C1 C2 C3 C4 C5 C6
|
|
NULL NULL NULL a NULL a
|
|
NULL NULL NULL NULL NULL NULL
|
|
NULL NULL NULL NULL NULL NULL
|
|
NULL NULL NULL NULL NULL NULL
|
|
NULL NULL NULL NULL NULL NULL
|
|
NULL NULL a a a a
|
|
NULL NULL .a a a. a
|
|
SELECT c1||'-'||c2||'-'||c3||'-'||c4||'-'||c5||'-'||c6 FROM v1;
|
|
c1||'-'||c2||'-'||c3||'-'||c4||'-'||c5||'-'||c6
|
|
---a--a
|
|
-----
|
|
-----
|
|
-----
|
|
-----
|
|
--a-a-a-a
|
|
--.a- a-a.-a
|
|
DROP VIEW v1;
|
|
DROP TABLE t1;
|