mirror of
https://github.com/MariaDB/server.git
synced 2025-02-04 21:02:17 +01:00
3cef4f8f0f
We implement an idea that was suggested by Michael 'Monty' Widenius in October 2017: When InnoDB is inserting into an empty table or partition, we can write a single undo log record TRX_UNDO_EMPTY, which will cause ROLLBACK to clear the table. For this to work, the insert into an empty table or partition must be covered by an exclusive table lock that will be held until the transaction has been committed or rolled back, or the INSERT operation has been rolled back (and the table is empty again), in lock_table_x_unlock(). Clustered index records that are covered by the TRX_UNDO_EMPTY record will carry DB_TRX_ID=0 and DB_ROLL_PTR=1<<55, and thus they cannot be distinguished from what MDEV-12288 leaves behind after purging the history of row-logged operations. Concurrent non-locking reads must be adjusted: If the read view was created before the INSERT into an empty table, then we must continue to imagine that the table is empty, and not try to read any records. If the read view was created after the INSERT was committed, then all records must be visible normally. To implement this, we introduce the field dict_table_t::bulk_trx_id. This special handling only applies to the very first INSERT statement of a transaction for the empty table or partition. If a subsequent statement in the transaction is modifying the initially empty table again, we must enable row-level undo logging, so that we will be able to roll back to the start of the statement in case of an error (such as duplicate key). INSERT IGNORE will continue to use row-level logging and locking, because implementing it would require the ability to roll back the latest row. Since the undo log that we write only allows us to roll back the entire statement, we cannot support INSERT IGNORE. We will introduce a handler::extra() parameter HA_EXTRA_IGNORE_INSERT to indicate to storage engines that INSERT IGNORE is being executed. In many test cases, we add an extra record to the table, so that during the 'interesting' part of the test, row-level locking and logging will be used. Replicas will continue to use row-level logging and locking until MDEV-24622 has been addressed. Likewise, this optimization will be disabled in Galera cluster until MDEV-24623 enables it. dict_table_t::bulk_trx_id: The latest active or committed transaction that initiated an insert into an empty table or partition. Protected by exclusive table lock and a clustered index leaf page latch. ins_node_t::bulk_insert: Whether bulk insert was initiated. trx_t::mod_tables: Use C++11 style accessors (emplace instead of insert). Unlike earlier, this collection will cover also temporary tables. trx_mod_table_time_t: Add start_bulk_insert(), end_bulk_insert(), is_bulk_insert(), was_bulk_insert(). trx_undo_report_row_operation(): Before accessing any undo log pages, invoke trx->mod_tables.emplace() in order to determine whether undo logging was disabled, or whether this is the first INSERT and we are supposed to write a TRX_UNDO_EMPTY record. row_ins_clust_index_entry_low(): If we are inserting into an empty clustered index leaf page, set the ins_node_t::bulk_insert flag for the subsequent trx_undo_report_row_operation() call. lock_rec_insert_check_and_lock(), lock_prdt_insert_check_and_lock(): Remove the redundant parameter 'flags' that can be checked in the caller. btr_cur_ins_lock_and_undo(): Simplify the logic. Correctly write DB_TRX_ID,DB_ROLL_PTR after invoking trx_undo_report_row_operation(). trx_mark_sql_stat_end(), ha_innobase::extra(HA_EXTRA_IGNORE_INSERT), ha_innobase::external_lock(): Invoke trx_t::end_bulk_insert() so that the next statement will not be covered by table-level undo logging. ReadView::changes_visible(trx_id_t) const: New accessor for the case where the trx_id_t is not read from a potentially corrupted index page but directly from the memory. In this case, we can skip a sanity check. row_sel(), row_sel_try_search_shortcut(), row_search_mvcc(): row_sel_try_search_shortcut_for_mysql(), row_merge_read_clustered_index(): Check dict_table_t::bulk_trx_id. row_sel_clust_sees(): Replaces lock_clust_rec_cons_read_sees(). lock_sec_rec_cons_read_sees(): Replaced with lower-level code. btr_root_page_init(): Refactored from btr_create(). dict_index_t::clear(), dict_table_t::clear(): Empty an index or table, for the ROLLBACK of an INSERT operation. ROW_T_EMPTY, ROW_OP_EMPTY: Note a concurrent ROLLBACK of an INSERT into an empty table. This is joint work with Thirunarayanan Balathandayuthapani, who created a working prototype. Thanks to Matthias Leich for extensive testing.
106 lines
3.6 KiB
PHP
106 lines
3.6 KiB
PHP
--source include/have_innodb.inc
|
|
--source include/have_perfschema.inc
|
|
#
|
|
# The test verifies binlogging of XA transaction and state of prepared XA
|
|
# as far as binlog is concerned.
|
|
#
|
|
# The prepared XA transactions can be disconnected from the client,
|
|
# discovered from another connection and commited or rolled back
|
|
# later. They also survive the server restart. The test runs two
|
|
# loops each consisting of prepared XA:s generation, their
|
|
# manipulation and a server restart followed with survived XA:s
|
|
# completion.
|
|
#
|
|
# Prepared XA can't get available to an external connection
|
|
# until connection that either leaves actively or is killed
|
|
# has completed a necessary part of its cleanup.
|
|
# Selecting from P_S.threads provides a method to learn that.
|
|
#
|
|
# Total number of connection each performing one insert into table
|
|
--let $conn_number=20
|
|
# Number of rollbacks and commits from either side of the server restart
|
|
--let $rollback_number=5
|
|
--let $commit_number=5
|
|
# Number of transactions that are terminated before server restarts
|
|
--let $term_number=`SELECT $rollback_number + $commit_number`
|
|
# Instead of disconnect make some connections killed when their
|
|
# transactions got prepared.
|
|
--let $killed_number=5
|
|
# make some connections disconnected by shutdown rather than actively
|
|
--let $server_disconn_number=5
|
|
--let $prepared_at_server_restart = `SELECT $conn_number - $term_number`
|
|
# number a "warmup" connection after server restart, they all commit
|
|
--let $post_restart_conn_number=10
|
|
|
|
# Counter to be used in GTID consistency check.
|
|
# It's incremented per each non-XA transaction commit.
|
|
# Local to this file variable to control one-phase commit loop
|
|
--let $one_phase_number = 5
|
|
|
|
--connection default
|
|
|
|
# Remove possibly preceeding binlogs and clear initialization time
|
|
# GTID executed info. In the following all transactions are counted
|
|
# to conduct verification at the end of the test.
|
|
if (`SELECT @@global.log_bin`)
|
|
{
|
|
RESET MASTER;
|
|
}
|
|
|
|
# Disconected and follower threads need synchronization
|
|
CREATE VIEW v_processlist as SELECT * FROM performance_schema.threads where type = 'FOREGROUND';
|
|
|
|
--eval call mtr.add_suppression("Found $prepared_at_server_restart prepared XA transactions")
|
|
|
|
CREATE TABLE t (a INT) ENGINE=innodb;
|
|
|
|
# MDEV-515 takes X-lock on the table for the first insert.
|
|
# So concurrent insert won't happen on the table
|
|
INSERT INTO t VALUES(100);
|
|
|
|
# Counter is incremented at the end of post restart to
|
|
# reflect number of loops done in correctness computation.
|
|
--let $restart_number = 0
|
|
--let $how_to_restart=restart_mysqld.inc
|
|
--source suite/binlog/include/binlog_xa_prepared_do_and_restart.inc
|
|
|
|
--let $how_to_restart=kill_and_restart_mysqld.inc
|
|
--source suite/binlog/include/binlog_xa_prepared_do_and_restart.inc
|
|
|
|
--connection default
|
|
|
|
# Few xs that commit in one phase, not subject to the server restart
|
|
# nor reconnect.
|
|
# This piece of test is related to mysqlbinlog recovery examine below.
|
|
--let $k = 0
|
|
while ($k < $one_phase_number)
|
|
{
|
|
--eval XA START 'one_phase_trx_$k'
|
|
--eval INSERT INTO t SET a=$k
|
|
--eval XA END 'one_phase_trx_$k'
|
|
--eval XA COMMIT 'one_phase_trx_$k' ONE PHASE
|
|
|
|
--inc $k
|
|
}
|
|
|
|
SELECT SUM(a) FROM t;
|
|
DROP TABLE t;
|
|
DROP VIEW v_processlist;
|
|
|
|
let $outfile= $MYSQLTEST_VARDIR/tmp/mysqlbinlog.sql;
|
|
if (`SELECT @@global.log_bin`)
|
|
{
|
|
# Recording proper samples of binlogged prepared XA:s
|
|
--source include/show_binlog_events.inc
|
|
--exec $MYSQL_BINLOG -R --to-last-log master-bin.000001 > $outfile
|
|
}
|
|
|
|
--echo All transactions must be completed, to empty-list the following:
|
|
XA RECOVER;
|
|
|
|
if (`SELECT @@global.log_bin`)
|
|
{
|
|
--exec $MYSQL test < $outfile
|
|
--remove_file $outfile
|
|
XA RECOVER;
|
|
}
|