mirror of
				https://github.com/MariaDB/server.git
				synced 2025-10-31 10:56:12 +01:00 
			
		
		
		
	 0ccdf54b64
			
		
	
	
	0ccdf54b64
	
	
	
		
			
			I checked all stack overflow potential problems found with gcc -Wstack-usage=16384 and clang -Wframe-larger-than=16384 -no-inline Fixes: Added '#pragma clang diagnostic ignored "-Wframe-larger-than="' to a lot of function to where stack usage large but resonable. - Added stack check warnings to BUILD scrips when using clang and debug. Function changed to use malloc instead allocating things on stack: - read_bootstrap_query() now allocates line_buffer (20000 bytes) with malloc() instead of using stack. This has a small performance impact but this is not releant for bootstrap. - mroonga grn_select() used 65856 bytes on stack. Changed it to use malloc(). - Wsrep_schema::replay_transaction() and Wsrep_schema::recover_sr_transactions(). - Connect zipOpen3() Not fixed: - mroonga/vendor/groonga/lib/expr.c grn_proc_call() uses 43712 byte on stack. However this is not easy to fix as the stack used is caused by a lot of code generated by defines. - Most changes in mroonga/groonga where only adding of pragmas to disable stack warnings. - rocksdb/options/options_helper.cc uses 20288 of stack space. (no reason to fix except to get rid of the compiler warning) - Causes using alloca() where the allocation size is resonable. - An issue in libmariadb (reported to connectors).
		
			
				
	
	
		
			477 lines
		
	
	
	
		
			13 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			477 lines
		
	
	
	
		
			13 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /* Copyright (C) 2015 MariaDB
 | |
| 
 | |
|    This program is free software; you can redistribute it and/or modify
 | |
|    it under the terms of the GNU General Public License as published by
 | |
|    the Free Software Foundation; version 2 of the License.
 | |
| 
 | |
|    This program is distributed in the hope that it will be useful,
 | |
|    but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
|    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | |
|    GNU General Public License for more details.
 | |
| 
 | |
|    You should have received a copy of the GNU General Public License
 | |
|    along with this program; if not, write to the Free Software
 | |
|    Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1335 USA */
 | |
| 
 | |
| #include <my_global.h>
 | |
| #include <my_sys.h>
 | |
| #include <my_crypt.h>
 | |
| #include <tap.h>
 | |
| 
 | |
| /*** tweaks and stubs for encryption code to compile ***************/
 | |
| #define KEY_SIZE (128/8)
 | |
| 
 | |
| my_bool encrypt_tmp_files;
 | |
| int init_io_cache_encryption();
 | |
| 
 | |
| uint encryption_key_get_latest_version_func(uint)
 | |
| {
 | |
|   return 1;
 | |
| }
 | |
| 
 | |
| uint encryption_key_id_exists_func(uint)
 | |
| {
 | |
|   return 1;
 | |
| }
 | |
| 
 | |
| uint encryption_key_version_exists_func(uint, uint)
 | |
| {
 | |
|   return 1;
 | |
| }
 | |
| 
 | |
| uint encryption_key_get_func(uint, uint, uchar* key, uint* size)
 | |
| {
 | |
|   if (*size < KEY_SIZE)
 | |
|   {
 | |
|     *size= KEY_SIZE;
 | |
|     return ENCRYPTION_KEY_BUFFER_TOO_SMALL;
 | |
|   }
 | |
|   memset(key, KEY_SIZE, *size= KEY_SIZE);
 | |
|   return 0;
 | |
| }
 | |
| 
 | |
| uint encryption_ctx_size_func(unsigned int, unsigned int)
 | |
| {
 | |
|   return MY_AES_CTX_SIZE;
 | |
| }
 | |
| 
 | |
| 
 | |
| #ifdef HAVE_EncryptAes128Gcm
 | |
| enum my_aes_mode aes_mode= MY_AES_GCM;
 | |
| #else
 | |
| enum my_aes_mode aes_mode= MY_AES_CBC;
 | |
| #endif
 | |
| 
 | |
| int encryption_ctx_init_func(void *ctx, const unsigned char* key, unsigned int klen,
 | |
|                                 const unsigned char* iv, unsigned int ivlen,
 | |
|                                 int flags, unsigned int key_id,
 | |
|                                 unsigned int key_version)
 | |
| {
 | |
|   return my_aes_crypt_init(ctx, aes_mode, flags, key, klen, iv, ivlen);
 | |
| }
 | |
| 
 | |
| uint encryption_encrypted_length_func(unsigned int slen, unsigned int key_id, unsigned int key_version)
 | |
| {
 | |
|   return my_aes_get_size(aes_mode, slen);
 | |
| }
 | |
| 
 | |
| struct encryption_service_st encryption_handler=
 | |
| {
 | |
|   encryption_key_get_latest_version_func,
 | |
|   encryption_key_get_func,
 | |
|   encryption_ctx_size_func,
 | |
|   encryption_ctx_init_func,
 | |
|   my_aes_crypt_update,
 | |
|   my_aes_crypt_finish,
 | |
|   encryption_encrypted_length_func
 | |
| };
 | |
| 
 | |
| void sql_print_information(const char *format, ...)
 | |
| {
 | |
| }
 | |
| 
 | |
| void sql_print_error(const char *format, ...)
 | |
| {
 | |
| }
 | |
| 
 | |
| /*** end of encryption tweaks and stubs ****************************/
 | |
| 
 | |
| PRAGMA_DISABLE_CHECK_STACK_FRAME
 | |
| 
 | |
| static IO_CACHE info;
 | |
| #define CACHE_SIZE 16384
 | |
| 
 | |
| #define INFO_TAIL ", pos_in_file = %llu, pos_in_mem = %lu", \
 | |
|     info.pos_in_file, (ulong) ((info.type == READ_CACHE ? info.read_pos : info.write_pos) - info.request_pos)
 | |
| 
 | |
| #define FILL 0x5A
 | |
| 
 | |
| int data_bad(const uchar *buf, size_t len)
 | |
| {
 | |
|   const uchar *end= buf + len;
 | |
|   while (buf < end)
 | |
|     if (*buf++ != FILL)
 | |
|       return 1;
 | |
|   return 0;
 | |
| }
 | |
| 
 | |
| void temp_io_cache()
 | |
| {
 | |
|   int res;
 | |
|   uchar buf[CACHE_SIZE + 200];
 | |
|   memset(buf, FILL, sizeof(buf));
 | |
| 
 | |
|   diag("temp io_cache with%s encryption", encrypt_tmp_files?"":"out");
 | |
| 
 | |
|   init_io_cache_encryption();  
 | |
|   
 | |
|   res= open_cached_file(&info, 0, 0, CACHE_SIZE, 0);
 | |
|   ok(res == 0, "open_cached_file" INFO_TAIL);
 | |
| 
 | |
|   res= my_b_write(&info, buf, 100);
 | |
|   ok(res == 0 && info.pos_in_file == 0, "small write" INFO_TAIL );
 | |
| 
 | |
|   res= my_b_write(&info, buf, sizeof(buf));
 | |
|   ok(res == 0 && info.pos_in_file == CACHE_SIZE, "large write" INFO_TAIL);
 | |
| 
 | |
|   res= reinit_io_cache(&info, WRITE_CACHE, 250, 0, 0);
 | |
|   ok(res == 0, "reinit with rewind" INFO_TAIL);
 | |
| 
 | |
|   res= my_b_write(&info, buf, sizeof(buf));
 | |
|   ok(res == 0, "large write" INFO_TAIL);
 | |
| 
 | |
|   res= my_b_flush_io_cache(&info, 1);
 | |
|   ok(res == 0, "flush" INFO_TAIL);
 | |
| 
 | |
|   res= reinit_io_cache(&info, READ_CACHE, 0, 0, 0);
 | |
|   ok(res == 0, "reinit READ_CACHE" INFO_TAIL);
 | |
| 
 | |
|   res= (int)my_pread(info.file, buf, 50, 50, MYF(MY_NABP));
 | |
|   ok(res == 0 && data_bad(buf, 50) == encrypt_tmp_files,
 | |
|      "file must be %sreadable", encrypt_tmp_files ?"un":"");
 | |
| 
 | |
|   res= my_b_read(&info, buf, 50) || data_bad(buf, 50);
 | |
|   ok(res == 0 && info.pos_in_file == 0, "small read" INFO_TAIL);
 | |
| 
 | |
|   res= my_b_read(&info, buf, sizeof(buf)) || data_bad(buf, sizeof(buf));
 | |
|   ok(res == 0 && info.pos_in_file == CACHE_SIZE, "large read" INFO_TAIL);
 | |
| 
 | |
|   close_cached_file(&info);
 | |
| }
 | |
| 
 | |
| void mdev9044()
 | |
| {
 | |
|   int res;
 | |
|   uchar buf[CACHE_SIZE + 200];
 | |
| 
 | |
|   diag("MDEV-9044 Binlog corruption in Galera");
 | |
| 
 | |
|   res= open_cached_file(&info, 0, 0, CACHE_SIZE, 0);
 | |
|   ok(res == 0, "open_cached_file" INFO_TAIL);
 | |
| 
 | |
|   res= my_b_write(&info, USTRING_WITH_LEN("first write\0"));
 | |
|   ok(res == 0, "first write" INFO_TAIL);
 | |
| 
 | |
|   res= my_b_flush_io_cache(&info, 1);
 | |
|   ok(res == 0, "flush" INFO_TAIL);
 | |
| 
 | |
|   res= reinit_io_cache(&info, WRITE_CACHE, 0, 0, 0);
 | |
|   ok(res == 0, "reinit WRITE_CACHE" INFO_TAIL);
 | |
| 
 | |
|   res= my_b_write(&info, USTRING_WITH_LEN("second write\0"));
 | |
|   ok(res == 0, "second write" INFO_TAIL );
 | |
| 
 | |
|   res= reinit_io_cache(&info, READ_CACHE, 0, 0, 0);
 | |
|   ok(res == 0, "reinit READ_CACHE" INFO_TAIL);
 | |
| 
 | |
|   res= (int)my_b_fill(&info);
 | |
|   ok(res == 0, "fill" INFO_TAIL);
 | |
| 
 | |
|   res= reinit_io_cache(&info, READ_CACHE, 0, 0, 0);
 | |
|   ok(res == 0, "reinit READ_CACHE" INFO_TAIL);
 | |
| 
 | |
|   res= my_b_read(&info, buf, sizeof(buf));
 | |
|   ok(res == 1 && strcmp((char*)buf, "second write") == 0, "read '%s'", buf);
 | |
| 
 | |
|   close_cached_file(&info);
 | |
| }
 | |
| 
 | |
| /* 2 Reads (with my_b_fill) in cache makes second read to fail */
 | |
| void mdev10259()
 | |
| {
 | |
|   int res;
 | |
|   uchar buf[200];
 | |
|   memset(buf, FILL, sizeof(buf));
 | |
| 
 | |
|   diag("MDEV-10259- mysqld crash with certain statement length and order with"
 | |
|          " Galera and encrypt-tmp-files=1");
 | |
| 
 | |
|   init_io_cache_encryption();
 | |
| 
 | |
|   res= open_cached_file(&info, 0, 0, CACHE_SIZE, 0);
 | |
|   ok(res == 0, "open_cached_file" INFO_TAIL);
 | |
| 
 | |
|   res= my_b_write(&info, buf, sizeof(buf));
 | |
|   ok(res == 0 && info.pos_in_file == 0, "200 write" INFO_TAIL);
 | |
| 
 | |
|   res= my_b_flush_io_cache(&info, 1);
 | |
|   ok(res == 0, "flush" INFO_TAIL);
 | |
| 
 | |
|   my_off_t saved_pos=  my_b_tell(&info);
 | |
|   res= reinit_io_cache(&info, READ_CACHE, 0, 0, 0);
 | |
|   ok(res == 0, "reinit READ_CACHE" INFO_TAIL);
 | |
| 
 | |
|   size_t s= my_b_fill(&info);
 | |
|   ok(s == 200, "fill" INFO_TAIL);
 | |
| 
 | |
|   s= my_b_fill(&info);
 | |
|   ok(s == 0, "fill" INFO_TAIL);
 | |
| 
 | |
|   s= my_b_fill(&info);
 | |
|   ok(s == 0, "fill" INFO_TAIL);
 | |
| 
 | |
|   res= reinit_io_cache(&info, WRITE_CACHE, saved_pos, 0, 0);
 | |
|   ok(res == 0, "reinit WRITE_CACHE" INFO_TAIL);
 | |
| 
 | |
|   res= reinit_io_cache(&info, READ_CACHE, 0, 0, 0);
 | |
|   ok(res == 0, "reinit READ_CACHE" INFO_TAIL);
 | |
| 
 | |
|   ok(200 == my_b_bytes_in_cache(&info),"my_b_bytes_in_cache == 200");
 | |
| 
 | |
|   s= my_b_fill(&info);
 | |
|   ok(s == 0, "fill" INFO_TAIL);
 | |
| 
 | |
|   s= my_b_fill(&info);
 | |
|   ok(s == 0, "fill" INFO_TAIL);
 | |
| 
 | |
|   s= my_b_fill(&info);
 | |
|   ok(s == 0, "fill" INFO_TAIL);
 | |
| 
 | |
|   res= reinit_io_cache(&info, WRITE_CACHE, saved_pos, 0, 0);
 | |
|   ok(res == 0, "reinit WRITE_CACHE" INFO_TAIL);
 | |
| 
 | |
|   res= reinit_io_cache(&info, READ_CACHE, 0, 0, 0);
 | |
|   ok(res == 0, "reinit READ_CACHE" INFO_TAIL);
 | |
| 
 | |
|   ok(200 == my_b_bytes_in_cache(&info),"my_b_bytes_in_cache == 200");
 | |
| 
 | |
|   res= my_b_read(&info, buf, sizeof(buf)) || data_bad(buf, sizeof(buf));
 | |
|   ok(res == 0 && info.pos_in_file == 0, "large read" INFO_TAIL);
 | |
| 
 | |
|   close_cached_file(&info);
 | |
| 
 | |
| }
 | |
| 
 | |
| void mdev14014()
 | |
| {
 | |
|   int res;
 | |
|   uchar buf_o[200];
 | |
|   uchar buf_i[200];
 | |
|   memset(buf_i,    0, sizeof( buf_i));
 | |
|   memset(buf_o, FILL, sizeof(buf_o));
 | |
| 
 | |
|   diag("MDEV-14014 Dump thread reads past last 'officially' written byte");
 | |
| 
 | |
|   init_io_cache_encryption();
 | |
| 
 | |
|   res= open_cached_file(&info, 0, 0, CACHE_SIZE, 0);
 | |
|   ok(res == 0, "open_cached_file" INFO_TAIL);
 | |
| 
 | |
|   res= my_b_write(&info, buf_o, sizeof(buf_o));
 | |
|   ok(res == 0, "buffer is written" INFO_TAIL);
 | |
| 
 | |
|   res= my_b_flush_io_cache(&info, 1);
 | |
|   ok(res == 0, "flush" INFO_TAIL);
 | |
| 
 | |
|   res= reinit_io_cache(&info, READ_CACHE, 0, 0, 0);
 | |
|   ok(res == 0, "reinit READ_CACHE" INFO_TAIL);
 | |
| 
 | |
|   info.end_of_file= 100;
 | |
|   res= my_b_read(&info, buf_i, sizeof(buf_i));
 | |
|   ok(res == 1 && buf_i[100] == 0 && buf_i[200-1] == 0,
 | |
|      "short read leaves buf_i[100..200-1] == 0");
 | |
| 
 | |
|   close_cached_file(&info);
 | |
| }
 | |
| 
 | |
| void mdev17133()
 | |
| {
 | |
|   my_off_t res;
 | |
|   int k;
 | |
|   const int eof_iter=4, read_iter= 4;
 | |
|   uchar buf_i[1024*256];      // read
 | |
|   uchar buf_o[sizeof(buf_i)]; // write
 | |
|   const size_t eof_block_size= sizeof(buf_o) / eof_iter;
 | |
|   const size_t read_size= eof_block_size / read_iter;
 | |
|   size_t total;
 | |
| 
 | |
|   srand((uint) time(NULL));
 | |
|   memset(buf_i,    0, sizeof( buf_i));
 | |
|   memset(buf_o, FILL, sizeof(buf_o));
 | |
| 
 | |
|   diag("MDEV-17133 Dump thread reads from the past");
 | |
| 
 | |
|   init_io_cache_encryption();
 | |
| 
 | |
|   res= open_cached_file(&info, 0, 0, CACHE_SIZE, 0);
 | |
|   ok(res == 0, "open_cached_file" INFO_TAIL);
 | |
| 
 | |
|   res= my_b_write(&info, buf_o, sizeof(buf_o));
 | |
|   ok(res == 0, "buffer is written" INFO_TAIL);
 | |
|   res= my_b_tell(&info);
 | |
|   ok(res == sizeof(buf_o), "cache size as expected");
 | |
| 
 | |
|   res= my_b_flush_io_cache(&info, 1);
 | |
|   ok(res == 0, "flush" INFO_TAIL);
 | |
|   res= reinit_io_cache(&info, READ_CACHE, 0, 0, 0);
 | |
|   ok(res == 0, "reinit READ_CACHE" INFO_TAIL);
 | |
| 
 | |
|   // read the written data by chunks of variable size eof_iter times
 | |
|   for (k= eof_iter, info.end_of_file=0, total= 0; k; k--)
 | |
|   {
 | |
|     int i;
 | |
|     size_t curr_read_size;
 | |
|     info.end_of_file=
 | |
|       k == 1 ? sizeof(buf_o) :
 | |
|       MY_MIN(sizeof(buf_o),
 | |
|              info.end_of_file + eof_block_size +
 | |
|              // plus 25% of block for randomization to the average
 | |
|              eof_block_size/4 - rand() % (eof_block_size/2));
 | |
| 
 | |
|     // read a chunk by blocks of variable size read_iter times
 | |
|     // the last block completes the current chunk
 | |
|     for (i= 0; i < read_iter; i++, total += curr_read_size)
 | |
|     {
 | |
|       char buf_check[eof_block_size];
 | |
|       size_t a,b;
 | |
| 
 | |
|       a= (size_t)(info.end_of_file - total);
 | |
|       b= read_size + read_size/4 - rand() % (read_size/2);
 | |
|       curr_read_size= (i == read_iter - 1) ? a :
 | |
|         MY_MIN(a, b);
 | |
| 
 | |
|       DBUG_ASSERT(curr_read_size <= info.end_of_file - total);
 | |
| 
 | |
|       res= my_b_read(&info, buf_i + total, MY_MIN(19, curr_read_size));
 | |
|       ok(res == 0, "read of 19");
 | |
|       // mark read bytes in the used part of the cache buffer
 | |
|       memset(info.buffer, 0, info.read_pos - info.buffer);
 | |
| 
 | |
|       // random size 2nd read
 | |
|       res= my_b_read(&info, buf_i + total + MY_MIN(19, curr_read_size),
 | |
|                      19 >= curr_read_size ? 0 : curr_read_size - 19);
 | |
|       ok(res == 0, "rest of read %zu", curr_read_size - 19);
 | |
|       // mark read bytes in the used part of the cache buffer
 | |
|       memset(info.buffer, 0, info.read_pos - info.buffer);
 | |
| 
 | |
|       // check that no marked bytes are read
 | |
|       memset(buf_check, FILL, curr_read_size);
 | |
|       ok(memcmp(buf_i + total, buf_check, curr_read_size) == 0,
 | |
|          "read correct data");
 | |
|     }
 | |
|     ok(info.pos_in_file + (info.read_end - info.buffer) == info.end_of_file,
 | |
|        "cache is read up to eof");
 | |
|     ok(total == info.end_of_file, "total matches eof");
 | |
|   }
 | |
|   ok(total == sizeof(buf_i), "read total size match");
 | |
|   ok(buf_i[sizeof(buf_i) - 1] == FILL, "data read correctly");
 | |
| 
 | |
|   close_cached_file(&info);
 | |
| }
 | |
| 
 | |
| 
 | |
| void mdev10963()
 | |
| {
 | |
|   int res;
 | |
|   uint n_checks= 8;
 | |
|   uchar buf[1024 * 512];
 | |
|   uint n_frag= sizeof(buf)/(2 * CACHE_SIZE);
 | |
|   FILE *file;
 | |
|   myf my_flags= MYF(MY_WME);
 | |
|   const char *file_name="cache.log";
 | |
| 
 | |
|   memset(buf, FILL, sizeof(buf));
 | |
|   diag("MDEV-10963 Fragmented BINLOG query");
 | |
| 
 | |
|   init_io_cache_encryption();
 | |
|   srand((uint) time(NULL));
 | |
| 
 | |
|   /* copying source */
 | |
|   res= open_cached_file(&info, 0, 0, CACHE_SIZE, 0);
 | |
|   ok(res == 0, "open_cached_file" INFO_TAIL);
 | |
|   res= my_b_write(&info, buf, sizeof(buf));
 | |
| 
 | |
|   ulonglong total_size= my_b_tell(&info);
 | |
|   ok(res == 0 && total_size == sizeof(buf), "cache is written");
 | |
| 
 | |
|   /* destination */
 | |
|   file= my_fopen(file_name, O_RDWR | O_TRUNC | O_CREAT, my_flags);
 | |
|   ok(my_fileno(file) > 0, "opened file fd = %d", my_fileno(file));
 | |
| 
 | |
|   /*
 | |
|     For n_checks times verify a sequence of copying with random fragment
 | |
|     size ranging from zero to about the double of the cache read buffer size.
 | |
|   */
 | |
|   for (; n_checks; n_checks--, rewind(file))
 | |
|   {
 | |
|     // copied size is an estimate can be incremeneted to greater than total_size
 | |
|     ulong copied_size= 0;
 | |
| 
 | |
|     res= reinit_io_cache(&info, READ_CACHE, 0L, FALSE, FALSE);
 | |
|     ok(res == 0, "cache turned to read");
 | |
| 
 | |
|     for (ulong i= 0, curr_size= 0; i < n_frag; i++, copied_size += curr_size)
 | |
|     {
 | |
|       curr_size= rand() % (2 * (total_size - copied_size) / (n_frag - i));
 | |
| 
 | |
|       DBUG_ASSERT(curr_size <= total_size - copied_size || i == n_frag - 1);
 | |
| 
 | |
|       res= my_b_copy_to_file(&info, file, curr_size);
 | |
|       ok(res == 0, "%lu of the cache copied to file", curr_size);
 | |
|     }
 | |
|     /*
 | |
|       Regardless of total_size <> copied_size the function succeeds:
 | |
|       when total_size < copied_size the huge overflowed value of the last
 | |
|       argument is ignored because nothing already left uncopied in the cache.
 | |
|     */
 | |
|     res= my_b_copy_to_file(&info, file, (size_t) total_size - copied_size);
 | |
|     ok(res == 0, "%llu of the cache copied to file", total_size - copied_size);
 | |
|     ok(my_ftell(file, my_flags) == sizeof(buf),
 | |
|        "file written in %d fragments", n_frag+1);
 | |
| 
 | |
|     res= reinit_io_cache(&info, WRITE_CACHE, total_size, 0, 0);
 | |
|     ok(res == 0 && my_b_tell(&info) == sizeof(buf), "cache turned to write");
 | |
|   }
 | |
|   close_cached_file(&info);
 | |
|   my_fclose(file, my_flags);
 | |
|   my_delete(file_name, MYF(MY_WME));
 | |
| }
 | |
| 
 | |
| int main(int argc __attribute__((unused)),char *argv[])
 | |
| {
 | |
|   MY_INIT(argv[0]);
 | |
|   plan(277);
 | |
| 
 | |
|   /* temp files with and without encryption */
 | |
|   encrypt_tmp_files= 1;
 | |
|   temp_io_cache();
 | |
| 
 | |
|   encrypt_tmp_files= 0;
 | |
|   temp_io_cache();
 | |
| 
 | |
|   /* regression tests */
 | |
|   mdev9044();
 | |
| 
 | |
|   encrypt_tmp_files= 1;
 | |
|   mdev10259();
 | |
|   encrypt_tmp_files= 0;
 | |
| 
 | |
|   mdev14014();
 | |
|   mdev17133();
 | |
|   mdev10963();
 | |
| 
 | |
|   my_end(0);
 | |
|   return exit_status();
 | |
| }
 | |
| 
 | |
| PRAGMA_REENABLE_CHECK_STACK_FRAME
 |