mirror of
				https://github.com/MariaDB/server.git
				synced 2025-11-04 12:56:14 +01:00 
			
		
		
		
	it's incorrect to zero out table->triggers->extra_null_bitmap before a statement, because if insert uses an explicit field list and omits a field that has no default value, the field should get NULL implicitly. So extra_null_bitmap should have 1s for all fields that have no defaults * create extra_null_bitmap_init and initialize it as above * copy extra_null_bitmap_init to extra_null_bitmap for inserts * still zero out extra_null_bitmap for updates/deletes where all fields definitely have a value * make not_null_fields_have_null_values() to send ER_NO_DEFAULT_FOR_FIELD for fields with no default and no value, otherwise creation of a trigger with an empty body would change the error message
		
			
				
	
	
		
			42 lines
		
	
	
	
		
			1 KiB
		
	
	
	
		
			Text
		
	
	
	
	
	
			
		
		
	
	
			42 lines
		
	
	
	
		
			1 KiB
		
	
	
	
		
			Text
		
	
	
	
	
	
#
 | 
						|
# MDEV-11698 Old Bug possibly not fixed; BEFORE INSERT Trigger on NOT NULL
 | 
						|
#
 | 
						|
set sql_mode='strict_all_tables';
 | 
						|
create table t1 (a int not null, b int);
 | 
						|
--error ER_NO_DEFAULT_FOR_FIELD
 | 
						|
insert t1 (b) values (1);
 | 
						|
delimiter |;
 | 
						|
create trigger trgi before insert on t1 for each row
 | 
						|
  case new.b
 | 
						|
  when 10 then
 | 
						|
    set new.a = new.b;
 | 
						|
  when 30 then
 | 
						|
    set new.a = new.a;
 | 
						|
  else
 | 
						|
    do 1;
 | 
						|
  end case|
 | 
						|
delimiter ;|
 | 
						|
insert t1 (b) values (10);
 | 
						|
--error ER_NO_DEFAULT_FOR_FIELD
 | 
						|
insert t1 (b) values (20);
 | 
						|
--error ER_BAD_NULL_ERROR
 | 
						|
insert t1 (b) values (30);
 | 
						|
select * from t1;
 | 
						|
drop table t1;
 | 
						|
set sql_mode=default;
 | 
						|
 | 
						|
#
 | 
						|
# MDEV-11842 Fail to insert on a table where a field has no default
 | 
						|
#
 | 
						|
set sql_mode='';
 | 
						|
create table t1 (
 | 
						|
  id int(11) not null auto_increment primary key,
 | 
						|
  data1 varchar(10) not null,
 | 
						|
  data2 varchar(10) not null
 | 
						|
);
 | 
						|
insert into t1 (data2) values ('x');
 | 
						|
create trigger test_trigger before insert on t1 for each row begin end;
 | 
						|
insert into t1 (data2) values ('y');
 | 
						|
select * from t1;
 | 
						|
drop table t1;
 | 
						|
set sql_mode=default;
 |