mirror of
https://github.com/MariaDB/server.git
synced 2025-02-05 13:22:17 +01:00
9808ebe195
Where a read-only server permits writes through replication, it should not permit user connections to commit/rollback XA transactions prepared via replication. The bug reported in MDEV-30978 shows that this can happen. This is because there is no read only check in the XA transaction logic, the most relevant one occurs in ha_commit_trans() for normal statements/transactions. This patch extends the XA transaction logic to check the read only status of the server before performing an XA COMMIT or ROLLBACK. Reviewed By: Andrei Elkin <andrei.elkin@mariadb.com>
168 lines
3.6 KiB
Text
168 lines
3.6 KiB
Text
include/master-slave.inc
|
|
[connection master]
|
|
call mtr.add_suppression("Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT");
|
|
connection master;
|
|
create user test;
|
|
connection slave;
|
|
connect master2,127.0.0.1,test,,test,$MASTER_MYPORT,;
|
|
connect slave2,127.0.0.1,test,,test,$SLAVE_MYPORT,;
|
|
connection master1;
|
|
create table t1(a int) engine=InnoDB;
|
|
create table t2(a int) engine=MyISAM;
|
|
insert into t1 values(1001);
|
|
insert into t2 values(2001);
|
|
connection master;
|
|
set global read_only=1;
|
|
connection master1;
|
|
select @@read_only;
|
|
@@read_only
|
|
1
|
|
select * from t1;
|
|
a
|
|
1001
|
|
select * from t2;
|
|
a
|
|
2001
|
|
connection slave;
|
|
select @@read_only;
|
|
@@read_only
|
|
0
|
|
select * from t1;
|
|
a
|
|
1001
|
|
select * from t2;
|
|
a
|
|
2001
|
|
connection master;
|
|
set global read_only=0;
|
|
connection master1;
|
|
BEGIN;
|
|
connection master2;
|
|
BEGIN;
|
|
connection master;
|
|
select @@read_only;
|
|
@@read_only
|
|
0
|
|
set global read_only=1;
|
|
connection master1;
|
|
*** On SUPER USER connection ***
|
|
insert into t1 values(1002);
|
|
insert into t2 values(2002);
|
|
connection master2;
|
|
*** On regular USER connection ***
|
|
insert into t1 values(1003);
|
|
ERROR HY000: The MariaDB server is running with the --read-only option so it cannot execute this statement
|
|
insert into t2 values(2003);
|
|
ERROR HY000: The MariaDB server is running with the --read-only option so it cannot execute this statement
|
|
connection master1;
|
|
*** SUPER USER COMMIT (must succeed) ***
|
|
COMMIT;
|
|
connection master2;
|
|
*** regular USER COMMIT (must succeed - nothing to commit) ***
|
|
COMMIT;
|
|
connection master;
|
|
select @@read_only;
|
|
@@read_only
|
|
1
|
|
set global read_only=0;
|
|
connection master1;
|
|
insert into t1 values(1004);
|
|
insert into t2 values(2004);
|
|
select * from t1;
|
|
a
|
|
1001
|
|
1002
|
|
1004
|
|
select * from t2;
|
|
a
|
|
2001
|
|
2002
|
|
2004
|
|
connection slave;
|
|
select * from t1;
|
|
a
|
|
1001
|
|
1002
|
|
1004
|
|
select * from t2;
|
|
a
|
|
2001
|
|
2002
|
|
2004
|
|
connection slave1;
|
|
set global read_only=1;
|
|
connection slave;
|
|
select @@read_only;
|
|
@@read_only
|
|
1
|
|
show create table t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`a` int(11) DEFAULT NULL
|
|
) ENGINE=InnoDB DEFAULT CHARSET=latin1 COLLATE=latin1_swedish_ci
|
|
show create table t2;
|
|
Table Create Table
|
|
t2 CREATE TABLE `t2` (
|
|
`a` int(11) DEFAULT NULL
|
|
) ENGINE=MyISAM DEFAULT CHARSET=latin1 COLLATE=latin1_swedish_ci
|
|
connection master;
|
|
insert into t1 values(1005);
|
|
insert into t2 values(2005);
|
|
select * from t1;
|
|
a
|
|
1001
|
|
1002
|
|
1004
|
|
1005
|
|
select * from t2;
|
|
a
|
|
2001
|
|
2002
|
|
2004
|
|
2005
|
|
connection slave;
|
|
connection slave;
|
|
select * from t1;
|
|
a
|
|
1001
|
|
1002
|
|
1004
|
|
1005
|
|
select * from t2;
|
|
a
|
|
2001
|
|
2002
|
|
2004
|
|
2005
|
|
connection slave2;
|
|
insert into t1 values(1006);
|
|
ERROR HY000: The MariaDB server is running with the --read-only option so it cannot execute this statement
|
|
insert into t2 values(2006);
|
|
ERROR HY000: The MariaDB server is running with the --read-only option so it cannot execute this statement
|
|
#
|
|
# MDEV-30978: On slave XA COMMIT/XA ROLLBACK fail to return an error in read-only mode
|
|
#
|
|
# Where a read-only server permits writes through replication, it
|
|
# should not permit user connections to commit/rollback XA transactions
|
|
# prepared via replication. This test ensure this behavior is prohibited
|
|
#
|
|
connection master;
|
|
xa start '1';
|
|
insert into t1 values (1007);
|
|
xa end '1';
|
|
xa prepare '1';
|
|
connection slave;
|
|
connection slave2;
|
|
xa commit '1';
|
|
ERROR HY000: The MariaDB server is running with the --read-only option so it cannot execute this statement
|
|
xa rollback '1';
|
|
ERROR HY000: The MariaDB server is running with the --read-only option so it cannot execute this statement
|
|
connection master;
|
|
xa rollback '1';
|
|
connection master;
|
|
drop user test;
|
|
drop table t1;
|
|
drop table t2;
|
|
connection slave;
|
|
set global read_only=0;
|
|
include/rpl_end.inc
|