mirror of
https://github.com/MariaDB/server.git
synced 2025-02-05 13:22:17 +01:00
ddd7d5d8e3
Under unknown circumstances, the SQL layer may wrongly disregard an invocation of thd_mark_transaction_to_rollback() when an InnoDB transaction had been aborted (rolled back) due to one of the following errors: * HA_ERR_LOCK_DEADLOCK * HA_ERR_RECORD_CHANGED (if innodb_snapshot_isolation=ON) * HA_ERR_LOCK_WAIT_TIMEOUT (if innodb_rollback_on_timeout=ON) Such an error used to cause a crash of InnoDB during transaction commit. These changes aim to catch and report the error earlier, so that not only this crash can be avoided but also the original root cause be found and fixed more easily later. The idea of this fix is from Michael 'Monty' Widenius. HA_ERR_ROLLBACK: A new error code that will be translated into ER_ROLLBACK_ONLY, signalling that the current transaction has been aborted and the only allowed action is ROLLBACK. trx_t::state: Add TRX_STATE_ABORTED that is like TRX_STATE_NOT_STARTED, but noting that the transaction had been rolled back and aborted. trx_t::is_started(): Replaces trx_is_started(). ha_innobase: Check the transaction state in various places. Simplify the logic around SAVEPOINT. ha_innobase::is_valid_trx(): Replaces ha_innobase::is_read_only(). The InnoDB logic around transaction savepoints, commit, and rollback was unnecessarily complex and might have contributed to this inconsistency. So, we are simplifying that logic as well. trx_savept_t: Replace with const undo_no_t*. When we rollback to a savepoint, all we need to know is the number of undo log records that must survive. trx_named_savept_t, DB_NO_SAVEPOINT: Remove. We can store undo_no_t directly in the space allocated at innobase_hton->savepoint_offset. fts_trx_create(): Do not copy previous savepoints. fts_savepoint_rollback(): If a savepoint was not found, roll back everything after the default savepoint of fts_trx_create(). The test innodb_fts.savepoint is extended to cover this code. Reviewed by: Vladislav Lesin Tested by: Matthias Leich
84 lines
2.4 KiB
Text
84 lines
2.4 KiB
Text
--source include/have_innodb.inc
|
|
#
|
|
# Testcase for InnoDB
|
|
# Bug#42419 Server crash with "Pure virtual method called" on two concurrent connections
|
|
#
|
|
|
|
--disable_query_log
|
|
call mtr.add_suppression("InnoDB: Transaction was aborted due to ");
|
|
--enable_query_log
|
|
|
|
--source include/not_embedded.inc
|
|
|
|
let $innodb_lock_wait_timeout= query_get_value(SHOW VARIABLES LIKE 'innodb_lock_wait_timeout%', Value, 1);
|
|
if ($innodb_lock_wait_timeout < 10)
|
|
{
|
|
--echo # innodb_lock_wait_timeout must be >= 10 seconds
|
|
--echo # so that this test can work all time fine on an overloaded testing box
|
|
SHOW VARIABLES LIKE 'innodb_lock_wait_timeout';
|
|
exit;
|
|
}
|
|
|
|
# Save the initial number of concurrent sessions
|
|
--source include/count_sessions.inc
|
|
|
|
# First session
|
|
connection default;
|
|
|
|
|
|
--enable_warnings
|
|
CREATE TABLE t1 (a INT AUTO_INCREMENT PRIMARY KEY, b INT) ENGINE = InnoDB;
|
|
|
|
INSERT INTO t1 VALUES (1,1),(2,2),(3,3);
|
|
COMMIT;
|
|
SET AUTOCOMMIT = 0;
|
|
|
|
CREATE TEMPORARY TABLE t1_tmp ( b INT );
|
|
|
|
INSERT INTO t1_tmp (b) SELECT b FROM t1 WHERE a = 3;
|
|
INSERT INTO t1_tmp (b) SELECT b FROM t1 WHERE a = 2;
|
|
|
|
# Second session
|
|
connect (user2,localhost,root,,,$MASTER_MYPORT,$MASTER_MYSOCK);
|
|
|
|
SET AUTOCOMMIT = 0;
|
|
|
|
CREATE TEMPORARY TABLE t2_tmp ( a int, new_a int );
|
|
INSERT INTO t2_tmp VALUES (1,51),(2,52),(3,53);
|
|
|
|
UPDATE t1 SET a = (SELECT new_a FROM t2_tmp WHERE t2_tmp.a = t1.a) WHERE a = 1;
|
|
send
|
|
UPDATE t1 SET a = (SELECT new_a FROM t2_tmp WHERE t2_tmp.a = t1.a) WHERE a = 2;
|
|
|
|
# The last update will wait for a lock held by the first session
|
|
|
|
# First session
|
|
connection default;
|
|
|
|
# Poll till the UPDATE of the second session waits for lock
|
|
let $show_statement= SHOW PROCESSLIST;
|
|
let $field= State;
|
|
let $condition= = 'Updating';
|
|
--source include/wait_show_condition.inc
|
|
|
|
# If the testing box is overloadeded and innodb_lock_wait_timeout is too small
|
|
# we might get here ER_LOCK_WAIT_TIMEOUT.
|
|
--error ER_LOCK_DEADLOCK
|
|
INSERT INTO t1_tmp (b) SELECT b FROM t1 WHERE a = 1;
|
|
|
|
# Second session
|
|
connection user2;
|
|
--echo Reap the server message for connection user2 UPDATE t1 ...
|
|
reap;
|
|
|
|
# The server crashed when executing this UPDATE or the succeeding SQL command.
|
|
UPDATE t1 SET a = (SELECT new_a FROM t2_tmp WHERE t2_tmp.a = t1.a) WHERE a = 3;
|
|
|
|
connection default;
|
|
disconnect user2;
|
|
DROP TABLE t1;
|
|
|
|
# Wait till all disconnects are completed
|
|
--source include/wait_until_count_sessions.inc
|
|
|
|
call mtr.add_suppression("Deadlock found when trying to get lock; try restarting transaction");
|