mirror of
https://github.com/MariaDB/server.git
synced 2025-07-08 04:18:14 +02:00

MDEV-21810 MBR: Unexpected "Unsafe statement" warning for unsafe IODKU
MDEV-17614 fixes to replication unsafety for INSERT ON DUP KEY UPDATE
on two or more unique key table left a flaw. The fixes checked the
safety condition per each inserted record with the idea to catch a user-created
value to an autoincrement column and when that succeeds the autoincrement column
would become the source of unsafety too.
It was not expected that after a duplicate error the next record's
write_set may become different and the unsafe decision for that
specific record will be computed to screw the Query's binlogging
state and when @@binlog_format is MIXED nothing gets bin-logged.
This case has been already fixed in 10.5.2 by 91ab42a823
that
relocated/optimized THD::decide_logging_format_low() out of the record insert
loop. The safety decision is computed once and at the right time.
Pertinent parts of the commit are cherry-picked.
Also a spurious warning about unsafety is removed when MIXED
@@binlog_format; original MDEV-17614 test result corrected.
The original test of MDEV-17614 is extended and made more readable.
61 lines
1.8 KiB
Text
61 lines
1.8 KiB
Text
include/master-slave.inc
|
|
[connection master]
|
|
CREATE TABLE t1(id INT AUTO_INCREMENT, i INT, PRIMARY KEY (id)) ENGINE=INNODB;
|
|
CREATE TABLE t2(id INT AUTO_INCREMENT, i INT, PRIMARY KEY (id)) ENGINE=INNODB;
|
|
CREATE TRIGGER trig1 AFTER INSERT ON t1
|
|
FOR EACH ROW
|
|
INSERT INTO t2(i) VALUES(new.i);
|
|
START TRANSACTION;
|
|
INSERT INTO t2(i) VALUES (1);
|
|
ROLLBACK;
|
|
INSERT INTO t1(i) VALUES(2);
|
|
START TRANSACTION;
|
|
LOCK TABLES t1 WRITE, t2 WRITE;
|
|
INSERT INTO t1(i) VALUES(3);
|
|
UNLOCK TABLES;
|
|
COMMIT;
|
|
connection slave;
|
|
include/diff_tables.inc [master:t1, slave:t1]
|
|
include/diff_tables.inc [master:t2, slave:t2]
|
|
connection master;
|
|
DROP TABLE t1,t2;
|
|
CREATE TABLE t1(i INT) ENGINE=INNODB;
|
|
CREATE TABLE t2(id INT AUTO_INCREMENT, i INT, PRIMARY KEY (id)) ENGINE=INNODB;
|
|
INSERT INTO t1 values (1), (2), (3);
|
|
START TRANSACTION;
|
|
INSERT INTO t2(i) VALUES (1);
|
|
ROLLBACK;
|
|
INSERT INTO t2(i) SELECT i FROM t1;
|
|
START TRANSACTION;
|
|
LOCK TABLES t2 WRITE, t1 READ;
|
|
INSERT INTO t2(i) SELECT i FROM t1;
|
|
UNLOCK TABLES;
|
|
COMMIT;
|
|
connection slave;
|
|
include/diff_tables.inc [master:t1, slave:t1]
|
|
include/diff_tables.inc [master:t2, slave:t2]
|
|
connection master;
|
|
DROP TABLE t1,t2;
|
|
CREATE TABLE t1(i int, id INT AUTO_INCREMENT, PRIMARY KEY (i, id)) ENGINE=MYISAM;
|
|
INSERT INTO t1 (i) values (1);
|
|
START TRANSACTION;
|
|
LOCK TABLES t1 WRITE;
|
|
INSERT INTO t1 (i) values (2);
|
|
UNLOCK TABLES;
|
|
COMMIT;
|
|
connection slave;
|
|
include/diff_tables.inc [master:t1, slave:t1]
|
|
connection master;
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1(i INT, j INT, UNIQUE KEY(i), UNIQUE KEY(j)) ENGINE=INNODB;
|
|
INSERT INTO t1 (i,j) VALUES (1,2) ON DUPLICATE KEY UPDATE j=j+1;
|
|
START TRANSACTION;
|
|
LOCK TABLES t1 WRITE;
|
|
INSERT INTO t1 (i,j) VALUES (1,2) ON DUPLICATE KEY UPDATE j=j+1;
|
|
UNLOCK TABLES;
|
|
COMMIT;
|
|
connection slave;
|
|
include/diff_tables.inc [master:t1, slave:t1]
|
|
connection master;
|
|
DROP TABLE t1;
|
|
include/rpl_end.inc
|