mirror of
https://github.com/MariaDB/server.git
synced 2025-04-21 14:45:34 +02:00
a5dc12eefd
MDEV-21810 MBR: Unexpected "Unsafe statement" warning for unsafe IODKU
MDEV-17614 fixes to replication unsafety for INSERT ON DUP KEY UPDATE
on two or more unique key table left a flaw. The fixes checked the
safety condition per each inserted record with the idea to catch a user-created
value to an autoincrement column and when that succeeds the autoincrement column
would become the source of unsafety too.
It was not expected that after a duplicate error the next record's
write_set may become different and the unsafe decision for that
specific record will be computed to screw the Query's binlogging
state and when @@binlog_format is MIXED nothing gets bin-logged.
This case has been already fixed in 10.5.2 by 91ab42a823 that
relocated/optimized THD::decide_logging_format_low() out of the record insert
loop. The safety decision is computed once and at the right time.
Pertinent parts of the commit are cherry-picked.
Also a spurious warning about unsafety is removed when MIXED
@@binlog_format; original MDEV-17614 test result corrected.
The original test of MDEV-17614 is extended and made more readable.
27 lines
1.5 KiB
Text
27 lines
1.5 KiB
Text
--- r/rpl_iodku.result 2022-05-04 18:51:24.956414404 +0300
|
|
+++ r/rpl_iodku,stmt.reject 2022-05-04 18:51:49.520106231 +0300
|
|
@@ -1,10 +1,15 @@
|
|
include/master-slave.inc
|
|
[connection master]
|
|
+call mtr.add_suppression("Unsafe statement written to the binary log using statement");
|
|
CREATE TABLE t1 (id INT PRIMARY KEY AUTO_INCREMENT, a INT, b INT, c INT,
|
|
UNIQUE (a), UNIQUE (b)) ENGINE=innodb;
|
|
INSERT INTO t1 (`a`,`c`) VALUES (1,1), (2,1) ON DUPLICATE KEY UPDATE c = 1;
|
|
+Warnings:
|
|
+Note 1592 Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT. INSERT... ON DUPLICATE KEY UPDATE on a table with more than one UNIQUE KEY is unsafe
|
|
# UNSAFE
|
|
INSERT INTO t1 (`a`,`c`) VALUES (3, 1),(2,1), (1,1) ON DUPLICATE KEY UPDATE c = a * 10 + VALUES(c);
|
|
+Warnings:
|
|
+Note 1592 Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT. INSERT... ON DUPLICATE KEY UPDATE on a table with more than one UNIQUE KEY is unsafe
|
|
SELECT * from t1;
|
|
id a b c
|
|
1 1 NULL 11
|
|
@@ -17,6 +22,8 @@
|
|
INSERT INTO t1 VALUES (1,10,1);
|
|
# eligable for the statement format run unsafe warning
|
|
INSERT INTO t1 VALUES (2,20,2) ON DUPLICATE KEY UPDATE c = 100;
|
|
+Warnings:
|
|
+Note 1592 Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT. INSERT... ON DUPLICATE KEY UPDATE on a table with more than one UNIQUE KEY is unsafe
|
|
# not eligable: no warning in the statement format run
|
|
INSERT INTO t1 (`a`,`c`) VALUES (3, 1) ON DUPLICATE KEY UPDATE c = 99;
|
|
SELECT * from t1;
|