consider clustered primary keys
Choosing a shortest index for the covering index scan,
the optimizer ignored the fact, that the clustered primary
key read involves whole table data.
The find_shortest_key function has been modified to
take into account that fact that a clustered PK has a
longest key of possible covering indices.
Before this fix, mysql_upgrade would always drop and re create
the performance_schema database.
This in theory could destroy user data created using 5.1 or older versions.
With this fix, mysql_upgrade checks the content of the
performance_schema database before droping it.
The unit test pfs_instr-t:
- generates a very long (10,000) bytes file name
- calls find_or_create_file.
This leads to a buffer overflow in mysys in my_realpath(),
because my_realpath and mysys file APIs in general do not
test for input parameters: mysys assumes every file name
is less that FN_REFLEN in length.
Calling find_or_create_file with a very long file name is likely
to happen when instrumenting third party code that does not use mysys,
so this test is legitimate.
The fix is to make find_or_create_file in the performance schema
more robust in this case.
The root cause of the failure is that when
Bug#51447 performance schema evil twin files
was fixed, instrumented file names got normalized.
The pfs-t unit test depends on this file normalization,
but it was not updated.
This fix aligns pfs-t.cc lookup_file_by_name()
with the logic in pfs_instr.cc find_or_create_file().
auto_increment on duplicate entry
The bug was that when INSERT_ID was used and the storage
engine was told to release any reserved but not used
auto_increment values, it set the highest auto_increment
value to INSERT_ID.
The fix was to check if the auto_increment value was forced
by user (INSERT_ID) or by slave-thread, i.e. not auto-
generated. So that it is only allowed to release generated
values.
Spatial indexes were not checking for out-of-record condition in
the handler next command when the previous command didn't found
rows.
Fixed by making the rtree index to check for end of rows condition
before re-using the key from the previous search.
Fixed another crash if the tree has changed since the last search.
Added a test case for the other error.
Bug#51676 Server crashes on SELECT, ORDER BY on 'utf8mb4' column
An additional fix. We should use 0xFFFD as a weight for supplementary
characters, not the "weight for character U+FFFD".
Problem was block_size on partitioned tables was not set,
resulting in keys_per_block was not correct which affects
the cost calculation for read time of indexes (including
cost for group min/max).Which resulted in a bad optimizer
decision.
Fixed by setting stats.block_size correctly.
on decimal column
The problem was that there was no check to disallow DECIMAL
columns in the code (it was accepted as if it was INTEGER).
Solution was to correctly disallow DECIMAL columns in
COLUMNS partitioning. As documented.
mode
When the master was executing in sql_mode='traditional' (which
implies that really_abort_on_warning returns TRUE - because of
MODE_STRICT_ALL_TABLES), the error code (ER_DUP_ENTRY in the
reported case) was not being set in the
Query_log_event. Therefore, even if a failure was to be expected
when replaying the statement on the slave, a failure would occur,
because the Query_log_event was not transporting the expected
error code, but 0 instead.
This was because when the master was getting the error code to
set it in the Query_log_event, the executing thread would be
assumed to have been killed:
THD::killed==THD::KILL_BAD_DATA. This would make the error code
fetch routine not to check thd->main_da.sql_errno(), but instead
the thd->killed value. What's more, is that the server would
thd->killed value if thd->killed == THD::KILL_BAD_DATA and return
0 instead. So this is a double inconsistency, as the we should
not even check thd->killed but rather thd->main_da.sql_errno().
We fix this by extending the condition used to choose whether to
check the thd->main_da.sql_errno() or thd->killed, so that it
takes into consideration the case when:
thd->killed==THD::KILL_BAD_DATA.
------------------------------------------------------------------------
r6560 | sunny | 2010-02-04 16:11:23 +0200 (Thu, 04 Feb 2010) | 7 lines
Changed paths:
M /branches/zip/lock/lock0lock.c
branches/zip: Remove the additional check introduced in r6534 which tries
to check if the joining transaction has any other transactions waiting on
its locks. This optimization results in excessive deadlocks when running
Sysbench with a large number of threads. The function seems to return
FALSE positives.
rb://250
------------------------------------------------------------------------
r6591 | marko | 2010-02-08 10:06:39 +0200 (Mon, 08 Feb 2010) | 3 lines
Changed paths:
M /branches/zip/row/row0merge.c
branches/zip: row_merge_drop_index(): Remove redundant condition
on SYS_INDEXES.TABLE_ID. INDEX_ID must be instance-widely unique,
because SYS_FIELDS is not indexed by TABLE_ID.
------------------------------------------------------------------------
r6594 | marko | 2010-02-08 12:55:04 +0200 (Mon, 08 Feb 2010) | 2 lines
Changed paths:
M /branches/zip/rem/rem0rec.c
branches/zip: rec_get_nth_field_offs_old():
Replace if (!cond) ut_error; tests with ut_a(cond).
------------------------------------------------------------------------
r6595 | marko | 2010-02-08 13:53:02 +0200 (Mon, 08 Feb 2010) | 1 line
Changed paths:
M /branches/zip/include/btr0pcur.h
M /branches/zip/include/btr0pcur.ic
branches/zip: btr_pcur_commit(): Unused function, remove.
------------------------------------------------------------------------
r6608 | marko | 2010-02-09 11:02:37 +0200 (Tue, 09 Feb 2010) | 1 line
Changed paths:
M /branches/zip/handler/handler0alter.cc
branches/zip: ha_innobase::add_index(): Check for !innodb_table.
------------------------------------------------------------------------
r6609 | marko | 2010-02-09 13:45:40 +0200 (Tue, 09 Feb 2010) | 1 line
Changed paths:
M /branches/zip/dict/dict0dict.c
branches/zip: dict_field_print_low(): Add const qualifier.
------------------------------------------------------------------------
r6610 | marko | 2010-02-09 13:53:59 +0200 (Tue, 09 Feb 2010) | 17 lines
Changed paths:
M /branches/zip/dict/dict0boot.c
M /branches/zip/include/dict0boot.h
M /branches/zip/row/row0merge.c
M /branches/zip/row/row0mysql.c
branches/zip: When dropping temporary indexes and tables at startup,
first load them to the data dictionary cache and use the normal
routines for dropping tables or indexes. This should reduce the
risk of bugs and also make the code compatible with the upcoming
TablespaceDictionary implementation.
DICT_SYS_INDEXES_NAME_FIELD: The clustered index position of SYS_INDEXES.NAME.
row_merge_drop_temp_indexes(): Scan SYS_INDEXES for tables containing
temporary indexes, and load the tables as needed. Invoke
row_merge_drop_index() to drop the indexes.
row_mysql_drop_temp_tables(): Scan SYS_TABLES for temporary tables,
load them with dict_load_table() and drop them with
row_drop_table_for_mysql().
rb://251, not yet reviewed
------------------------------------------------------------------------
r6611 | marko | 2010-02-09 14:28:25 +0200 (Tue, 09 Feb 2010) | 11 lines
Changed paths:
M /branches/zip/include/log0recv.h
M /branches/zip/log/log0recv.c
M /branches/zip/srv/srv0start.c
branches/zip: Roll back dictionary transaction(s) before scanning *.ibd files
innobase_start_or_create_for_mysql(): Roll back data dictionary
transactions before scanning the *.ibd files. Then, data dictionary
records can be loaded to the cache before opening the *.ibd files.
recv_recovery_rollback_active(): Refactored from
recv_recovery_from_checkpoint_finish().
rb://235, committing without review, because this is needed for
TablespaceDictionary.
------------------------------------------------------------------------
r6612 | marko | 2010-02-09 14:32:39 +0200 (Tue, 09 Feb 2010) | 3 lines
Changed paths:
M /branches/zip/log/log0recv.c
branches/zip: recv_recovery_rollback_active():
Drop the temporary tables and indexes after enabling sync order checks.
This should not make any difference. This could have been done in r6611.
------------------------------------------------------------------------
r6614 | inaam | 2010-02-09 20:26:23 +0200 (Tue, 09 Feb 2010) | 7 lines
Changed paths:
M /branches/zip/srv/srv0srv.c
branches/plugin rb://242
Let the master thread sleep if the amount of work to be done is
calibrated as taking less than a second.
Approved by: Heikki
------------------------------------------------------------------------
r6631 | marko | 2010-02-10 09:19:52 +0200 (Wed, 10 Feb 2010) | 1 line
Changed paths:
M /branches/zip/ChangeLog
branches/zip: Document r6614 in ChangeLog.
------------------------------------------------------------------------
r6633 | marko | 2010-02-10 10:40:55 +0200 (Wed, 10 Feb 2010) | 31 lines
Changed paths:
M /branches/zip/ChangeLog
M /branches/zip/buf/buf0buf.c
M /branches/zip/lock/lock0lock.c
branches/zip: Merge revisions 6538:6613 from branches/5.1:
------------------------------------------------------------------------
r6545 | jyang | 2010-02-03 03:57:32 +0200 (Wed, 03 Feb 2010) | 8 lines
Changed paths:
M /branches/5.1/lock/lock0lock.c
branches/5.1: Fix bug #49001, "SHOW INNODB STATUS deadlock info
incorrect when deadlock detection aborts". Print the correct
lock owner when recursive function lock_deadlock_recursive()
exceeds its maximum depth LOCK_MAX_DEPTH_IN_DEADLOCK_CHECK.
rb://217, approved by Marko.
------------------------------------------------------------------------
r6613 | inaam | 2010-02-09 20:23:09 +0200 (Tue, 09 Feb 2010) | 11 lines
Changed paths:
M /branches/5.1/buf/buf0buf.c
M /branches/5.1/buf/buf0rea.c
M /branches/5.1/include/buf0rea.h
branches/5.1: Fix Bug #38901
InnoDB logs error repeatedly when trying to load page into buffer pool
In buf_page_get_gen() if we are unable to read a page (because of
corruption or some other reason) we keep on retrying. This fills up
error log with millions of entries in no time and we'd eventually run
out of disk space. This patch limits the number of attempts that we
make (currently set to 100) and after that we abort with a message.
rb://241 Approved by: Heikki
------------------------------------------------------------------------
------------------------------------------------------------------------
r6635 | marko | 2010-02-10 11:07:05 +0200 (Wed, 10 Feb 2010) | 4 lines
Changed paths:
M /branches/zip/row/row0sel.c
branches/zip: Clean up after r6559. Now that
btr_pcur_open_with_no_init() is a macro, do not mix preprocessor
directives in the macro invocation, because it is implementation-defined
whether that is going to work.
------------------------------------------------------------------------
r6639 | marko | 2010-02-10 13:11:04 +0200 (Wed, 10 Feb 2010) | 1 line
Changed paths:
M /branches/zip/include/trx0rseg.h
M /branches/zip/trx/trx0rseg.c
branches/zip: trx_rseg_create(): Unused function, remove.
------------------------------------------------------------------------
r6660 | marko | 2010-02-11 11:21:11 +0200 (Thu, 11 Feb 2010) | 7 lines
Changed paths:
M /branches/zip/row/row0umod.c
branches/zip: Clarify the rollback of INSERT by UPDATE of delete-marked rec.
row_undo_mod_remove_clust_low(): Augment the function comment.
row_undo_mod_remove_clust_low(), row_undo_mod_del_mark_or_remove_sec_low(),
row_undo_mod_del_mark_or_remove_sec(), row_undo_mod_upd_del_sec():
Add ut_ad(node->rec_type == TRX_UNDO_UPD_DEL_REC);
------------------------------------------------------------------------
r6672 | marko | 2010-02-11 13:01:18 +0200 (Thu, 11 Feb 2010) | 1 line
Changed paths:
M /branches/zip/include/que0que.h
M /branches/zip/include/que0que.ic
M /branches/zip/row/row0umod.c
branches/zip: Introduce thr_is_recv().
------------------------------------------------------------------------
r6673 | marko | 2010-02-11 13:09:48 +0200 (Thu, 11 Feb 2010) | 9 lines
Changed paths:
M /branches/zip/btr/btr0cur.c
M /branches/zip/include/trx0types.h
M /branches/zip/row/row0umod.c
branches/zip: Relax a debug assertion about a missing BLOB. (Issue #452)
When rolling back an incomplete transaction in purge, tolerate missing
BLOBs also in update undo, when undoing an INSERT by updating a delete-marked
record, and the delete-marked record is no longer needed.
Previously, we only tolerated missing BLOBs in insert undo.
This merely fixes a debug assertion; the code performed correctly
without UNIV_DEBUG.
rb://249 approved by Sunny Bains.
------------------------------------------------------------------------
r6674 | inaam | 2010-02-11 17:54:44 +0200 (Thu, 11 Feb 2010) | 16 lines
Changed paths:
M /branches/zip/include/mem0mem.h
M /branches/zip/include/mem0mem.ic
M /branches/zip/mem/mem0mem.c
branches/zip bug# 49535
This is a backport of r4924.
mem_heap_get_size() scans all allocated blocks to calculate the total
size of the heap. This patch introduces a new, total_size, field in
mem_block_info_struct. This field is valid only for base block
(i.e.: the first block allocated for the heap) and is set to
ULINT_UNDEFINED in other blocks.
This considerably improves the performance of redo scan during recovery.
rb://108 issue#216
Approved by: Heikki
------------------------------------------------------------------------
r6675 | marko | 2010-02-11 22:41:11 +0200 (Thu, 11 Feb 2010) | 1 line
Changed paths:
M /branches/zip/row/row0umod.c
branches/zip: Remove bogus debug assertions introduced in r6660.
------------------------------------------------------------------------
r6707 | inaam | 2010-02-12 19:22:35 +0200 (Fri, 12 Feb 2010) | 4 lines
Changed paths:
M /branches/zip/ChangeLog
branches/zip
ChangeLog entry for r6674.
------------------------------------------------------------------------
r6712 | marko | 2010-02-16 10:05:36 +0200 (Tue, 16 Feb 2010) | 2 lines
Changed paths:
M /branches/zip/trx/trx0trx.c
branches/zip: trx_lists_init_at_db_start(): Assert that the kernel_mutex
is held by the caller.
------------------------------------------------------------------------
r6713 | sunny | 2010-02-16 10:12:17 +0200 (Tue, 16 Feb 2010) | 7 lines
Changed paths:
M /branches/zip/include/trx0trx.h
branches/zip: Change the bit fields back to ulint. Bit fields were causing
problems with concurrency on SMP systems because of word packing issues.
The number of trx_t's in a system is not sufficient enough to require that
we try and save a few bytes in the data structure.
See rb://255 for details.
------------------------------------------------------------------------
r6714 | sunny | 2010-02-16 10:12:25 +0200 (Tue, 16 Feb 2010) | 2 lines
Changed paths:
M /branches/zip/include/trx0trx.h
branches/zip: Update the comments and fix the whitespace issues.
See rb://255 Approved by: Marko
------------------------------------------------------------------------
r6715 | sunny | 2010-02-16 10:14:21 +0200 (Tue, 16 Feb 2010) | 1 line
Changed paths:
M /branches/zip/include/trx0trx.h
branches/zip: Fix comment. Non functional change.
------------------------------------------------------------------------
r6717 | marko | 2010-02-16 14:53:20 +0200 (Tue, 16 Feb 2010) | 2 lines
Changed paths:
M /branches/zip/include/log0log.ic
branches/zip: log_reserve_and_write_fast(): Correct a race condition
in UNIV_LOG_LSN_DEBUG. This could have caused Issue #440.
------------------------------------------------------------------------
r6718 | marko | 2010-02-16 15:06:16 +0200 (Tue, 16 Feb 2010) | 1 line
Changed paths:
M /branches/zip/include/trx0trx.h
branches/zip: Fix a comment.
------------------------------------------------------------------------
r6723 | marko | 2010-02-17 11:48:34 +0200 (Wed, 17 Feb 2010) | 3 lines
Changed paths:
M /branches/zip/lock/lock0lock.c
branches/zip: lock_table_other_has_incompatible():
Return an incompatible lock or NULL instead of TRUE or FALSE.
Approved by Sunny over IM.
------------------------------------------------------------------------
r6724 | marko | 2010-02-17 15:52:05 +0200 (Wed, 17 Feb 2010) | 11 lines
Changed paths:
M /branches/zip/os/os0file.c
branches/zip: Merge revisions 6613:6669 from branches/5.1:
------------------------------------------------------------------------
r6669 | jyang | 2010-02-11 12:24:19 +0200 (Thu, 11 Feb 2010) | 7 lines
branches/5.1: Fix bug #50691, AIX implementation of readdir_r
causes InnoDB errors. readdir_r() returns an non-NULL value
in the case of reaching the end of a directory. It should
not be treated as an error return.
rb://238 approved by Marko
------------------------------------------------------------------------
------------------------------------------------------------------------
r6726 | marko | 2010-02-17 18:49:21 +0200 (Wed, 17 Feb 2010) | 3 lines
Changed paths:
M /branches/zip/include/fil0fil.h
branches/zip: FIL_PAGE_FILE_FLUSH_LSN: Note that the field is only valid
for the first page of each ibdata* file, not *.ibd files.
Suggested by Heikki, in connection with the LSN warning noted in Issue #341.
------------------------------------------------------------------------
r6727 | marko | 2010-02-17 18:50:20 +0200 (Wed, 17 Feb 2010) | 2 lines
Changed paths:
M /branches/zip/fsp/fsp0fsp.c
branches/zip: fsp_init_file_page_low(): Declare the page uninitialized
for Valgrind.
------------------------------------------------------------------------
r6728 | marko | 2010-02-17 18:54:04 +0200 (Wed, 17 Feb 2010) | 3 lines
Changed paths:
M /branches/zip/fsp/fsp0fsp.c
M /branches/zip/include/univ.i
branches/zip: Remove UNIV_BASIC_LOG_DEBUG.
This fixes the FILE_FLUSH_LSN printouts mentioned in Issue #341.
Suggested by Heikki.
------------------------------------------------------------------------
r6740 | sunny | 2010-02-18 13:44:31 +0200 (Thu, 18 Feb 2010) | 6 lines
Changed paths:
M /branches/zip/lock/lock0lock.c
branches/zip: Don't print the entire lock bit set if the block was not
found in the buffer pool. Only print the bits that are set and that
information is in the lock and not in the block.
See rb://256 approved by Marko.
------------------------------------------------------------------------
r6749 | vasil | 2010-02-20 18:45:41 +0200 (Sat, 20 Feb 2010) | 5 lines
Changed paths:
M /branches/embedded-1.0/btr/btr0btr.c
M /branches/embedded-1.0/btr/btr0cur.c
M /branches/embedded-1.0/btr/btr0pcur.c
M /branches/embedded-1.0/buf/buf0buf.c
M /branches/embedded-1.0/buf/buf0flu.c
M /branches/embedded-1.0/buf/buf0lru.c
M /branches/embedded-1.0/dict/dict0boot.c
M /branches/embedded-1.0/dict/dict0crea.c
M /branches/embedded-1.0/dict/dict0dict.c
M /branches/embedded-1.0/dict/dict0load.c
M /branches/embedded-1.0/fil/fil0fil.c
M /branches/embedded-1.0/fsp/fsp0fsp.c
M /branches/embedded-1.0/ibuf/ibuf0ibuf.c
M /branches/embedded-1.0/include/btr0btr.h
M /branches/embedded-1.0/include/btr0cur.h
M /branches/embedded-1.0/include/btr0pcur.h
M /branches/embedded-1.0/include/btr0pcur.ic
M /branches/embedded-1.0/include/buf0buf.h
M /branches/embedded-1.0/include/buf0buf.ic
M /branches/embedded-1.0/include/dict0boot.h
M /branches/embedded-1.0/include/fil0fil.h
M /branches/embedded-1.0/include/lock0lock.h
M /branches/embedded-1.0/include/log0log.h
M /branches/embedded-1.0/include/log0log.ic
M /branches/embedded-1.0/include/log0recv.h
M /branches/embedded-1.0/include/mem0dbg.h
M /branches/embedded-1.0/include/mem0dbg.ic
M /branches/embedded-1.0/include/mem0mem.h
M /branches/embedded-1.0/include/mem0mem.ic
M /branches/embedded-1.0/include/os0file.h
M /branches/embedded-1.0/include/os0sync.h
M /branches/embedded-1.0/include/os0sync.ic
M /branches/embedded-1.0/include/os0thread.h
M /branches/embedded-1.0/include/que0que.h
M /branches/embedded-1.0/include/que0que.ic
M /branches/embedded-1.0/include/row0merge.h
M /branches/embedded-1.0/include/row0prebuilt.h
M /branches/embedded-1.0/include/srv0srv.h
M /branches/embedded-1.0/include/sync0sync.h
M /branches/embedded-1.0/include/trx0rseg.h
M /branches/embedded-1.0/include/trx0sys.h
M /branches/embedded-1.0/include/trx0trx.h
M /branches/embedded-1.0/include/trx0types.h
M /branches/embedded-1.0/include/trx0undo.h
M /branches/embedded-1.0/include/trx0xa.h
M /branches/embedded-1.0/include/univ.i
M /branches/embedded-1.0/include/ut0vec.h
M /branches/embedded-1.0/include/ut0vec.ic
M /branches/embedded-1.0/lock/lock0lock.c
M /branches/embedded-1.0/log/log0log.c
M /branches/embedded-1.0/log/log0recv.c
M /branches/embedded-1.0/mem/mem0mem.c
M /branches/embedded-1.0/os/os0file.c
M /branches/embedded-1.0/os/os0thread.c
M /branches/embedded-1.0/page/page0page.c
M /branches/embedded-1.0/rem/rem0rec.c
M /branches/embedded-1.0/row/row0ins.c
M /branches/embedded-1.0/row/row0merge.c
M /branches/embedded-1.0/row/row0prebuilt.c
M /branches/embedded-1.0/row/row0sel.c
M /branches/embedded-1.0/row/row0umod.c
M /branches/embedded-1.0/row/row0undo.c
M /branches/embedded-1.0/row/row0upd.c
M /branches/embedded-1.0/srv/srv0srv.c
M /branches/embedded-1.0/srv/srv0start.c
M /branches/embedded-1.0/sync/sync0sync.c
M /branches/embedded-1.0/trx/trx0sys.c
M /branches/embedded-1.0/trx/trx0trx.c
M /branches/embedded-1.0/trx/trx0undo.c
M /branches/embedded-1.0/ut/ut0mem.c
M /branches/innodb+/btr/btr0btr.c
M /branches/innodb+/btr/btr0cur.c
M /branches/innodb+/btr/btr0pcur.c
M /branches/innodb+/buf/buf0buf.c
M /branches/innodb+/buf/buf0lru.c
M /branches/innodb+/dict/dict0crea.c
M /branches/innodb+/dict/dict0dict.c
M /branches/innodb+/dict/dict0load.c
M /branches/innodb+/handler/ha_innodb.cc
M /branches/innodb+/handler/ha_innodb.h
M /branches/innodb+/handler/handler0alter.cc
M /branches/innodb+/include/btr0btr.h
M /branches/innodb+/include/btr0cur.h
M /branches/innodb+/include/btr0pcur.h
M /branches/innodb+/include/btr0pcur.ic
M /branches/innodb+/include/buf0buf.h
M /branches/innodb+/include/log0log.h
M /branches/innodb+/include/mem0dbg.h
M /branches/innodb+/include/mem0dbg.ic
M /branches/innodb+/include/os0file.h
M /branches/innodb+/include/row0mysql.h
M /branches/innodb+/include/srv0srv.h
M /branches/innodb+/include/sync0sync.h
M /branches/innodb+/include/trx0trx.h
M /branches/innodb+/lock/lock0lock.c
M /branches/innodb+/log/log0log.c
M /branches/innodb+/log/log0recv.c
M /branches/innodb+/mem/mem0dbg.c
M /branches/innodb+/os/os0file.c
M /branches/innodb+/page/page0page.c
M /branches/innodb+/row/row0ins.c
M /branches/innodb+/row/row0mysql.c
M /branches/innodb+/row/row0sel.c
M /branches/innodb+/srv/srv0srv.c
M /branches/innodb+/srv/srv0start.c
M /branches/innodb+/sync/sync0sync.c
M /branches/innodb+_metrics_table/btr/btr0btr.c
M /branches/innodb+_metrics_table/buf/buf0buf.c
M /branches/innodb+_metrics_table/buf/buf0flu.c
M /branches/innodb+_metrics_table/dict/dict0crea.c
M /branches/innodb+_metrics_table/dict/dict0dict.c
M /branches/innodb+_metrics_table/dict/dict0load.c
M /branches/innodb+_metrics_table/handler/ha_innodb.cc
M /branches/innodb+_metrics_table/handler/ha_innodb.h
M /branches/innodb+_metrics_table/handler/handler0alter.cc
M /branches/innodb+_metrics_table/handler/i_s.cc
M /branches/innodb+_metrics_table/handler/i_s.h
M /branches/innodb+_metrics_table/include/mem0dbg.h
M /branches/innodb+_metrics_table/include/mem0dbg.ic
M /branches/innodb+_metrics_table/include/srv0mon.h
M /branches/innodb+_metrics_table/include/srv0mon.ic
M /branches/innodb+_metrics_table/include/srv0srv.h
M /branches/innodb+_metrics_table/lock/lock0lock.c
M /branches/innodb+_metrics_table/log/log0log.c
M /branches/innodb+_metrics_table/mem/mem0dbg.c
M /branches/innodb+_metrics_table/os/os0file.c
M /branches/innodb+_metrics_table/page/page0zip.c
M /branches/innodb+_metrics_table/row/row0mysql.c
M /branches/innodb+_metrics_table/row/row0purge.c
M /branches/innodb+_metrics_table/row/row0sel.c
M /branches/innodb+_metrics_table/srv/srv0mon.c
M /branches/innodb+_metrics_table/srv/srv0srv.c
M /branches/innodb+_metrics_table/sync/sync0sync.c
M /branches/innodb+_metrics_table/trx/trx0roll.c
M /branches/innodb+_metrics_table/trx/trx0trx.c
M /branches/innodb+_persistent_stats/btr/btr0btr.c
M /branches/innodb+_persistent_stats/buf/buf0buf.c
M /branches/innodb+_persistent_stats/data/data0type.c
M /branches/innodb+_persistent_stats/dict/dict0boot.c
M /branches/innodb+_persistent_stats/dict/dict0crea.c
M /branches/innodb+_persistent_stats/dict/dict0dict.c
M /branches/innodb+_persistent_stats/dict/dict0load.c
M /branches/innodb+_persistent_stats/dict/dict0mem.c
M /branches/innodb+_persistent_stats/fil/fil0fil.c
M /branches/innodb+_persistent_stats/fsp/fsp0fsp.c
M /branches/innodb+_persistent_stats/handler/ha_innodb.cc
M /branches/innodb+_persistent_stats/handler/ha_innodb.h
M /branches/innodb+_persistent_stats/handler/handler0alter.cc
M /branches/innodb+_persistent_stats/ibuf/ibuf0ibuf.c
M /branches/innodb+_persistent_stats/include/btr0pcur.h
M /branches/innodb+_persistent_stats/include/btr0pcur.ic
M /branches/innodb+_persistent_stats/include/db0err.h
M /branches/innodb+_persistent_stats/include/dict0dict.h
M /branches/innodb+_persistent_stats/include/dict0mem.h
M /branches/innodb+_persistent_stats/include/ha_prototypes.h
M /branches/innodb+_persistent_stats/include/lock0lock.h
M /branches/innodb+_persistent_stats/include/log0log.h
M /branches/innodb+_persistent_stats/include/log0recv.h
M /branches/innodb+_persistent_stats/include/mem0dbg.h
M /branches/innodb+_persistent_stats/include/mem0dbg.ic
M /branches/innodb+_persistent_stats/include/os0file.h
M /branches/innodb+_persistent_stats/include/pars0pars.h
M /branches/innodb+_persistent_stats/include/srv0srv.h
M /branches/innodb+_persistent_stats/include/sync0sync.h
M /branches/innodb+_persistent_stats/include/trx0sys.h
M /branches/innodb+_persistent_stats/include/trx0trx.h
M /branches/innodb+_persistent_stats/include/ut0lst.h
M /branches/innodb+_persistent_stats/include/ut0ut.h
M /branches/innodb+_persistent_stats/lock/lock0lock.c
M /branches/innodb+_persistent_stats/log/log0log.c
M /branches/innodb+_persistent_stats/log/log0recv.c
M /branches/innodb+_persistent_stats/mem/mem0dbg.c
M /branches/innodb+_persistent_stats/os/os0file.c
M /branches/innodb+_persistent_stats/page/page0page.c
M /branches/innodb+_persistent_stats/pars/pars0pars.c
M /branches/innodb+_persistent_stats/row/row0merge.c
M /branches/innodb+_persistent_stats/row/row0mysql.c
M /branches/innodb+_persistent_stats/row/row0sel.c
M /branches/innodb+_persistent_stats/row/row0umod.c
M /branches/innodb+_persistent_stats/row/row0upd.c
M /branches/innodb+_persistent_stats/srv/srv0srv.c
M /branches/innodb+_persistent_stats/srv/srv0start.c
M /branches/innodb+_persistent_stats/sync/sync0sync.c
M /branches/innodb+_persistent_stats/trx/trx0i_s.c
M /branches/innodb+_persistent_stats/trx/trx0sys.c
M /branches/innodb+_persistent_stats/trx/trx0trx.c
M /branches/innodb+_persistent_stats/ut/ut0ut.c
M /branches/innofts+/handler/ha_innodb.cc
M /branches/innofts+/handler/i_s.cc
M /branches/innofts+/handler/i_s.h
M /branches/innofts+/include/fut0fut.h
M /branches/performance_schema/btr/btr0sea.c
M /branches/performance_schema/buf/buf0buf.c
M /branches/performance_schema/dict/dict0dict.c
M /branches/performance_schema/fil/fil0fil.c
M /branches/performance_schema/handler/ha_innodb.cc
M /branches/performance_schema/include/srv0srv.h
M /branches/performance_schema/include/sync0rw.h
M /branches/performance_schema/include/sync0rw.ic
M /branches/performance_schema/include/sync0sync.h
M /branches/performance_schema/include/sync0sync.ic
M /branches/performance_schema/include/sync0types.h
M /branches/performance_schema/log/log0log.c
M /branches/performance_schema/srv/srv0srv.c
M /branches/performance_schema/sync/sync0rw.c
M /branches/performance_schema/trx/trx0i_s.c
M /branches/performance_schema/trx/trx0purge.c
M /branches/plugin-2.0/buf/buf0buf.c
M /branches/plugin-2.0/buf/buf0lru.c
M /branches/plugin-2.0/dict/dict0boot.c
M /branches/plugin-2.0/dict/dict0crea.c
M /branches/plugin-2.0/dict/dict0dict.c
M /branches/plugin-2.0/dict/dict0load.c
M /branches/plugin-2.0/dict/dict0mem.c
M /branches/plugin-2.0/fil/fil0fil.c
M /branches/plugin-2.0/fsp/fsp0fsp.c
M /branches/plugin-2.0/handler/ha_innodb.cc
M /branches/plugin-2.0/handler/ha_innodb.h
M /branches/plugin-2.0/handler/handler0alter.cc
M /branches/plugin-2.0/ibuf/ibuf0ibuf.c
M /branches/plugin-2.0/include/dict0mem.h
M /branches/plugin-2.0/include/ha_prototypes.h
M /branches/plugin-2.0/include/lock0lock.h
M /branches/plugin-2.0/include/log0log.h
M /branches/plugin-2.0/include/log0recv.h
M /branches/plugin-2.0/include/mem0dbg.h
M /branches/plugin-2.0/include/mem0dbg.ic
M /branches/plugin-2.0/include/os0file.h
M /branches/plugin-2.0/include/row0mysql.h
M /branches/plugin-2.0/include/srv0srv.h
M /branches/plugin-2.0/include/sync0sync.h
M /branches/plugin-2.0/include/trx0sys.h
M /branches/plugin-2.0/include/trx0trx.h
M /branches/plugin-2.0/lock/lock0lock.c
M /branches/plugin-2.0/log/log0log.c
M /branches/plugin-2.0/log/log0recv.c
M /branches/plugin-2.0/mem/mem0dbg.c
M /branches/plugin-2.0/os/os0file.c
M /branches/plugin-2.0/page/page0page.c
M /branches/plugin-2.0/row/row0merge.c
M /branches/plugin-2.0/row/row0mysql.c
M /branches/plugin-2.0/row/row0sel.c
M /branches/plugin-2.0/row/row0umod.c
M /branches/plugin-2.0/row/row0upd.c
M /branches/plugin-2.0/srv/srv0srv.c
M /branches/plugin-2.0/srv/srv0start.c
M /branches/plugin-2.0/sync/sync0sync.c
M /branches/plugin-2.0/trx/trx0i_s.c
M /branches/plugin-2.0/trx/trx0sys.c
M /branches/plugin-2.0/trx/trx0trx.c
M /branches/zip/btr/btr0btr.c
M /branches/zip/btr/btr0cur.c
M /branches/zip/btr/btr0pcur.c
M /branches/zip/buf/buf0buf.c
M /branches/zip/buf/buf0lru.c
M /branches/zip/dict/dict0boot.c
M /branches/zip/dict/dict0crea.c
M /branches/zip/dict/dict0dict.c
M /branches/zip/dict/dict0load.c
M /branches/zip/fsp/fsp0fsp.c
M /branches/zip/handler/ha_innodb.cc
M /branches/zip/handler/ha_innodb.h
M /branches/zip/handler/handler0alter.cc
M /branches/zip/include/btr0btr.h
M /branches/zip/include/btr0cur.h
M /branches/zip/include/btr0pcur.h
M /branches/zip/include/btr0pcur.ic
M /branches/zip/include/buf0buf.h
M /branches/zip/include/dict0boot.h
M /branches/zip/include/fil0fil.h
M /branches/zip/include/log0log.h
M /branches/zip/include/log0log.ic
M /branches/zip/include/log0recv.h
M /branches/zip/include/mem0dbg.h
M /branches/zip/include/mem0dbg.ic
M /branches/zip/include/mem0mem.h
M /branches/zip/include/mem0mem.ic
M /branches/zip/include/os0file.h
M /branches/zip/include/que0que.h
M /branches/zip/include/que0que.ic
M /branches/zip/include/row0mysql.h
M /branches/zip/include/srv0srv.h
M /branches/zip/include/sync0sync.h
M /branches/zip/include/trx0rseg.h
M /branches/zip/include/trx0trx.h
M /branches/zip/include/trx0types.h
M /branches/zip/include/univ.i
M /branches/zip/lock/lock0lock.c
M /branches/zip/log/log0log.c
M /branches/zip/log/log0recv.c
M /branches/zip/mem/mem0dbg.c
M /branches/zip/mem/mem0mem.c
M /branches/zip/os/os0file.c
M /branches/zip/page/page0page.c
M /branches/zip/rem/rem0rec.c
M /branches/zip/row/row0ins.c
M /branches/zip/row/row0merge.c
M /branches/zip/row/row0mysql.c
M /branches/zip/row/row0sel.c
M /branches/zip/row/row0umod.c
M /branches/zip/srv/srv0srv.c
M /branches/zip/srv/srv0start.c
M /branches/zip/sync/sync0sync.c
M /branches/zip/trx/trx0rseg.c
M /branches/zip/trx/trx0trx.c
Non-functional change: update copyright year to 2010 of the files
that have been modified after 2010-01-01 according to svn.
for f in $(svn log -v -r{2010-01-01}:HEAD |grep "^ M " |cut -b 16- |sort -u) ; do sed -i "" -E 's/(Copyright \(c\) [0-9]{4},) [0-9]{4}, (.*Innobase Oy.+All Rights Reserved)/\1 2010, \2/' $f ; done
------------------------------------------------------------------------
r6750 | marko | 2010-02-22 08:57:23 +0200 (Mon, 22 Feb 2010) | 2 lines
Changed paths:
M /branches/zip/include/row0sel.h
M /branches/zip/row/row0sel.c
branches/zip: row_fetch_store_uint4(): Remove unused function.
This was added to trunk in r435.
------------------------------------------------------------------------
r6754 | marko | 2010-02-24 10:56:43 +0200 (Wed, 24 Feb 2010) | 17 lines
Changed paths:
M /branches/zip/row/row0merge.c
branches/zip: Allocate the merge sort buffers from a heap, not stack.
The merge sort can use up to 48KiB of buffers when merging blocks.
That can cause a stack overflow, especially on 64-bit systems when not
building with inlined functions. This was reported as Issue #462.
row_merge_dup_report(): Allocate buf and offsets from a heap.
row_merge_heap_create(): Allocate space for buf[3] too. Fix bogus
sizeof arithmetics that happened to work, because
sizeof(ulint)==sizeof(void*).
row_merge_blocks(), row_merge_blocks_copy(): Allocate buf[3] from heap.
row_merge_insert_index_tuples(): Allocate buf from graph_heap.
rb://258 approved and tested by Sunny Bains
------------------------------------------------------------------------
r6767 | calvin | 2010-03-01 18:16:10 +0200 (Mon, 01 Mar 2010) | 3 lines
Changed paths:
M /branches/zip/srv/srv0srv.c
branches/zip: fix bug#51587
Non-functional change.
------------------------------------------------------------------------
r6768 | vasil | 2010-03-02 18:20:48 +0200 (Tue, 02 Mar 2010) | 5 lines
Changed paths:
M /branches/zip/include/btr0btr.h
M /branches/zip/include/btr0btr.ic
branches/zip:
Add a NOTE to the comment of btr_node_ptr_get_child_page_no()
to prevent mysterious bugs.
------------------------------------------------------------------------
r6770 | marko | 2010-03-03 12:52:55 +0200 (Wed, 03 Mar 2010) | 12 lines
Changed paths:
M /branches/zip/handler/handler0alter.cc
M /branches/zip/mysql-test/innodb-index.result
M /branches/zip/mysql-test/innodb-index.test
M /branches/zip/mysql-test/innodb.result
M /branches/zip/mysql-test/innodb.test
branches/zip: Disallow duplicate index name when creating an index.
This should fix Mantis Issue #461.
innodb.test, innodb.result, innodb-index.test, innodb-index.result:
Adjust the test result and mention that the introduced restriction
has been reported as MySQL Bug #51451.
innobase_check_index_keys(): Add a parameter for the InnoDB table and
check that no duplicate index name is added. Report errors by
my_error() instead of sql_print_error().
rb://260 approved by Sunny Bains
------------------------------------------------------------------------
r6771 | marko | 2010-03-03 14:52:43 +0200 (Wed, 03 Mar 2010) | 1 line
Changed paths:
M /branches/zip/ChangeLog
Document r6770.
------------------------------------------------------------------------
r6773 | marko | 2010-03-03 15:31:54 +0200 (Wed, 03 Mar 2010) | 2 lines
Changed paths:
M /branches/zip/row/row0row.c
branches/zip: row_raw_format(): Silence a GCC 4.4.2 warning
of possibly uninitialized variable format_in_hex.
------------------------------------------------------------------------
ibuf_delete(): Note that the mtr must be committed before latching any
further pages.
ibuf_restore_pos(): New function, refactored from ibuf_delete_rec().
ibuf_merge_or_delete_for_page(): Commit the mini-transaction after
calling ibuf_delete(). If ibuf_restore_pos() fails, restart the loop.
rb://222 approved by Sunny Bains. This should fix Issue #135.
+ failing statements
Implicit DROP event for temporary table is not getting
LOG_EVENT_THREAD_SPECIFIC_F flag, because, in the previous
executed statement in the same thread, which might even be a
failed statement, the thread_specific_used flag is set to
FALSE (in mysql_reset_thd_for_next_command) and not set to TRUE
before connection is shutdown. This means that implicit DROP
event will take the FALSE value from thread_specific_used and
will not set LOG_EVENT_THREAD_SPECIFIC_F in the event header. As
a consequence, mysqlbinlog will not print the pseudo_thread_id
from the DROP event, because one of the requirements for the
printout is that this flag is set to TRUE.
We fix this by setting thread_specific_used whenever we are
binlogging a DROP in close_temporary_tables, and resetting it to
its previous value afterward.
when cmake is used for building in a symlinked directory,
and confguration is later adjusted with "cmake-gui ." After it,
GenServerSource fails with "no rule for <filename>". The reason
for the error is that cmake-gui resolves "." as realpath and rules
are generated accordingly, while "cmake" used symlinked path
The fix uses ${CMAKE_CURRENT_BINARY_DIR} instead of
${CMAKE_BINARY_DIR}/sql for generated files.
This causes CMake to use relative file names so
relative file names when generating make rules.
Using relative filenames avoids the problem of
refering to the same directory using 2 different paths.
Besides, using ${CMAKE_CURRENT_BINARY_DIR} is
a commonly used style when working with generated
files.
autotools runs
- Fix recognition of --with-debug=full in configure wrapper
- Remove CMakeCache.txt in configure wrapper, to match the original
- Fix recognition of max-no-ndb
- Fix broken dependencies of mysql_fix_privilege_table.sql from
mysql_system_tables.sql and mysql_system_tables_fix.sql
- Add "distclean target" that informs user about appropriate bzr command
work in 5.1.40)
MERGE engine fails to open child table from a different
database if child table/database name contains characters
that are subject for table name to filename encoding
(WL1324).
Another problem is that MERGE engine didn't properly open
child table from the same database if child table name
contains characters like '/', '#'.
The problem was that table name to file name encoding was
applied inconsistently:
* On CREATE: encode table name + database name if child
table is in different database; do not encode table
name if child table is in the same database;
* No decoding on open.
With this fix child table/database names are always
encoded on CREATE and decoded on open. Compatibility
with older tables preserved.
Along with this patch comes fix for SHOW CREATE TABLE,
which used to show child table/database path instead
of child table/database names.
Diagnostics_area::set_ok_status on DROP FUNCTION
This assert tests that the server is not trying to send "ok" to
the client if an error has occured during statement processing.
In this case, the assert was triggered by lock timeout errors when
accessing system tables to do an implicit REVOKE after executing
DROP FUNCTION/PROCEDURE. In practice, this was only likely to
happen with very low values for "lock_wait_timeout" (in the bug report
1 second was used). These errors were ignored and the server tried
to send "ok" to the client, triggering the assert.
The patch for Bug#45225 introduced lock timeouts for metadata locks.
This made it possible to get timeouts when accessing system tables.
Note that a followup patch for Bug#45225 pushed after this
bug was reported, changed accessing of system tables such
that the user-supplied timeout value is ignored and the maximum
timeout value is used instead. This exact bug was therefore
only noticeable in the period between the initial Bug#45225 patch
and the followup patch.
However, the same problem could occur for any errors during revoking
of privileges - not just timeouts. This patch fixes the problem by
making sure that any errors during revoking of privileges are
reported to the client.
Test case added to sp-destruct.test. Since the original bug is not
reproducable now that system tables are accessed using a a long
timeout value, this test instead calls DROP FUNCTION with a grant
system table missing.
