- Problem: mysql_admin_table() calls open_temporary_tables(). This
causes assertion failure, because mysql_execute_command() has
already called open_temporary_tables()
- Solution: call close_thread_tables() at the start of
mysql_admin_table(), like mysql-5.6 does
- After the merge from mysql-5.6, open_tables() did not call
open_and_process_table() for temporary table. The logic was that temporary
tables were already opened when mysql_execute_command() has called
open_temporary_tables().
This worked for the most part, except for temporary tables of type MERGE. for
which open_and_process_table() must call
table->file->extra(HA_EXTRA_ADD_CHILDREN_LIST).
Failure to make this call resulted in crash further in execution.
tables->table->file->extra(HA_EXTRA_ADD_CHILDREN_LIST)
-Note 1031 Table storage engine for 't1' doesn't have this option
+Note 1031 Table storage engine for 'InnoDB' doesn't have this option
They were caused by a change in MariaDB which changed ER_ILLEGAL_HA message
text to be like:
"Storage engine InnoDB of the table `test`.`t1` doesn't have this option"
Some the error calls were changed to pass new parameters, but some were left
to be old. Also the error text in errmsg-ut8.txt was not changed.
- Take into account that Dynamic_array::back() now returns
pointer to the last element (it used to return pointer to
right after the last element)
- Fix error messages merge: ER_INTERNAL_ERROR was defined
independently by both mysql-5.6 and mariadb-5.5. Switch
to their error number, and still support ours for compatibility.
- strict.test updated (changed back) after the cset with "Fix
type_newdecimal.test ..." two csets ago
- row-checksum.test changed the code from HA_WRONG_CREATE_OPTION
to ER_ILLEGAL_HA_CREATE_OPTION, like mysql-5.6 did
- MariaDB does not have mysql.slave_master_info, mysql.slave_relay_log_info ,mysql.slave_worker_info
or mysql.ndb_binlog_index tables.
- Some tests expected to have these tables (this was an incorrect merge from 5.6, which merged
necessary tables like mysql.innodb*stats, but also got these tables)
- make the test output stable
- make Log_to_csv_event_handler::log_slow() to write the value
of thd->thread_id (it didn't, and so 0 was always logged).
