mirror of
https://github.com/MariaDB/server.git
synced 2025-01-20 14:02:32 +01:00
6 commits
Author | SHA1 | Message | Date | |
---|---|---|---|---|
Guilhem Bichot
|
cffc4bd90b |
Fixes to tests and their results, to account for differences between InnoDB 1.0.4 and the old builtin.
All committed result differences have either been verified by me or copied from Oracle's provided results (storage/innodb_plugin/mysql-test/*.result, storage/innodb_plugin/mysql-test/patches). mysql-test/r/information_schema.result: queries changed a bit mysql-test/r/information_schema_db.result: queries changed a bit mysql-test/r/innodb-autoinc.result: importing piece from storage/innodb_plugin/mysql-test/innodb-autoinc.result mysql-test/r/innodb.result: result close to storage/innodb_plugin/innodb.result, except 4095 pages instead of 8191, which makes sense as Summit runs with a buffer pool of 64M, whereas the mentioned result file was made with a buffer pool of 128M. mysql-test/r/mysqlshow.result: InnoDB I_S tables have arrived mysql-test/suite/funcs_1/r/is_columns_is.result: queries changed a bit mysql-test/suite/funcs_1/r/is_columns_is_embedded.result: queries changed a bit mysql-test/suite/funcs_1/r/is_tables_is.result: queries changed a bit mysql-test/suite/funcs_1/t/is_columns_is.test: making I_S queries ignore InnoDB I_S tables mysql-test/suite/funcs_1/t/is_columns_is_embedded.test: making I_S queries ignore InnoDB I_S tables mysql-test/suite/funcs_1/t/is_tables_is.test: making I_S queries ignore InnoDB I_S tables mysql-test/suite/innodb/r/innodb-zip.result: result update mysql-test/suite/innodb/t/innodb-zip.test: 439, as size of prefix key, throws error with certain system zlib (ubuntu "intrepid") but not with zlib bundled with MySQL, because zlib's compressBound() are different (and used by InnoDB's page_zip_empty_size()). mysql-test/suite/sys_vars/r/innodb_file_per_table_basic.result: result update mysql-test/suite/sys_vars/r/innodb_lock_wait_timeout_basic.result: result update mysql-test/suite/sys_vars/r/innodb_sync_spin_loops_basic_32.result: result update (default value is 30 in the plugin, 20 in the builtin) mysql-test/suite/sys_vars/r/innodb_sync_spin_loops_basic_64.result: result update (default value is 30 in the plugin, 20 in the builtin) mysql-test/suite/sys_vars/r/table_definition_cache_basic.result: result update (default value is 400 in Summit) mysql-test/suite/sys_vars/t/innodb_file_per_table_basic.test: variable is writable in the plugin (patch from Oracle) mysql-test/suite/sys_vars/t/innodb_lock_wait_timeout_basic.test: variable is per-session in the plugin (patch from Oracle) mysql-test/t/information_schema.test: making I_S queries ignore InnoDB I_S tables mysql-test/t/information_schema_db.test: making I_S queries ignore InnoDB I_S tables mysql-test/t/innodb-autoinc.test: importing piece from storage/innodb_plugin/mysql-test/innodb-autoinc.test mysql-test/t/innodb.test: importing most of storage/innodb_plugin/t/innodb.test. Most replace_result were not needed (no path printed), some where (for --embedded). mysql-test/t/mysqlshow.test: output of test now depends on InnoDB or not InnoDB. As there is no way to make mysqlshow produce a single output in those two cases (no way to make it exclude InnoDB I_S tables), let the test depend on InnoDB, it isn't a very selective condition, and the test is simple enough. storage/innobase/CMakeLists.txt: thanks Vlad for the noticing () vs {} |
||
unknown
|
da0d9f37c4 |
Bug #19147: mysqlshow INFORMATION_SCHEMA does not work
When a wildcard database name is given the mysqlshow, but that wildcard matches one database *exactly* (it contains the wildcard character), we list the contents of that database instead of just listing the database name as matching the wildcard. Probably the most common instance of users encountering this behavior would be with "mysqlshow information_schema". client/mysqlshow.c: Add special handling for listing a single database that has a name that looked like it contained wildcards. In this case, we just go ahead and list the contents of the database, since there is a very high probability that is what the user really wanted to do. (For example, 'mysqlshow INFORMATION_SCHEMA' will show the I_S tables instead of just the I_S database.) mysql-test/r/mysqlshow.result: Add new results mysql-test/t/mysqlshow.test: Add new regression test |
||
unknown
|
64206b1850 |
Review fixes of new pushed code
- Fixed tests - Optimized new code - Fixed some unlikely core dumps - Better bug fixes for: - #14397 - OPTIMIZE TABLE with an open HANDLER causes a crash - #14850 (ERROR 1062 when a quering a view using a Group By on a column that can be null mysql-test/r/create.result: Update results after removing wrong warnings for CREATE ... SELECT New tests mysql-test/r/handler.result: Drop used tables mysql-test/r/kill.result: Make test portable mysql-test/r/mysqlshow.result: Drop tables used by previous test mysql-test/r/trigger.result: Reuse old procedure name mysql-test/r/view.result: Extra tests mysql-test/t/create.test: New tests to test fix of removing wrong warnings for CREATE ... SELECT mysql-test/t/disabled.def: Enable 'kill' test (should now be portable) mysql-test/t/handler.test: Drop used tables mysql-test/t/kill.test: Make test portable even if kill doesn't work at once mysql-test/t/mysqlshow.test: Drop tables used by previous test mysql-test/t/trigger.test: Reuse old procedure name mysql-test/t/view.test: Extra tests sql/field.cc: Removed compiler warning sql/ha_federated.cc: my_snprintf -> strmake() (Simple optimization) sql/ha_ndbcluster.cc: Indentation cleanups and trival optimization sql/item.cc: Moved save_org_in_field() to item.cc to make it easier to test Remove setting of null_value as this is not needed sql/item.h: Moved save_org_in_field() to item.cc to make it easier to test sql/log_event.cc: Remove inline of slave_load_file_stem() Added 'extension' parameter to slave_load_file_stem() to get smaller code Removed not critical (or needed) DBUG_ASSERT()'s Cleaned up usage of slave_load_file_stem() to not depend on constant string lengths Indentation fixes sql/opt_range.cc: Moved code from declaration to function body (To make it more readable) sql/parse_file.cc: Fixed DBUG_PRINT sql/sp.cc: Simple cleanups - Removed not needed {} level - Ensure saved variables starts with old_ sql/sp_head.cc: Indentation fixes Remove core dump when using --debug when m_next_cached_sp == 0 Fixed compiler warnings Trivial optimizations sql/sp_head.h: Changed argument to set_definer() to const Added THD argument to recursion_level_error() to avoid call to current_thd sql/sql_acl.cc: Removed not needed test (first_not_own_table is the guard) sql/sql_base.cc: Removed extra empty line sql/sql_handler.cc: Don't test table version in mysql_ha_read() as this is already tested in lock_tables() Moved call to insert_fields to be after lock_table() to guard aganst reopen of tables (Better fix for Bug#14397 - OPTIMIZE TABLE with an open HANDLER causes a crash) sql/sql_insert.cc: Mark fields that are set in CREATE ... SELECT as used (Removed wrong warnings about field not having a default value) sql/sql_parse.cc: Removed not needed test of 'tables' (first_not_own_table is the guard) Simplify code sql/sql_select.cc: Use group->field to check if value is null instead of item called by 'save_org_in_field' This is a better bug fix for #14850 (ERROR 1062 when a quering a view using a Group By on a column that can be null) sql/sql_trigger.cc: Move sql_modes_parameters outside of function Indentation fixes Fixed compiler warning Ensure that thd->lex->query_tables_own_last is set properly before calling check_table_access() (This allows us to remove the extra test in check_grant() and check_table_access()) |
||
unknown
|
c807724f36 |
Review of code pushed since last 5.0 pull:
Ensure that ccache is also used for C programs mysql: Ensure that 'delimiter' works the same way in batch mode as in normal mode mysqldump: Change to use ;; (instead of //) as a stored procedure/trigger delimiter Fixed test cases by adding missing DROP's and rename views to be of type 'v#' Removed MY_UNIX_PATH from fn_format() Removed current_db_used from TABLE_LIST Removed usage of 'current_thd' in Item_splocal Removed some compiler warnings A bit faster longlong2str code BUILD/FINISH.sh: Ensure that ccache is also used for C programs BUILD/SETUP.sh: Ensure that ccache is also used for C programs client/mysql.cc: More debugging Ensure that 'delimiter' works the same way in batch mode as in normal mode. Compare 'delimiter' command case-insensitive. The above fixes the delimiter bugs so that we can now use ;; as a trigger/SP function delimiter in mysqldump. client/mysqldump.c: Indentation fixes Use ;; as a delmimiter for stored procedures and triggers instead of // client/mysqltest.c: Indentation fixes include/my_sys.h: Remove not needed MY_UNIX_PATH parameter mysql-test/r/alter_table.result: Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start) mysql-test/r/func_str.result: More testing of CONV() (to ensure that longlong2str() works correctly) mysql-test/r/information_schema.result: Drop all used tables and views Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails mysql-test/r/information_schema_inno.result: Drop all used tables mysql-test/r/multi_statement.result: Drop used tables mysql-test/r/mysql.result: Add error messages to result mysql-test/r/mysqldump.result: ;; is now used as SP/trigger delimiter mysql-test/r/mysqlshow.result: Drop used tables mysql-test/r/temp_table.result: Drop used views Rename views to v# mysql-test/t/alter_table.test: Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start) mysql-test/t/func_str.test: More testing of CONV() (to ensure that longlong2str() works correctly) mysql-test/t/information_schema.test: Drop all used tables and views Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails mysql-test/t/information_schema_inno.test: Drop all used tables mysql-test/t/multi_statement.test: Drop used tables mysql-test/t/mysql.test: Add error messages to result mysql-test/t/mysqlshow.test: Drop used tables mysql-test/t/temp_table.test: Drop used views Rename views to v# mysys/mf_format.c: Remove not needed MY_UNIX_PATH parameter (This goes against how fn_format() is supposed to work and also conflicts with other options like MY_RETURN_REAL_PATH) sql/ha_federated.cc: Removed extra empty line sql/item.cc: Use 'str_value' instead of 'str_value_ptr' to hold result for Item_splocal Remove some calls to 'thd' in Item_splocal by making 'thd' a class variable One doesn't have to set 'null_value' when calling 'is_null()' sql/item.h: Add THD as a class variable to Item_splocal Use 'str_value' instead of 'str_value_ptr' to hold temp result Fixed bug in Item_hex when used in CAST() sql/item_func.cc: Optimize new code sql/log_event.cc: Move 'to_unix_path()' out of fn_format() sql/opt_range.cc: Simplify code sql/sp_head.cc: Ensure that Item_splocal has thd set before we call '->this_item()' sql/sql_class.cc: Return error if Statement::insert() fails in either hash_insert() sql/sql_parse.cc: Remove 'current_db_used' as we can trivially check if db table qualifier was used without this. Simplify code sql/sql_prepare.cc: Use enum instead of const int, to avoid ugly code for VC++ sql/structs.h: Remove compiler warnings when using STRING_WITH_LEN() with constant strings. sql/table.cc: Fixed indentation sql/table.h: Remove not needed current_db_used strings/decimal.c: Simplify code strings/longlong2str-x86.s: A bit faster longlong2str. (Took some ideas from Peter Gulutzan's code) strings/my_strtoll10.c: Simplify code for MetroWerks compiler |
||
unknown
|
4189e7c85f |
Cleanup tests and results after merge from 4.1 of embedded
server testing cleanups. mysql-test/r/innodb.result: Update results mysql-test/r/insert_select-binlog.result: Update results mysql-test/r/mix_innodb_myisam_binlog.result: Update results mysql-test/r/ps_1general.result: Update results mysql-test/r/ps_grant.result: Update results mysql-test/r/view.result: Update results mysql-test/t/client_xml.test: Skip test with embedded server mysql-test/t/flush_read_lock_kill.test: Skip test with embedded server mysql-test/t/grant3.test: Skip test with embedded server mysql-test/t/information_schema.test: Skip test with embedded server mysql-test/t/innodb.test: Fix up filenames mysql-test/t/multi_update.test: Skip test with embedded server mysql-test/t/mysqlshow.test: Skip test with embedded server mysql-test/t/ps_1general.test: Move grant-related tests to ps_grant, and fix cleanup of filename mysql-test/t/ps_grant.test: Add additional tests mysql-test/t/sp-security.test: Skip test with embedded server mysql-test/t/user_limits.test: Skip test with embedded server mysql-test/t/view.test: Split grant-related tests to new test file view_grant |
||
unknown
|
b54f4c51bb |
Add support for showing table type to mysqlshow command. (Bug #5036)
client/mysqlshow.c: Add support for -t (--show-table-type) switch mysql-test/mysql-test-run.sh: Add support for running mysqlshow |