Commit graph

166974 commits

Author SHA1 Message Date
Venkatesh Duggirala
151b8ec4d1 Bug #20439913 CREATE TABLE DB.TABLE LIKE TMPTABLE IS BINLOGGED INCORRECTLY - BREAKS A SLAVE
Analysis:
In row based replication, Master does not send temp table information
to Slave. If there are any DDLs that involves in regular table that needs
to be sent to Slave and a temp tables (which will not be available at Slave),
the Master rewrites the query replacing temp table with it's defintion.
Eg: create table regular_table like temptable.
In rewrite logic, server is ignoring the database of regular table
which can cause problems mentioned in this bug.

Fix: dont ignore database information (if available) while
rewriting the query
2015-03-13 12:32:44 +05:30
Elena Stepanova
5a3bf84468 MDEV-7692 MariaDB - mysql-test - SUITE:percona - percona.innodb_sys_index 'xtradb' fails - @@version_comment
The test checked version_comment which is not helpful, and it would
cause the mismatch on any build apart from default source builds.
Fixed by removing the check
2015-03-12 18:53:31 +02:00
Sreeharsha Ramanavarapu
96974ea7ca Revert "Bug #19573096: LOADING CORRUPTED GEOMETRY DATA INTO A"
This reverts commit c7de768ec20f5167cff2c69a255d95ca2eded46a.
2015-03-11 16:07:49 +05:30
Thirunarayanan Balathandayuthapani
48869fceba Bug #20417397 MYSQL SHOW ENGINE INNODB STATUS SHOWING NEGATIVE
RESERVATION AND SIGNAL COUNT

Problem:
	Reservation and Signal count value shows negative value for show engine
innodb statement.

Solution:
	This is happening due to counter overflow error. Reservation and Signal
count values are defined as unsigned long but these variables are converted to
long while printing it. Change Reservation and Signal count values as unsigned
long datatype while printing it.

Reviewed-by: Marko Mäkelä <marko.makela@oracle.com>
Approved in bug page.
2015-03-11 15:17:35 +05:30
Sreeharsha Ramanavarapu
54d23eceb7 Bug #19573096: LOADING CORRUPTED GEOMETRY DATA INTO A
MYISAM TABLE CAUSES THE SERVER TO CRASH

Issue:
-----
During index maintanence, R-tree node might need a split.
In some cases the square of mbr could be calculated to
infinite (as in this case) or to NaN. This is currently
not handled. This is specific to MyISAM.

SOLUTION:
---------
If the calculated value in "mbr_join_square" is infinite or
NaN, set it to max double value.

Initialization of output parameters of "pick_seeds" is
required if calculation is infinite (or negative infinite).

Similar to the fix made for INNODB as part of Bug#19533996.
2015-03-11 11:18:52 +05:30
Rik Prohaska
e191b827f6 Merge branch 'master' into releases/tokudb-7.5 2015-03-10 15:18:19 -04:00
Elena Stepanova
34f37aa0c0 MDEV-7643 MTR creates nested links when tests are run with --mem
1) fix 5.5.42 vs 5.5.41 problem, nested links;
2) fix older MariaDB vs MySQL problem, var_auto_** dirs were not
   removed from the tmpfs location.
Both problems were caused by vardir being expanded to real path
too early, in two different places in the script code
2015-03-09 15:27:58 +02:00
Sergei Golubchik
17a37796e1 after innodb/xtradb merge: use the correct visibility for internal functions
otherwise innodb plugin might invoke xtradb function with the same name,
and that might crash (./mtr --emb innodb.strict_mode)
2015-03-06 18:13:06 +01:00
Sergei Golubchik
d7d19071d2 MDEV-6838 Using too big key for internal temp tables
update test results after the fix
2015-03-06 17:03:46 +01:00
Sergei Golubchik
12d87c3ba5 MDEV-7659 buildbot may leave stale mysqld
safe_process puts its children (mysqld, in this case) into a separate
process group, to be able to kill it all at once.

buildslave kills mtr's process group when it loses connection to
the master.

result? buildslave kills mtr and safe_process, but leaves stale
mysqld processes in their own process groups.

fix: put safe_process itself into a separate process group, then
buildslave won't kill it and safe_process will kill mysqld'd
and itself when it will notice that the parent mtr no longer exists.
2015-03-06 11:15:55 +01:00
Jan Lindström
206b111b11 MDEV-7672: Crash creating an InnoDB table with foreign keys
Analysis: after a red-black-tree lookup we use node withouth
checking did lookup succeed or not. This lead to situation
where NULL-pointer was used.

Fix: Add additional check that found node from red-back-tree
is valid.
2015-03-06 11:19:23 +02:00
Jan Lindström
f66fbe8ce0 MDEV-7578 :Slave is ~10x slower to execute set of statements compared to master when using RBR
Analysis: On master when executing (single/multi) row INSERTs/REPLACEs
InnoDB fallback to old style autoinc locks (table locks)
only if another transaction has already acquired the AUTOINC lock.
Instead on slave as we are executing log_events and sql_command
is not correctly set, InnoDB does not use new style autoinc
locks when it could.

Fix: Use new style autoinc locks also when
thd_sql_command(user_thd) == SQLCOM_END i.e. this is RBR event.
2015-03-05 12:05:59 +02:00
Rik Prohaska
51b68e4379 DB-823 test case for lock tables + alter table conversion from innodb to tokudb failure 2015-03-04 15:53:26 -05:00
Rik Prohaska
ad974e3bed DB-811 test case for lock tables + add column schema mismatch bug 2015-03-04 15:52:53 -05:00
Rik Prohaska
7a34080868 DB-806 test case lock tables + create select bug 2015-03-04 15:51:32 -05:00
Rik Prohaska
d71c76041c DB-805 test case lock tables + alter table conversion from innodb to tokudb bug 2015-03-04 15:50:39 -05:00
Rik Prohaska
69d5695c00 DB-823 fix lock tables + transaction accounting for subsequent operations 2015-03-04 15:49:27 -05:00
Annamalai Gurusami
98b18c5971 Bug #20442523 CRASH WHEN CREATE TABLE VIOLATES FOREIGN KEY CONSTRAINT
Problem:

This is a coding mistake during error handling.  When the specified foreign
key constraint is wrong because of data type mismatch, the resulting
foreign key object will not have valid foreign->id (it will be NULL.)

Solution:

While removing the foreign key object from dictionary cache during error
handling, ensure that foreign->id is not null before using it.

rb#8204 approved by Sunny.
2015-03-03 17:57:08 +05:30
Terje Røsten
ffa7ae1c6e BUG#19811871 VERSION NUMBR NOT SHOWN IN LOG WHEN [RE]STARTING 5.6.21 SERVICE WITH SLES11 REPO
Log file directory had too strict access rights, server not able
to write to log file.

Signed-off-by: Terje Røsten <terje.rosten@oracle.com>
2015-03-01 18:22:28 +01:00
Balasubramanian Kandasamy
96348ab821 BUG#20477758 CONFLICTS WHILE INSTALLING COMMUNITY PACKAGES
Due to large version numbers used libmysqlclient-devel packages was
not considered for install. Fixed by removing version check.
2015-03-01 17:56:49 +01:00
Vicențiu Ciorbaru
45b6edb158 MDEV-6838: Using too big key for internal temp tables
This bug manifests due to wrong computation and evaluation of
keyinfo->key_length. The issues were:
* Using table->file->max_key_length() as an absolute value that must not be
  reached for a key, while it represents the maximum number of bytes
  possible for a table key.
* Incorrectly computing the keyinfo->key_length size during
  KEY_PART_INFO creation. The metadata information regarding the key
  such the field length (for strings) was added twice.
2015-02-28 23:58:05 +02:00
Sergei Golubchik
fa87fc733d update tokudb version after merge 2015-02-27 18:28:40 +01:00
Terje Røsten
e02fe87f00 BUG#19811871 VERSION NUMBR NOT SHOWN IN LOG WHEN [RE]STARTING 5.6.21 SERVICE WITH SLES11 REPO
Log file directory had too strict access rights, server not able
to write to log file.

Signed-off-by: Terje Røsten <terje.rosten@oracle.com>
2015-02-27 09:14:35 +01:00
Terje Røsten
1e16303375 BUG#20477758 CONFLICTS WHILE INSTALLING COMMUNITY PACKAGES WHEN MARIADB, LIB FILES INSTALLED
Due to large version numbers used libmysqlclient-devel packages was
not considered for install. Fixed by removing version check.

Signed-off-by: Terje Røsten <terje.rosten@oracle.com>
2015-02-27 09:14:28 +01:00
Balasubramanian Kandasamy
f922bb745a Updated copyright information 2015-02-27 09:13:18 +01:00
Rich Prohaska
591288a512 Merge branch 'master' into releases/tokudb-7.5 2015-02-26 14:51:47 -05:00
Rik Prohaska
135dcf67d8 DB-805 DB-806 the tokudb loader requires a transaction 2015-02-26 13:22:50 -05:00
Chaithra Gopalareddy
08763096cb Bug #19814337 - SERVER CRASHES IN ITEM_FUNC_GROUP_CONCAT::FIX_FIELDS ON
3RD EXECUTION OF PS

Problem:
When order by is by a column number for a group concat function
which has an outer reference, server fails in case of prepared
statements on the third execution

Analysis:
When a group concat function has order by, the fields in order by
are not resolved until execution if the input is a column number.
During execution they get resolved after the temp table gets created.
As a result they will be pointing to temp table fields which are
runtime created objects. This results in dangling pointers leading
to server failure.

Solution:
Reset the pointers for the order by fields to point to the original
arguments after execution as they are invalid.
Done in Item_func_group_concat::cleanup.
2015-02-26 09:59:00 +05:30
Mithun C Y
2e3c2cd362 Bug #20049521: CRASH IN MERGE_BUFFERS FILESORT.C WHEN INNODB WITH ORDER BY.
ISSUE:
------
There can be up to MERGEBUFF2 number of sorted merge chunks,
We need enough buffer space for at least one record from
each merge chunks. If estimates are wrong(very low) and we
allocate buffer space for less than MERGEBUFF2, then we will
have issue in merge_buffers, if actual number of rows to be
sorted is bigger than estimate and external filesort is
chosen.

SOLUTION:
---------
Set number of rows to sort to be at least MERGEBUFF2.
2015-02-25 11:44:19 +05:30
Rik Prohaska
26d530465d Merge branch 'master' into releases/tokudb-7.5 2015-02-24 14:12:51 -05:00
Rik Prohaska
60dd921463 DB-817 fix savepoint release and duplicate savepoint name bug 2015-02-24 14:12:36 -05:00
Rik Prohaska
f3dcb78ec1 DB-817 add a txn method to get the child of the txn if any 2015-02-24 14:09:53 -05:00
Vishal Chaudhary
cd81a71943 Raise version number after cloning 5.5.43 2015-02-24 12:09:58 +01:00
Abdelhak Errami
ab9d79bc1c FT-636: Changes to tokuftdump to show messages and garbage at height and node level on the FT 2015-02-23 10:34:44 -05:00
Kristian Nielsen
b5d6aa5517 MDEV-7310: last_commit_pos_offset set to wrong value after binlog rotate in group commit
When the binlog was rotated due to @@max_binlog_size, the values of the
binlog_shapshot_file and binlog_snapshot_position were inconsistent in case of
non-transactional DML. The position was refering to the old file, while the
filename was of the new file after rotation. This patch makes them consistent
by making sure the position is also refering to the new file.
2015-02-23 13:27:51 +01:00
Chaithra Gopalareddy
674367afd5 Bug#19880368 : GROUP_CONCAT CRASHES AFTER DUMP_LEAF_KEY
Problem:
find_order_by_list does not update the address of order_item
correctly after resolving.

Solution:
Change the ref_by address for a order_by field if its
SUM_FUNC_ITEM to the address of the field present in
all_fields.
2015-02-20 11:04:43 +05:30
Chaithra Gopalareddy
1a5b8122b6 Bug #19612819 : FILESORT: ASSERTION FAILED: POS->FIELD != 0 || POS->ITEM != 0
Problem:
While getting the temp table field for a REF_ITEM
make_sortorder is using the real_item. As a result
server fails later with an assert.

Solution:
Do not use real_item to get the temp table field.
Instead use the REF_ITEM itself as temp table fields
are created for REF_ITEM not the real_item.
2015-02-18 22:28:03 +05:30
Rik Prohaska
96ea639362 Merge branch 'master' into releases/tokudb-7.5 2015-02-18 01:46:23 -05:00
Rik Prohaska
084668af6b DB-814 cleanup trx->sp_level when master txn (trx->all) is retired 2015-02-18 01:46:09 -05:00
Rik Prohaska
629464e75e Merge branch 'master' into releases/tokudb-7.5 2015-02-16 10:46:57 -05:00
Rik Prohaska
bd026f29f9 DB-813 add an interrupt callback to the analyze cursor to allow early termination, plus detect garbage rows during analyze scan 2015-02-16 10:46:46 -05:00
Rik Prohaska
d0fa28aa87 DB-813 add deleted rows count to the cursor interrupt callback. may be useful to count garbage rows. 2015-02-16 10:41:39 -05:00
Sergei Golubchik
fdd6c111c2 MDEV-7419 Function cli_safe_read not exported
Start the client API for low-level protocol access:
* unsigned long mysql_net_read_packet(MYSQL *mysql);
* unsigned long mysql_net_field_length(unsigned char **packet);
2015-02-13 12:57:11 +01:00
Sergei Golubchik
5dce6aa1fe Merge remote-tracking branch 'bzr/5.5' into bb-5.5-merge 2015-02-12 13:14:55 +01:00
Sergei Golubchik
ed839052d7 Merge tag 'tokudb-7.5.5' into bb-5.5-merge 2015-02-12 00:23:21 +01:00
Sergei Golubchik
8e80f91fa3 Merge remote-tracking branch 'mysql/5.5' into bb-5.5-merge @ mysql-5.5.42 2015-02-11 23:50:40 +01:00
Sergei Golubchik
2a1be9cdf8 XtraDB 5.5.41-37.0 2015-02-11 20:40:56 +01:00
Sergei Golubchik
13927f878e percona-server-5.5.41-37.0 2015-02-11 18:32:40 +01:00
Sergei Golubchik
d996dc2997 MDEV-7290 please update MSI installer to include HeidiSQL 9.1 2015-02-11 15:02:15 +01:00
Sergei Golubchik
63108dc9d2 Fix the tree to work in git. Backport corresponing 10.1 changes. 2015-02-10 12:26:21 +01:00