Commit graph

78646 commits

Author SHA1 Message Date
Olivier Bertrand
81e5c5db3b - Fix length when TYPVAL::SetValue_char is called from MYSQLCOL::ReadColumn.
modified:
  storage/connect/tabmysql.cpp
  storage/connect/value.cpp
2013-07-26 00:11:48 +02:00
Olivier Bertrand
9bd94d7f7e - Restore test results to the discovery old way.
(when using NEW_WAY, show create table displays table types unquoted)

modified:
  storage/connect/mysql-test/connect/r/mysql.result
  storage/connect/mysql-test/connect/r/odbc_sqlite3.result
  storage/connect/mysql-test/connect/r/odbc_sqlite3_grant.result
  storage/connect/mysql-test/connect/r/odbc_xls.result
2013-07-25 21:14:49 +02:00
Olivier Bertrand
3bb298d05f - Restore tests to handle the cases that were giving Valgrind warnings.
modified:
  storage/connect/mysql-test/connect/r/mysql.result
  storage/connect/mysql-test/connect/r/odbc_sqlite3.result
  storage/connect/mysql-test/connect/r/odbc_sqlite3_grant.result
  storage/connect/mysql-test/connect/r/odbc_xls.result
  storage/connect/mysql-test/connect/r/pivot.result
  storage/connect/mysql-test/connect/r/xcol.result
  storage/connect/mysql-test/connect/t/mysql.test
  storage/connect/mysql-test/connect/t/pivot.test
  storage/connect/mysql-test/connect/t/xcol.test
2013-07-25 19:15:07 +02:00
Olivier Bertrand
1c5c2c6db9 - Fix a few test in TYPVAL<PSZ> that cause Valgrind warnings
modified:
  storage/connect/value.cpp

- Ignore column comment field in TabColumns because its pointer is flagged
  as invalid by Valgrind (this is a bypass but not a real fix)

modified:
  storage/connect/tabutil.cpp
  storage/connect/value.cpp
2013-07-25 19:09:46 +02:00
Olivier Bertrand
319414398f - Modify discovery to test a new way of adding columns. Currently the
old way is still used if NEW_WAY is not defined.

modified:
  storage/connect/ha_connect.cc
2013-07-25 19:05:57 +02:00
Sergey Vojtovich
e084a2b043 MDEV-4786 - merge 10.0-monty - 10.0
Fixed debian/ubuntu packages build failure.

debian/patches/33_scripts__mysql_create_system_tables__no_test.dpatch:
  tmp_user has now extra column, updated patch accordingly.
2013-07-25 13:42:06 +04:00
Sergey Vojtovich
e33e9825a4 MDEV-4786 - merge 10.0-monty - 10.0
Fixed main.innodb_mysql_sync failure.

TDC_RT_REMOVE_NOT_OWN_KEEP_SHARE is not same as
TDC_RT_REMOVE_NOT_OWN_AND_MARK_NOT_USABLE. Comment in sql_table.cc says:

      Storage engine has requested exclusive lock only for prepare phase
      and we are not under LOCK TABLES.
      Don't mark TABLE_SHARE as old in this case, as this won't allow opening
      of table by other threads during main phase of in-place ALTER TABLE.

At this moment we hold exclusive metadata lock, all we should do
is purge unused TABLE objects.

sql/sql_base.cc:
  Restore 5.6 behavior of TDC_RT_REMOVE_NOT_OWN_KEEP_SHARE.
sql/sql_base.h:
  Restore 5.6 behavior of TDC_RT_REMOVE_NOT_OWN_KEEP_SHARE.
2013-07-25 13:40:18 +04:00
Sergey Vojtovich
9388822c5d MDEV-4786 - merge 10.0-monty - 10.0
Fixed main.mysql--help failure.

mysql-test/r/mysqld--help.result:
  PFS_MAX_RWLOCK_CLASS was raised to 40 during the merge.
2013-07-25 13:37:30 +04:00
Sergey Petrunya
2e13a4c687 Automatic merge 2013-07-24 14:45:47 +04:00
Sergey Vojtovich
a31a371610 MDEV-4786 - merge 10.0-monty - 10.0
Fixed sql_discovery.simple failure.

storage/sequence/sequence.cc:
  Let sequence share class have unique name to avoid collision with other
  classes.
storage/test_sql_discovery/test_sql_discovery.cc:
  Let test_sql_discovery share class have unique name to avoid collision with
  other classes.
2013-07-24 16:51:48 +04:00
Sergey Vojtovich
50aaf5ceb1 MDEV-4786 - merge 10.0-monty - 10.0
Fixed innodb.help_url failure.

mysql-test/suite/innodb/r/help_url.result:
  Accessing discarded tablespace doesn't cause loud error message anymore.
  Use different way to retrieve refman link.
mysql-test/suite/innodb/t/help_url.test:
  Accessing discarded tablespace doesn't cause loud error message anymore.
  Use different way to retrieve refman link.
2013-07-24 16:48:23 +04:00
Sergey Vojtovich
e8d593fbda MDEV-4786 - merge 10.0-monty - 10.0
Fixed connect compilation failure (with ODBC).

storage/connect/odbconn.cpp:
  min/max are not defined by my_global.h anymore, include osutil.h instead.
2013-07-24 16:45:24 +04:00
Sergey Petrunya
be39bcccec Alternative fix for failure in filesort_debug.test.
- Make THD::raise_condition() call push_warning() after set_error_status() call.
  (they seem to have accidentally exchanged in this merge cset:
   sergii@pisem.net-20130721143919-7cltcw2l9g29f983)
- Rollback the patch from two csets before (the one with comment:
   Update filesort_debug.test (see comment #1 in MDEV-4786 for analysis))
2013-07-24 14:43:57 +04:00
Sergey Petrunya
c451c87fb7 Fix testsuite: update tests for mysql-test/t/system_mysql_db_fix*
- As of 10.0.2, MariaDB has mysql.gtid_slave_pos table as system table.
2013-07-24 12:35:18 +04:00
Sergey Petrunya
b40c316fc7 Update filesort_debug.test (see comment #1 in MDEV-4786 for analysis) 2013-07-24 10:05:12 +04:00
Sergey Vojtovich
b2aea91fcb MDEV-4786 - merge 10.0-monty → 10.0
Fixed connect compilation failure.

storage/connect/csort.cpp:
  min/max are not defined by my_global.h anymore, include osutil.h instead.
storage/connect/filamfix.cpp:
  min/max are not defined by my_global.h anymore, include osutil.h instead.
storage/connect/ha_connect.cc:
  Renamed MYSQL_ERROR -> Sql_condition.
  Renamed KEY::key_parts -> KEY::user_defined_key_parts.
  Adjusted connect according to:
  WL#4305 - storage-engine private data area per physical table.
storage/connect/ha_connect.h:
  Adjusted connect according to:
  WL#4305 - storage-engine private data area per physical table.
storage/connect/inihandl.c:
  min/max are not defined by my_global.h anymore, include osutil.h instead.
storage/connect/osutil.h:
  min/max are not defined by my_global.h anymore, define them for C as well.
storage/connect/taboccur.cpp:
  Include server headers before osutil.h to avoid min/max redefinition.
storage/connect/tabpivot.cpp:
  Include server headers before osutil.h to avoid min/max redefinition.
storage/connect/tabtbl.cpp:
  Include server headers before osutil.h to avoid min/max redefinition.
storage/connect/tabxcl.cpp:
  Include server headers before osutil.h to avoid min/max redefinition.
storage/connect/value.cpp:
  min/max are not defined by my_global.h anymore, include osutil.h instead.
  Include server headers before osutil.h to avoid min/max redefinition.
2013-07-23 18:29:16 +04:00
Sergey Vojtovich
84d073848a MDEV-4786 - merge 10.0-monty → 10.0
Fixed test_sql_discovery compilation failure.

storage/test_sql_discovery/mysql-test/archive/discover.rdiff:
  archive.discover result has changed during merge. Adjusted discover.rdiff
  accordingly.
storage/test_sql_discovery/test_sql_discovery.cc:
  Adjusted test_sql_discovery according to:
  WL#4305 - storage-engine private data area per physical table.
2013-07-23 18:03:23 +04:00
Sergey Vojtovich
6069e780dc MDEV-4786 - merge 10.0-monty → 10.0
Fixed sequence compilation failure.

storage/sequence/sequence.cc:
  Adjusted sequence according to:
  WL#4305 - storage-engine private data area per physical table.
2013-07-23 17:38:44 +04:00
Sergey Vojtovich
43946c0888 MDEV4786 - merge 10.0-monty → 10.0
sql/sql_table.cc:
  Removed false assertion that HA_NO_COPY_ON_ALTER is merge specific.
  This flag is used at least by Spider and Connect.
storage/spider/ha_spider.cc:
  Renamed THD::stmt_da -> THD::get_stmt_da().
  Renamed KEY::key_parts -> KEY::user_defined_key_parts.
  Renamed ALTER_* flags -> Alter_info::ALTER_*.
storage/spider/spd_conn.cc:
  Renamed THD::stmt_da -> THD::get_stmt_da().
storage/spider/spd_db_conn.cc:
  Renamed MYSQL_ERROR -> Sql_condition.
  Renamed KEY::key_parts -> KEY::user_defined_key_parts.
storage/spider/spd_db_include.h:
  current_comment_start argument of generate_parition_syntax()
  was removed during merge.
storage/spider/spd_db_mysql.cc:
  Renamed KEY::key_parts -> KEY::user_defined_key_parts.
storage/spider/spd_ping_table.cc:
  Renamed THD::stmt_da -> THD::get_stmt_da().
storage/spider/spd_table.cc:
  Include my_getopt.h so that it exports my_defaults_file and
  my_defaults_extra_file.
  Renamed KEY::key_parts -> KEY::user_defined_key_parts.
2013-07-23 17:22:02 +04:00
Sergei Golubchik
13dca0125a more post-merge fixes:
* update results
* don't force HA_CREATE_DELAY_KEY_WRITE on all temp tables,
  (bad for CREATE ... LIKE) instead imply it in myisam/aria
* restore HA_ERR_TABLE_DEF_CHANGED in archive
* increase the default number of rwlock classes in P_S to fit all our rwlocks
2013-07-21 19:24:20 +02:00
Sergei Golubchik
d1fdb17bfb cosmetic fixes 2013-07-21 16:43:42 +02:00
Sergei Golubchik
b7b5f6f1ab 10.0-monty merge
includes:
* remove some remnants of "Bug#14521864: MYSQL 5.1 TO 5.5 BUGS PARTITIONING"
* introduce LOCK_share, now LOCK_ha_data is strictly for engines
* rea_create_table() always creates .par file (even in "frm-only" mode)
* fix a 5.6 bug, temp file leak on dummy ALTER TABLE
2013-07-21 16:39:19 +02:00
Olivier Bertrand
b7f435f2ff - Fix bug causing connect_assisted_discovery to fail
on some table types (WMI). In add_field a decimal value
  could be specified for columns not being DOUBLE.

modified:
  storage/connect/ha_connect.cc
2013-07-20 19:22:12 +02:00
Sergei Golubchik
5f6380adde 10.0-base merge 2013-07-18 16:46:57 +02:00
unknown
07099b7021 Fix of using uninitialized variadle. 2013-07-18 11:16:18 +03:00
Sergei Golubchik
97e640b9ae 5.5 merge 2013-07-17 21:24:29 +02:00
Sergei Golubchik
c1d6a2d7e1 merge few bug fixes from 5.6 2013-07-17 18:51:12 +02:00
unknown
1b82512914 MDEV-617 LP:671189 - Query cache is not used for tables or databases with dots in their names
test suite added to be sure that bug is fixed
2013-07-18 12:35:00 +03:00
unknown
8a23ae088d MDEV-4647: Valgrind warnings (Conditional jump or move depends on uninitialised value) in Item_equal::fix_fields
Fix to calm down valgrind.
2013-07-17 17:46:16 +03:00
unknown
c7973615e7 Revert of marko.makela@oracle.com-20130430103950-j353faze84zzk9xf for xtradb
(fix of http://bugs.mysql.com/bug.php?id=69623)
2013-07-17 17:03:59 +03:00
unknown
66ec79fc87 Fix for MDEV-4219 A simple select query returns random data (upstream bug#68473)
In the case of loose scan used as input for order by, end_send()
didn't detect correctly that a loose scan was used, and didn't copy
the non-aggregated fields from the temp table used for ORDER BY.
  
The fix uses the fact that the quick select used for sorting is
attached to JOIN::pre_sort_join_tab instead of JOIN::join_tab.
2013-07-17 16:42:13 +03:00
Sergei Golubchik
a5b534a08e merge Percona-Server-5.5.32-rel31.0.tar.gz 2013-07-16 19:30:39 +02:00
Sergei Golubchik
005c7e5421 mysql-5.5.32 merge 2013-07-16 19:09:54 +02:00
Sergei Golubchik
b9f220b45a 5.3 merge 2013-07-16 19:03:06 +02:00
Sergei Golubchik
6bd24f07d4 Percona-Server-5.5.32-rel31.0.tar.gz 2013-07-16 14:55:47 +02:00
unknown
18cb29d432 MDEV-4570 [PATCH] Sys_query_cache_limit initialization depends on initialization in other source files 2013-07-16 15:44:38 +03:00
unknown
097e65625a MDEV-4548 [PATCH] Limit the amount of side-checking done in innodb-zip test 2013-07-16 15:43:43 +03:00
unknown
69ca523810 MDEV-4547 [PATCH] Make REFRESH_* constants to be 64-bit in 32-bit compilation
REFRESH_FAST do not fit in 32 bit
2013-07-16 15:16:38 +03:00
Sergey Petrunya
67e5b7945d Automatic merge 2013-07-16 15:59:30 +04:00
Sergey Petrunya
5c0fa3ad8f Update test results after the last cset. 2013-07-16 17:26:25 +04:00
Sergey Petrunya
947c2bdbc0 MDEV-4782: Valgrind warnings (Conditional jump or move depends on uninitialised value) with InnoDB, semijoin
- in sub_select(): don't call table->file->position() when reading the first record
  produced an error.
2013-07-16 15:57:27 +04:00
unknown
c697aa1f7c MDEV-4546 Perfschema unit tests to return non-zero on failure.
pfs unit test fixed.
2013-07-16 12:26:04 +03:00
unknown
7093049c32 Building libmysqld fixed. 2013-07-16 11:31:06 +03:00
Sergey Petrunya
47c1b04079 MDEV-4778: Incorrect results from Aria/MyISAM SELECT using index with prefix length on TEXT column
Backport the fix olav.sandstaa@sun.com-20101102184747-qfuntqwj021imy9r:
"Fix for Bug#52660 Perf. regr. using ICP for MyISAM on range queries on an index containing TEXT" 
(together with further fixes in that code) into MyISAM and Aria.
2013-07-16 10:56:42 +04:00
Sergey Petrunya
9651a6f574 mdev-4173: Wrong result (extra row) with semijoin=on, joins in outer query, LEFT JOIN in the subquery
Apply the patch from Patryk Pomykalski:
- create_internal_tmp_table_from_heap() will now return information whether
  the last row that we tried to write was a duplicate row.
(mysql-5.6 also has this change)
2013-07-16 09:22:17 +04:00
Sergei Golubchik
33b7d10921 MDEV-4757 Change mysql.slow_log.event_time from TIMESTAMP to TIMESTAMP(6) 2013-07-15 22:50:06 +02:00
Sergei Golubchik
05c0103ad8 in field_conv() don't simply check to->type() == MYSQL_TYPE_BLOB, this
misses GEOMETRY columns.
2013-07-15 21:17:08 +02:00
Sergei Golubchik
8de120e2b9 5.2 merge 2013-07-15 18:32:25 +02:00
Sergei Golubchik
e1c76b80d9 Fixes for innodb suite, merging tests from 5.6.
Includes 5.6 changesets for:
*****
Fix for BUG#13489996 valgrind:conditional jump or move depends on uninitialised values-field_blob.
blob_ptr_size was not initialized properly: remove this variable.
*****
Bug#14021323 CRASH IN FIELD::SET_NULL WHEN INSERTING ROWS TO NEW TABLE
*****
2013-07-15 18:01:22 +02:00
Sergey Petrunya
716a49a19e MDEV-4536, MDEV-4042
- Make JOIN::cleanup(true) also work correctly when the query is KILLed
  after join optimization was started but before a query plan was produced
2013-07-15 18:51:52 +04:00