- Add include/have_rocksdb.inc (TODO: is there any way to have this
file somewhere under storage/rocksdb/mysql-test ?)
- Make rocksdb.test require have_partition.inc because it uses
partitioned tables
- RocksDB uses RTTI (e.g. it uses dynamic_cast)
- mysql-5.6 has RTTI enabled for the whole server, so there's no
conflict.
- MariaDB doesn't have RTTI enabled
So the solution is to enable RTTI for
- RocksDB files
- Parts of MyRocks that interface with RocksDB features that require RTTI.
(If one just enables RTTI for all of MyRocks, they will get a
"undefined reference to `typeinfo for handler'" link error)
The original parameter comes from
commit a869c56d361bb44f46c0efeb11a8f03561676247
write/sync redo log before flushing binlog cache to file
we've already disabled some of that patch in
8cde1d449a
"Add new function my_hash_const_element(), the const equivalent of
my_hash_element()" - comes from facebook/mysql-5.6,
7c869d34b9fa2262b941efd6363a260b7c37948f
(why are table reads/writes/updates collected in ha_statistics?
this structure was intended for table statistics that the engine
reports.. and now it is also used for engine-agnostic statistics
like rows_read, rows_requested, etc?)
commit b5fda565d4bad66f3b5a6432236b96743ccfd323
Author: Steaphan Greene <steaphan@fb.com>
Date: Fri Feb 7 21:34:04 2014 -0800
Add basic atomic_stats type
Summary:
WebScaleSQL Feature: Basic Stats Support
This is a simple class template that implements an atomic stats variable.
The focus is on performance, not accuracy. No set operations are
guaranteed. The other operations are all atomic, so values should not
actually be lost - however, there is no attempt to be consistent in
reading multiple stats, nor any concern that different threads see any
consistent view across multiple stats.
Test Plan:
This has been tested quite a bit in isolation, and no problems have been
found. However, this has never been used in production. Also, a newer,
more sophisticated, version of this is already in development.
It also shows a small perf gain in the larger stats diffs (Table Stats,
User Stats, etc...), when compared to the built-in MySQL atomics.
Reviewers: pivanof
Reviewed By: pivanof
CC: jtolmer, MarkCallaghan, flamingcow, jeremycole, andrew-ford, inaam-rana, liang.guo.752
Differential Revision: https://reviews.facebook.net/D16029
Differential Revision: https://reviews.facebook.net/D16449
copy of
commit 86587affafe77ef555f7c3839839de44f0f203f3
Author: Tian Xia <tianx@fb.com>
Date: Tue Oct 4 10:01:52 2016 -0700
Allow filtering of show commands through admission control
- Fixed compiler warnings
- Removed have_debug.inc from innochecksum_3
- Fixed race condition in innodb_buffer_pool_load
- Fixed merge issue in innodb-bad-key-change.test
- Fixed missing array allocation that could cause
function_defaults_notembedded to fail
- Fixed thread_cache_size_func
