mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2026-05-16 03:47:17 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix bug #31604: server crash when setting slow_query_log_file/global general_log_file variable

Browse source 
Problem: we don't evaluate given expression checking values of the
slow_query_log_file/general_log_file, don't check it for NULL.

Fix: evaluate the expression, check result returned.


mysql-test/r/log_state.result:
  Fix bug #31604: server crash when setting slow_query_log_file/global general_log_file variable
    - test result.
mysql-test/t/log_state.test:
  Fix bug #31604: server crash when setting slow_query_log_file/global general_log_file variable
    - test case.
sql/set_var.cc:
  Fix bug #31604: server crash when setting slow_query_log_file/global general_log_file variable
    - evaluate var->value calling val_str() method;
    - check for null values returned;
    - return proper errors if any.
This commit is contained in:
unknown 2007-10-16 17:19:07 +05:00
commit faf0f9fb21
3 changed files with 50 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
mysql-test/r/log_state.result
View file

@ -175,3 +175,16 @@ SET GLOBAL slow_query_log = ON;
SET GLOBAL READ_ONLY = OFF;
SET GLOBAL general_log = @old_general_log_state;
SET GLOBAL slow_query_log = @old_slow_log_state;
set @old_general_log_file= @@global.general_log_file;
set @old_slow_query_log_file= @@global.slow_query_log_file;
set global general_log_file= concat('/not exiting path/log.maste', 'r');
ERROR 42000: Variable 'general_log_file' can't be set to the value of '/not exiting path/log.master'
set global general_log_file= NULL;
ERROR 42000: Variable 'general_log_file' can't be set to the value of 'NULL'
set global slow_query_log_file= concat('/not exiting path/log.maste', 'r');
ERROR 42000: Variable 'slow_query_log_file' can't be set to the value of '/not exiting path/log.master'
set global slow_query_log_file= NULL;
ERROR 42000: Variable 'slow_query_log_file' can't be set to the value of 'NULL'
set global general_log_file= @old_general_log_file;
set global slow_query_log_file= @old_slow_query_log_file;
End of 5.1 tests