mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-29 10:14:19 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove unused parameter has_dict_mutex of dict_update_statistics_low()

Browse source 
Also delete dict_update_statistics() and rename dict_update_statistics_low()
to dict_update_statistics() because the only thing that distinguished those
two functions was the removed parameter.
This commit is contained in:
Vasil Dimov 2010-11-11 13:11:52 +02:00
parent db054043ac
commit f9c2f7cd01
3 changed files with 7 additions and 44 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
storage/innodb_plugin/dict/dict0dict.c
View file

@ -4213,16 +4213,13 @@ Calculates new estimates for table and index statistics. The statistics
are used in query optimization. */
UNIV_INTERN
void
dict_update_statistics_low(
/*=======================*/
dict_update_statistics(
/*===================*/
dict_table_t* table, /*!< in/out: table */
ibool only_calc_if_missing_stats,/*!< in: only
ibool only_calc_if_missing_stats)/*!< in: only
update/recalc the stats if they have
not been initialized yet, otherwise
do nothing */
ibool has_dict_mutex __attribute__((unused)))
/*!< in: TRUE if the caller has the
dictionary mutex */
{
dict_index_t* index;
ulint sum_of_index_sizes = 0;
@ -4316,22 +4313,6 @@ dict_update_statistics_low(
dict_table_stats_unlock(table, RW_X_LATCH);
}
/*********************************************************************//**
Calculates new estimates for table and index statistics. The statistics
are used in query optimization. */
UNIV_INTERN
void
dict_update_statistics(
/*===================*/
dict_table_t* table, /*!< in/out: table */
ibool only_calc_if_missing_stats)/*!< in: only
update/recalc the stats if they have
not been initialized yet, otherwise
do nothing */
{
dict_update_statistics_low(table, only_calc_if_missing_stats, FALSE);
}
/**********************************************************************//**
Prints info of a foreign key constraint. */
static
@ -4409,9 +4390,7 @@ dict_table_print_low(
ut_ad(mutex_own(&(dict_sys->mutex)));
dict_update_statistics_low(table,
FALSE /* update even if initialized */,
TRUE /* we have the dict mutex */);
dict_update_statistics(table, FALSE /* update even if initialized */);
dict_table_stats_lock(table, RW_S_LATCH);

6
storage/innodb_plugin/dict/dict0load.c
View file

@ -222,10 +222,8 @@ loop:
is no index */
if (dict_table_get_first_index(table)) {
dict_update_statistics_low(
table,
FALSE /* update even if initialized */,
TRUE /* we have the dict mutex */);
dict_update_statistics(table, FALSE /* update
even if initialized */);
}
dict_table_print_low(table);

16
storage/innodb_plugin/include/dict0dict.h
View file

@ -1054,23 +1054,9 @@ Calculates new estimates for table and index statistics. The statistics
are used in query optimization. */
UNIV_INTERN
void
dict_update_statistics_low(
/*=======================*/
dict_table_t* table, /*!< in/out: table */
ibool only_calc_if_missing_stats,/*!< in: only
update/recalc the stats if they have
not been initialized yet, otherwise
do nothing */
ibool has_dict_mutex);/*!< in: TRUE if the caller has the
dictionary mutex */
/*********************************************************************//**
Calculates new estimates for table and index statistics. The statistics
are used in query optimization. */
UNIV_INTERN
void
dict_update_statistics(
/*===================*/
dict_table_t* table, /*!< in/out: table */
dict_table_t* table, /*!< in/out: table */
ibool only_calc_if_missing_stats);/*!< in: only
update/recalc the stats if they have
not been initialized yet, otherwise