mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-15 19:42:28 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDEV-35219 Unexpected ER_DUP_KEY after OPTIMIZE on MyISAM table with vector key

Browse source 
in-engine optimize can break hlindexes. let's fallback to ALTER
This commit is contained in:
Sergei Golubchik 2024-10-23 17:23:30 +02:00
parent 8988decbfe
commit e8cff8e829
3 changed files with 24 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
mysql-test/main/vector2.result
View file

@ -292,3 +292,15 @@ d count(*)
1 2
2 1
drop table t;
#
# MDEV-35219 Unexpected ER_DUP_KEY after OPTIMIZE on MyISAM table with vector key
#
create table t (v vector(1) not null default 0x30303030, vector(v)) engine=myisam;
insert into t () values (),(),(),();
delete from t limit 1;
optimize table t;
Table Op Msg_type Msg_text
test.t optimize note Table does not support optimize, doing recreate + analyze instead
test.t optimize status OK
insert into t select * from t;
drop table t;

10
mysql-test/main/vector2.test
View file

@ -226,3 +226,13 @@ create table t (a int, v vector(1) not null, primary key (a), vector(v));
insert into t values (1,vec_fromtext('[-1]')),(2,vec_fromtext('[1]')),(3,vec_fromtext('[2]'));
select vec_distance_euclidean(v,vec_fromtext('[0]')) d, count(*) from t group by d order by d limit 2;
drop table t;
--echo #
--echo # MDEV-35219 Unexpected ER_DUP_KEY after OPTIMIZE on MyISAM table with vector key
--echo #
create table t (v vector(1) not null default 0x30303030, vector(v)) engine=myisam;
insert into t () values (),(),(),();
delete from t limit 1;
optimize table t;
insert into t select * from t;
drop table t;

3
sql/handler.cc
View file

@ -5534,7 +5534,8 @@ handler::ha_optimize(THD* thd, HA_CHECK_OPT* check_opt)
m_lock_type == F_WRLCK);
mark_trx_read_write();
return optimize(thd, check_opt);
// in-engine optimize can modify rowids, which will break hlindexes
return table->s->hlindexes() ? HA_ADMIN_TRY_ALTER : optimize(thd, check_opt);
}