MDEV-33746 Supply missing override markings

Find and fix missing virtual override markings.  Updates cmake
maintainer flags to include -Wsuggest-override and
-Winconsistent-missing-override.
This commit is contained in:
Dave Gosselin 2024-06-12 09:46:26 -04:00 committed by Dave Gosselin
commit db0c28eff8
306 changed files with 8823 additions and 8796 deletions

View file

@ -185,7 +185,7 @@ class Exception : public std::exception {
virtual int line() const throw() {
return line_;
}
virtual const char *what() const throw() {
const char *what() const throw() override {
return what_;
}
@ -206,7 +206,7 @@ class Error : public Exception {
: Exception(ex) {}
virtual ~Error() throw() = default;
virtual ErrorCode code() const throw() {
ErrorCode code() const throw() override {
return T;
}
};

View file

@ -44,17 +44,17 @@ class GRN_DAT_API IdCursor : public Cursor {
UInt32 limit = MAX_UINT32,
UInt32 flags = 0);
void close();
void close() override;
const Key &next();
const Key &next() override;
UInt32 offset() const {
UInt32 offset() const override {
return offset_;
}
UInt32 limit() const {
UInt32 limit() const override {
return limit_;
}
UInt32 flags() const {
UInt32 flags() const override {
return flags_;
}

View file

@ -38,17 +38,17 @@ class GRN_DAT_API KeyCursor : public Cursor {
UInt32 limit = MAX_UINT32,
UInt32 flags = 0);
void close();
void close() override;
const Key &next();
const Key &next() override;
UInt32 offset() const {
UInt32 offset() const override {
return offset_;
}
UInt32 limit() const {
UInt32 limit() const override {
return limit_;
}
UInt32 flags() const {
UInt32 flags() const override {
return flags_;
}

View file

@ -37,17 +37,17 @@ class GRN_DAT_API PredictiveCursor : public Cursor {
UInt32 limit = MAX_UINT32,
UInt32 flags = 0);
void close();
void close() override;
const Key &next();
const Key &next() override;
UInt32 offset() const {
UInt32 offset() const override {
return offset_;
}
UInt32 limit() const {
UInt32 limit() const override {
return limit_;
}
UInt32 flags() const {
UInt32 flags() const override {
return flags_;
}

View file

@ -38,17 +38,17 @@ class GRN_DAT_API PrefixCursor : public Cursor {
UInt32 limit = MAX_UINT32,
UInt32 flags = 0);
void close();
void close() override;
const Key &next();
const Key &next() override;
UInt32 offset() const {
UInt32 offset() const override {
return offset_;
}
UInt32 limit() const {
UInt32 limit() const override {
return limit_;
}
UInt32 flags() const {
UInt32 flags() const override {
return flags_;
}