mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-19 13:32:33 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

branches/zip: ha_innobase::add_index(): Lock the table before creating

Browse source 
any indexes.  Before this fix, other transactions could see the empty indexes
before we acquired the table lock.
This commit is contained in:
marko 2007-10-18 12:46:14 +00:00
parent 93157fcd32
commit d8de71ffec
1 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
handler/handler0alter.cc
View file

@ -737,6 +737,17 @@ err_exit:
trx->table_id = indexed_table->id;
}
ut_ad(!error);
/* Acquire an exclusive lock on the table
before creating any indexes. */
error = row_merge_lock_table(trx, innodb_table);
if (UNIV_UNLIKELY(error != DB_SUCCESS)) {
goto error_handling;
}
num_created = 0;
/* Create the indexes in SYS_INDEXES and load into dictionary. */
@ -754,7 +765,7 @@ err_exit:
num_created++;
}
ut_ad(!error);
ut_ad(error == DB_SUCCESS);
/* Raise version number of the table to track this table's
definition changes. */
@ -767,13 +778,6 @@ err_exit:
ut_a(trx->n_active_thrs == 0);
ut_a(UT_LIST_GET_LEN(trx->signals) == 0);
error = row_merge_lock_table(trx, innodb_table);
if (UNIV_UNLIKELY(error != DB_SUCCESS)) {
goto error_handling;
}
if (UNIV_UNLIKELY(new_primary)) {
/* A primary key is to be built. Acquire an exclusive
table lock also on the table that is being created. */