mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-18 13:02:28 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Simplify dict_stats_analyze_index_level()

Browse source 
Only allocate n_uniq elements for offsets, instead of index->n_fields.
(Statistics are never computed on spatial indexes, so we never need
to access more fields even in rec_copy_prefix_to_buf().)
This commit is contained in:
Marko Mäkelä 2018-04-30 10:28:50 +03:00
parent 9b1313e849
commit d73241c0a9
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
storage/innobase/dict/dict0stats.cc
View file

@ -1039,10 +1039,10 @@ dict_stats_analyze_index_level(
memset(n_diff, 0x0, n_uniq * sizeof(n_diff[0]));
/* Allocate space for the offsets header (the allocation size at
offsets[0] and the REC_OFFS_HEADER_SIZE bytes), and n_fields + 1,
offsets[0] and the REC_OFFS_HEADER_SIZE bytes), and n_uniq + 1,
so that this will never be less than the size calculated in
rec_get_offsets_func(). */
i = (REC_OFFS_HEADER_SIZE + 1 + 1) + unsigned(index->n_fields);
i = (REC_OFFS_HEADER_SIZE + 1 + 1) + n_uniq;
heap = mem_heap_create((2 * sizeof *rec_offsets) * i);
rec_offsets = static_cast<ulint*>(
@ -1158,8 +1158,7 @@ dict_stats_analyze_index_level(
n_uniq, &heap);
prev_rec = rec_copy_prefix_to_buf(
prev_rec, index,
rec_offs_n_fields(prev_rec_offsets),
prev_rec, index, n_uniq,
&prev_rec_buf, &prev_rec_buf_size);
prev_rec_is_copied = true;
@ -1232,7 +1231,7 @@ dict_stats_analyze_index_level(
btr_pcur_move_to_next_user_rec() will release the
latch on the page that prev_rec is on */
prev_rec = rec_copy_prefix_to_buf(
rec, index, rec_offs_n_fields(rec_offsets),
rec, index, n_uniq,
&prev_rec_buf, &prev_rec_buf_size);
prev_rec_is_copied = true;