mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-16 12:02:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

SHOW CREATE VIEW (TABLE) privilege now reqiere show create privilege

Browse source 
(BUG#4777)


mysql-test/r/view.result:
  fixed SHOW CREATE VIEW privileges requrements
mysql-test/t/view.test:
  fixed SHOW CREATE VIEW privileges requrements
sql/sql_acl.cc:
  fixed command name
This commit is contained in:
unknown 2004-09-17 22:23:59 +03:00
parent 5c42267181
commit d700f3bcca
4 changed files with 24 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
mysql-test/r/view.result
View file

@ -287,41 +287,39 @@ d bigint(20) YES NULL
explain select c from mysqltest.v1; explain select c from mysqltest.v1;
ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table
show create table mysqltest.v1; show create table mysqltest.v1;
ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table ERROR 42000: show create view command denied to user 'mysqltest_1'@'localhost' for table 'v1'
explain select c from mysqltest.v2; explain select c from mysqltest.v2;
ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table
show create table mysqltest.v2; show create table mysqltest.v2;
ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table ERROR 42000: show create view command denied to user 'mysqltest_1'@'localhost' for table 'v2'
explain select c from mysqltest.v3; explain select c from mysqltest.v3;
ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table
show create table mysqltest.v3; show create table mysqltest.v3;
ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table ERROR 42000: show create view command denied to user 'mysqltest_1'@'localhost' for table 'v3'
explain select c from mysqltest.v4; explain select c from mysqltest.v4;
ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table
show create table mysqltest.v4; show create table mysqltest.v4;
ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table ERROR 42000: show create view command denied to user 'mysqltest_1'@'localhost' for table 'v4'
grant select on mysqltest.t1 to mysqltest_1@localhost; grant select on mysqltest.t1 to mysqltest_1@localhost;
explain select c from mysqltest.v1; explain select c from mysqltest.v1;
id select_type table type possible_keys key key_len ref rows Extra id select_type table type possible_keys key key_len ref rows Extra
1 PRIMARY t1 system NULL NULL NULL NULL 0 const row not found 1 PRIMARY t1 system NULL NULL NULL NULL 0 const row not found
show create table mysqltest.v1; show create table mysqltest.v1;
Table Create Table ERROR 42000: show create view command denied to user 'mysqltest_1'@'localhost' for table 'v1'
v1 CREATE VIEW `mysqltest`.`v1` AS select (`mysqltest`.`t1`.`a` + 1) AS `c`,(`mysqltest`.`t1`.`b` + 1) AS `d` from `mysqltest`.`t1`
explain select c from mysqltest.v2; explain select c from mysqltest.v2;
id select_type table type possible_keys key key_len ref rows Extra id select_type table type possible_keys key key_len ref rows Extra
1 PRIMARY <derived2> system NULL NULL NULL NULL 0 const row not found 1 PRIMARY <derived2> system NULL NULL NULL NULL 0 const row not found
2 DERIVED NULL NULL NULL NULL NULL NULL NULL no matching row in const table 2 DERIVED NULL NULL NULL NULL NULL NULL NULL no matching row in const table
show create table mysqltest.v2; show create table mysqltest.v2;
Table Create Table ERROR 42000: show create view command denied to user 'mysqltest_1'@'localhost' for table 'v2'
v2 CREATE ALGORITHM=TEMPTABLE VIEW `mysqltest`.`v2` AS select (`mysqltest`.`t1`.`a` + 1) AS `c`,(`mysqltest`.`t1`.`b` + 1) AS `d` from `mysqltest`.`t1`
explain select c from mysqltest.v3; explain select c from mysqltest.v3;
ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table
show create table mysqltest.v3; show create table mysqltest.v3;
ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table ERROR 42000: show create view command denied to user 'mysqltest_1'@'localhost' for table 'v3'
explain select c from mysqltest.v4; explain select c from mysqltest.v4;
ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table
show create table mysqltest.v4; show create table mysqltest.v4;
ERROR HY000: EXPLAIN/SHOW can not be issued; lacking privileges for underlying table ERROR 42000: show create view command denied to user 'mysqltest_1'@'localhost' for table 'v4'
grant show view on mysqltest.* to mysqltest_1@localhost; grant show view on mysqltest.* to mysqltest_1@localhost;
explain select c from mysqltest.v1; explain select c from mysqltest.v1;
id select_type table type possible_keys key key_len ref rows Extra id select_type table type possible_keys key key_len ref rows Extra

14
mysql-test/t/view.test
View file

@ -267,19 +267,19 @@ show columns from mysqltest.v2;
# but explain/show do not # but explain/show do not
-- error 1345 -- error 1345
explain select c from mysqltest.v1; explain select c from mysqltest.v1;
-- error 1345 -- error 1142
show create table mysqltest.v1; show create table mysqltest.v1;
-- error 1345 -- error 1345
explain select c from mysqltest.v2; explain select c from mysqltest.v2;
-- error 1345 -- error 1142
show create table mysqltest.v2; show create table mysqltest.v2;
-- error 1345 -- error 1345
explain select c from mysqltest.v3; explain select c from mysqltest.v3;
-- error 1345 -- error 1142
show create table mysqltest.v3; show create table mysqltest.v3;
-- error 1345 -- error 1345
explain select c from mysqltest.v4; explain select c from mysqltest.v4;
-- error 1345 -- error 1142
show create table mysqltest.v4; show create table mysqltest.v4;
# allow to see one of underlaing table # allow to see one of underlaing table
@ -288,17 +288,19 @@ grant select on mysqltest.t1 to mysqltest_1@localhost;
connection user1; connection user1;
# EXPLAIN of view on above table works # EXPLAIN of view on above table works
explain select c from mysqltest.v1; explain select c from mysqltest.v1;
-- error 1142
show create table mysqltest.v1; show create table mysqltest.v1;
explain select c from mysqltest.v2; explain select c from mysqltest.v2;
-- error 1142
show create table mysqltest.v2; show create table mysqltest.v2;
# but other EXPLAINs do not # but other EXPLAINs do not
-- error 1345 -- error 1345
explain select c from mysqltest.v3; explain select c from mysqltest.v3;
-- error 1345 -- error 1142
show create table mysqltest.v3; show create table mysqltest.v3;
-- error 1345 -- error 1345
explain select c from mysqltest.v4; explain select c from mysqltest.v4;
-- error 1345 -- error 1142
show create table mysqltest.v4; show create table mysqltest.v4;
# allow to see any view in mysqltest database # allow to see any view in mysqltest database

2
sql/sql_acl.cc
View file

@ -2873,7 +2873,7 @@ err:
else if (want_access & CREATE_VIEW_ACL) else if (want_access & CREATE_VIEW_ACL)
command= "create view"; command= "create view";
else if (want_access & SHOW_VIEW_ACL) else if (want_access & SHOW_VIEW_ACL)
command= "show view"; command= "show create view";
net_printf(thd,ER_TABLEACCESS_DENIED_ERROR, net_printf(thd,ER_TABLEACCESS_DENIED_ERROR,
command, command,
thd->priv_user, thd->priv_user,

10
sql/sql_view.cc
View file

@ -624,16 +624,20 @@ mysql_make_view(File_parser *parser, TABLE_LIST *table)
check rights to run commands (EXPLAIN SELECT & SHOW CREATE) which show check rights to run commands (EXPLAIN SELECT & SHOW CREATE) which show
underlaying tables underlaying tables
*/ */
if ((old_lex->sql_command == SQLCOM_SELECT && old_lex->describe) || if ((old_lex->sql_command == SQLCOM_SELECT && old_lex->describe))
old_lex->sql_command == SQLCOM_SHOW_CREATE)
{ {
if (check_table_access(thd, SELECT_ACL, view_tables, 1) && if (check_table_access(thd, SELECT_ACL, view_tables, 1) &&
check_table_access(thd, SHOW_VIEW_ACL, view_tables, 1)) check_table_access(thd, SHOW_VIEW_ACL, table, 1))
{ {
my_error(ER_VIEW_NO_EXPLAIN, MYF(0)); my_error(ER_VIEW_NO_EXPLAIN, MYF(0));
goto err; goto err;
} }
} }
else if (old_lex->sql_command == SQLCOM_SHOW_CREATE)
{
if (check_table_access(thd, SHOW_VIEW_ACL, table, 0))
goto err;
}
/* move SQL_NO_CACHE & Co to whole query */ /* move SQL_NO_CACHE & Co to whole query */
old_lex->safe_to_cache_query= (old_lex->safe_to_cache_query && old_lex->safe_to_cache_query= (old_lex->safe_to_cache_query &&