mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-16 12:02:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDEV-8919 Wrong result for CAST(9999999999999999999.0)

Browse source
This commit is contained in:
Alexander Barkov 2019-05-17 08:08:11 +04:00
parent cacdcfd0e4
commit d682dc2e70
9 changed files with 276 additions and 71 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

98
mysql-test/main/cast.result
View file

@ -584,6 +584,8 @@ Note 1105 Cast to signed converted positive out-of-range integer to it's negativ
select cast(1.0e+300 as signed int);
cast(1.0e+300 as signed int)
9223372036854775807
Warnings:
Note 1916 Got overflow when converting '1e300' to SIGNED BIGINT. Value truncated
create table t1 select cast(1 as unsigned), cast(1 as signed), cast(1 as double(5,2)), cast(1 as decimal(5,3)), cast("A" as binary), cast("A" as char(100)), cast("2001-1-1" as DATE), cast("2001-1-1" as DATETIME), cast("1:2:3" as TIME);
show create table t1;
Table Create Table
@ -607,8 +609,8 @@ double_val cast_val
-1e30 -9223372036854775808
1e30 9223372036854775807
Warnings:
Warning 1916 Got overflow when converting '-1e30' to INT. Value truncated
Warning 1916 Got overflow when converting '1e30' to INT. Value truncated
Note 1916 Got overflow when converting '-1e30' to SIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '1e30' to SIGNED BIGINT. Value truncated
DROP TABLE t1;
select isnull(date(NULL)), isnull(cast(NULL as DATE));
isnull(date(NULL)) isnull(cast(NULL as DATE))
@ -1283,3 +1285,95 @@ SET sql_mode=DEFAULT;
SELECT CAST(11068046444225730969 AS SIGNED);
CAST(11068046444225730969 AS SIGNED)
-7378697629483820647
#
# MDEV-8919 Wrong result for CAST(9999999999999999999.0)
#
SET sql_mode='';
SELECT CAST(9999999999999999999e0 AS UNSIGNED);
CAST(9999999999999999999e0 AS UNSIGNED)
10000000000000000000
CREATE TABLE t1 (a BIGINT UNSIGNED);
INSERT INTO t1 VALUES (9999999999999999999e0);
SELECT * FROM t1;
a
10000000000000000000
DROP TABLE t1;
SELECT CAST(9999999999999999999.0 AS UNSIGNED);
CAST(9999999999999999999.0 AS UNSIGNED)
9999999999999999999
CREATE TABLE t1 (a BIGINT UNSIGNED);
INSERT INTO t1 VALUES (9999999999999999999.0);
SELECT * FROM t1;
a
9999999999999999999
DROP TABLE t1;
SELECT CAST(-1.0 AS UNSIGNED);
CAST(-1.0 AS UNSIGNED)
0
Warnings:
Warning 1916 Got overflow when converting '-1.0' to UNSIGNED INT. Value truncated
CREATE TABLE t1 (a BIGINT UNSIGNED);
INSERT INTO t1 VALUES (-1.0);
Warnings:
Warning 1264 Out of range value for column 'a' at row 1
SELECT * FROM t1;
a
0
DROP TABLE t1;
SELECT CAST(-1e0 AS UNSIGNED);
CAST(-1e0 AS UNSIGNED)
0
Warnings:
Note 1916 Got overflow when converting '-1' to UNSIGNED BIGINT. Value truncated
CREATE TABLE t1 (a BIGINT UNSIGNED);
INSERT INTO t1 VALUES (-1e0);
Warnings:
Warning 1264 Out of range value for column 'a' at row 1
SELECT * FROM t1;
a
0
DROP TABLE t1;
SELECT CAST(-1e308 AS UNSIGNED);
CAST(-1e308 AS UNSIGNED)
0
Warnings:
Note 1916 Got overflow when converting '-1e308' to UNSIGNED BIGINT. Value truncated
CREATE TABLE t1 (a BIGINT UNSIGNED);
INSERT INTO t1 VALUES (-1e308);
Warnings:
Warning 1264 Out of range value for column 'a' at row 1
SELECT * FROM t1;
a
0
DROP TABLE t1;
SELECT CAST(TIME'-00:00:01.123' AS UNSIGNED);
CAST(TIME'-00:00:01.123' AS UNSIGNED)
0
Warnings:
Note 1916 Got overflow when converting '-00:00:01.123000' to UNSIGNED BIGINT. Value truncated
CREATE TABLE t1 (a BIGINT UNSIGNED);
INSERT INTO t1 VALUES (TIME'-00:00:01.123');
Warnings:
Warning 1264 Out of range value for column 'a' at row 1
SELECT * FROM t1;
a
0
DROP TABLE t1;
CREATE TABLE t1 (a DOUBLE UNSIGNED);
INSERT INTO t1 VALUES (1.9e19);
SELECT CAST(a AS SIGNED), CAST(MIN(a) AS SIGNED) FROM t1;
CAST(a AS SIGNED) CAST(MIN(a) AS SIGNED)
9223372036854775807 9223372036854775807
Warnings:
Note 1916 Got overflow when converting '1.9e19' to SIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '1.9e19' to SIGNED BIGINT. Value truncated
DROP TABLE t1;
CREATE TABLE t1 (a DECIMAL(30,1) UNSIGNED);
INSERT INTO t1 VALUES (1e19);
SELECT a, CAST(a AS SIGNED) FROM t1;
a CAST(a AS SIGNED)
10000000000000000000.0 9223372036854775807
Warnings:
Warning 1916 Got overflow when converting '10000000000000000000.0' to INT. Value truncated
DROP TABLE t1;
SET sql_mode=DEFAULT;

54
mysql-test/main/cast.test
View file

@ -730,3 +730,57 @@ SET sql_mode=DEFAULT;
--echo #
SELECT CAST(11068046444225730969 AS SIGNED);
--echo #
--echo # MDEV-8919 Wrong result for CAST(9999999999999999999.0)
--echo #
SET sql_mode='';
SELECT CAST(9999999999999999999e0 AS UNSIGNED);
CREATE TABLE t1 (a BIGINT UNSIGNED);
INSERT INTO t1 VALUES (9999999999999999999e0);
SELECT * FROM t1;
DROP TABLE t1;
SELECT CAST(9999999999999999999.0 AS UNSIGNED);
CREATE TABLE t1 (a BIGINT UNSIGNED);
INSERT INTO t1 VALUES (9999999999999999999.0);
SELECT * FROM t1;
DROP TABLE t1;
SELECT CAST(-1.0 AS UNSIGNED);
CREATE TABLE t1 (a BIGINT UNSIGNED);
INSERT INTO t1 VALUES (-1.0);
SELECT * FROM t1;
DROP TABLE t1;
SELECT CAST(-1e0 AS UNSIGNED);
CREATE TABLE t1 (a BIGINT UNSIGNED);
INSERT INTO t1 VALUES (-1e0);
SELECT * FROM t1;
DROP TABLE t1;
SELECT CAST(-1e308 AS UNSIGNED);
CREATE TABLE t1 (a BIGINT UNSIGNED);
INSERT INTO t1 VALUES (-1e308);
SELECT * FROM t1;
DROP TABLE t1;
SELECT CAST(TIME'-00:00:01.123' AS UNSIGNED);
CREATE TABLE t1 (a BIGINT UNSIGNED);
INSERT INTO t1 VALUES (TIME'-00:00:01.123');
SELECT * FROM t1;
DROP TABLE t1;
CREATE TABLE t1 (a DOUBLE UNSIGNED);
INSERT INTO t1 VALUES (1.9e19);
SELECT CAST(a AS SIGNED), CAST(MIN(a) AS SIGNED) FROM t1;
DROP TABLE t1;
CREATE TABLE t1 (a DECIMAL(30,1) UNSIGNED);
INSERT INTO t1 VALUES (1e19);
SELECT a, CAST(a AS SIGNED) FROM t1;
DROP TABLE t1;
SET sql_mode=DEFAULT;

42
mysql-test/suite/funcs_1/r/innodb_func_view.result
View file

@ -2473,12 +2473,12 @@ my_time, id FROM t1_values
WHERE select_id = 93 OR select_id IS NULL order by id;
CAST(my_time AS UNSIGNED INTEGER) my_time id
NULL NULL 1
18446744073701165657 -838:59:59 2
0 -838:59:59 2
8385959 838:59:59 3
130000 13:00:00 4
100000 10:00:00 5
Warnings:
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Note 1916 Got overflow when converting '-838:59:59' to UNSIGNED BIGINT. Value truncated
SHOW CREATE VIEW v1;
View Create View character_set_client collation_connection
v1 CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `v1` AS select cast(`t1_values`.`my_time` as unsigned) AS `CAST(my_time AS UNSIGNED INTEGER)`,`t1_values`.`my_time` AS `my_time`,`t1_values`.`id` AS `id` from `t1_values` latin1 latin1_swedish_ci
@ -2487,12 +2487,12 @@ WHERE v1.id IN (SELECT id FROM t1_values
WHERE select_id = 93 OR select_id IS NULL) order by id;
CAST(my_time AS UNSIGNED INTEGER) my_time id
NULL NULL 1
18446744073701165657 -838:59:59 2
0 -838:59:59 2
8385959 838:59:59 3
130000 13:00:00 4
100000 10:00:00 5
Warnings:
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Note 1916 Got overflow when converting '-838:59:59' to UNSIGNED BIGINT. Value truncated
DROP VIEW v1;
@ -2581,15 +2581,14 @@ my_double, id FROM t1_values
WHERE select_id = 89 OR select_id IS NULL order by id;
CAST(my_double AS UNSIGNED INTEGER) my_double id
NULL NULL 1
9223372036854775808 -1.7976931348623e308 2
9223372036854775807 1.7976931348623e308 3
0 -1.7976931348623e308 2
18446744073709551615 1.7976931348623e308 3
0 0 4
18446744073709551615 -1 5
0 -1 5
Warnings:
Warning 1916 Got overflow when converting '-1.7976931348623e308' to INT. Value truncated
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Warning 1916 Got overflow when converting '1.7976931348623e308' to INT. Value truncated
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Note 1916 Got overflow when converting '-1.7976931348623e308' to UNSIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '1.7976931348623e308' to UNSIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '-1' to UNSIGNED BIGINT. Value truncated
SHOW CREATE VIEW v1;
View Create View character_set_client collation_connection
v1 CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `v1` AS select cast(`t1_values`.`my_double` as unsigned) AS `CAST(my_double AS UNSIGNED INTEGER)`,`t1_values`.`my_double` AS `my_double`,`t1_values`.`id` AS `id` from `t1_values` latin1 latin1_swedish_ci
@ -2598,15 +2597,14 @@ WHERE v1.id IN (SELECT id FROM t1_values
WHERE select_id = 89 OR select_id IS NULL) order by id;
CAST(my_double AS UNSIGNED INTEGER) my_double id
NULL NULL 1
9223372036854775808 -1.7976931348623e308 2
9223372036854775807 1.7976931348623e308 3
0 -1.7976931348623e308 2
18446744073709551615 1.7976931348623e308 3
0 0 4
18446744073709551615 -1 5
0 -1 5
Warnings:
Warning 1916 Got overflow when converting '-1.7976931348623e308' to INT. Value truncated
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Warning 1916 Got overflow when converting '1.7976931348623e308' to INT. Value truncated
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Note 1916 Got overflow when converting '-1.7976931348623e308' to UNSIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '1.7976931348623e308' to UNSIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '-1' to UNSIGNED BIGINT. Value truncated
DROP VIEW v1;
@ -2964,8 +2962,8 @@ NULL NULL 1
0 0 4
-1 -1 5
Warnings:
Warning 1916 Got overflow when converting '-1.7976931348623e308' to INT. Value truncated
Warning 1916 Got overflow when converting '1.7976931348623e308' to INT. Value truncated
Note 1916 Got overflow when converting '-1.7976931348623e308' to SIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '1.7976931348623e308' to SIGNED BIGINT. Value truncated
SHOW CREATE VIEW v1;
View Create View character_set_client collation_connection
v1 CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `v1` AS select cast(`t1_values`.`my_double` as signed) AS `CAST(my_double AS SIGNED INTEGER)`,`t1_values`.`my_double` AS `my_double`,`t1_values`.`id` AS `id` from `t1_values` latin1 latin1_swedish_ci
@ -2979,8 +2977,8 @@ NULL NULL 1
0 0 4
-1 -1 5
Warnings:
Warning 1916 Got overflow when converting '-1.7976931348623e308' to INT. Value truncated
Warning 1916 Got overflow when converting '1.7976931348623e308' to INT. Value truncated
Note 1916 Got overflow when converting '-1.7976931348623e308' to SIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '1.7976931348623e308' to SIGNED BIGINT. Value truncated
DROP VIEW v1;

42
mysql-test/suite/funcs_1/r/memory_func_view.result
View file

@ -2474,12 +2474,12 @@ my_time, id FROM t1_values
WHERE select_id = 93 OR select_id IS NULL order by id;
CAST(my_time AS UNSIGNED INTEGER) my_time id
NULL NULL 1
18446744073701165657 -838:59:59 2
0 -838:59:59 2
8385959 838:59:59 3
130000 13:00:00 4
100000 10:00:00 5
Warnings:
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Note 1916 Got overflow when converting '-838:59:59' to UNSIGNED BIGINT. Value truncated
SHOW CREATE VIEW v1;
View Create View character_set_client collation_connection
v1 CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `v1` AS select cast(`t1_values`.`my_time` as unsigned) AS `CAST(my_time AS UNSIGNED INTEGER)`,`t1_values`.`my_time` AS `my_time`,`t1_values`.`id` AS `id` from `t1_values` latin1 latin1_swedish_ci
@ -2488,12 +2488,12 @@ WHERE v1.id IN (SELECT id FROM t1_values
WHERE select_id = 93 OR select_id IS NULL) order by id;
CAST(my_time AS UNSIGNED INTEGER) my_time id
NULL NULL 1
18446744073701165657 -838:59:59 2
0 -838:59:59 2
8385959 838:59:59 3
130000 13:00:00 4
100000 10:00:00 5
Warnings:
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Note 1916 Got overflow when converting '-838:59:59' to UNSIGNED BIGINT. Value truncated
DROP VIEW v1;
@ -2582,15 +2582,14 @@ my_double, id FROM t1_values
WHERE select_id = 89 OR select_id IS NULL order by id;
CAST(my_double AS UNSIGNED INTEGER) my_double id
NULL NULL 1
9223372036854775808 -1.7976931348623e308 2
9223372036854775807 1.7976931348623e308 3
0 -1.7976931348623e308 2
18446744073709551615 1.7976931348623e308 3
0 0 4
18446744073709551615 -1 5
0 -1 5
Warnings:
Warning 1916 Got overflow when converting '-1.7976931348623e308' to INT. Value truncated
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Warning 1916 Got overflow when converting '1.7976931348623e308' to INT. Value truncated
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Note 1916 Got overflow when converting '-1.7976931348623e308' to UNSIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '1.7976931348623e308' to UNSIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '-1' to UNSIGNED BIGINT. Value truncated
SHOW CREATE VIEW v1;
View Create View character_set_client collation_connection
v1 CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `v1` AS select cast(`t1_values`.`my_double` as unsigned) AS `CAST(my_double AS UNSIGNED INTEGER)`,`t1_values`.`my_double` AS `my_double`,`t1_values`.`id` AS `id` from `t1_values` latin1 latin1_swedish_ci
@ -2599,15 +2598,14 @@ WHERE v1.id IN (SELECT id FROM t1_values
WHERE select_id = 89 OR select_id IS NULL) order by id;
CAST(my_double AS UNSIGNED INTEGER) my_double id
NULL NULL 1
9223372036854775808 -1.7976931348623e308 2
9223372036854775807 1.7976931348623e308 3
0 -1.7976931348623e308 2
18446744073709551615 1.7976931348623e308 3
0 0 4
18446744073709551615 -1 5
0 -1 5
Warnings:
Warning 1916 Got overflow when converting '-1.7976931348623e308' to INT. Value truncated
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Warning 1916 Got overflow when converting '1.7976931348623e308' to INT. Value truncated
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Note 1916 Got overflow when converting '-1.7976931348623e308' to UNSIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '1.7976931348623e308' to UNSIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '-1' to UNSIGNED BIGINT. Value truncated
DROP VIEW v1;
@ -2965,8 +2963,8 @@ NULL NULL 1
0 0 4
-1 -1 5
Warnings:
Warning 1916 Got overflow when converting '-1.7976931348623e308' to INT. Value truncated
Warning 1916 Got overflow when converting '1.7976931348623e308' to INT. Value truncated
Note 1916 Got overflow when converting '-1.7976931348623e308' to SIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '1.7976931348623e308' to SIGNED BIGINT. Value truncated
SHOW CREATE VIEW v1;
View Create View character_set_client collation_connection
v1 CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `v1` AS select cast(`t1_values`.`my_double` as signed) AS `CAST(my_double AS SIGNED INTEGER)`,`t1_values`.`my_double` AS `my_double`,`t1_values`.`id` AS `id` from `t1_values` latin1 latin1_swedish_ci
@ -2980,8 +2978,8 @@ NULL NULL 1
0 0 4
-1 -1 5
Warnings:
Warning 1916 Got overflow when converting '-1.7976931348623e308' to INT. Value truncated
Warning 1916 Got overflow when converting '1.7976931348623e308' to INT. Value truncated
Note 1916 Got overflow when converting '-1.7976931348623e308' to SIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '1.7976931348623e308' to SIGNED BIGINT. Value truncated
DROP VIEW v1;

42
mysql-test/suite/funcs_1/r/myisam_func_view.result
View file

@ -2474,12 +2474,12 @@ my_time, id FROM t1_values
WHERE select_id = 93 OR select_id IS NULL order by id;
CAST(my_time AS UNSIGNED INTEGER) my_time id
NULL NULL 1
18446744073701165657 -838:59:59 2
0 -838:59:59 2
8385959 838:59:59 3
130000 13:00:00 4
100000 10:00:00 5
Warnings:
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Note 1916 Got overflow when converting '-838:59:59' to UNSIGNED BIGINT. Value truncated
SHOW CREATE VIEW v1;
View Create View character_set_client collation_connection
v1 CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `v1` AS select cast(`t1_values`.`my_time` as unsigned) AS `CAST(my_time AS UNSIGNED INTEGER)`,`t1_values`.`my_time` AS `my_time`,`t1_values`.`id` AS `id` from `t1_values` latin1 latin1_swedish_ci
@ -2488,12 +2488,12 @@ WHERE v1.id IN (SELECT id FROM t1_values
WHERE select_id = 93 OR select_id IS NULL) order by id;
CAST(my_time AS UNSIGNED INTEGER) my_time id
NULL NULL 1
18446744073701165657 -838:59:59 2
0 -838:59:59 2
8385959 838:59:59 3
130000 13:00:00 4
100000 10:00:00 5
Warnings:
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Note 1916 Got overflow when converting '-838:59:59' to UNSIGNED BIGINT. Value truncated
DROP VIEW v1;
@ -2582,15 +2582,14 @@ my_double, id FROM t1_values
WHERE select_id = 89 OR select_id IS NULL order by id;
CAST(my_double AS UNSIGNED INTEGER) my_double id
NULL NULL 1
9223372036854775808 -1.7976931348623e308 2
9223372036854775807 1.7976931348623e308 3
0 -1.7976931348623e308 2
18446744073709551615 1.7976931348623e308 3
0 0 4
18446744073709551615 -1 5
0 -1 5
Warnings:
Warning 1916 Got overflow when converting '-1.7976931348623e308' to INT. Value truncated
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Warning 1916 Got overflow when converting '1.7976931348623e308' to INT. Value truncated
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Note 1916 Got overflow when converting '-1.7976931348623e308' to UNSIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '1.7976931348623e308' to UNSIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '-1' to UNSIGNED BIGINT. Value truncated
SHOW CREATE VIEW v1;
View Create View character_set_client collation_connection
v1 CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `v1` AS select cast(`t1_values`.`my_double` as unsigned) AS `CAST(my_double AS UNSIGNED INTEGER)`,`t1_values`.`my_double` AS `my_double`,`t1_values`.`id` AS `id` from `t1_values` latin1 latin1_swedish_ci
@ -2599,15 +2598,14 @@ WHERE v1.id IN (SELECT id FROM t1_values
WHERE select_id = 89 OR select_id IS NULL) order by id;
CAST(my_double AS UNSIGNED INTEGER) my_double id
NULL NULL 1
9223372036854775808 -1.7976931348623e308 2
9223372036854775807 1.7976931348623e308 3
0 -1.7976931348623e308 2
18446744073709551615 1.7976931348623e308 3
0 0 4
18446744073709551615 -1 5
0 -1 5
Warnings:
Warning 1916 Got overflow when converting '-1.7976931348623e308' to INT. Value truncated
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Warning 1916 Got overflow when converting '1.7976931348623e308' to INT. Value truncated
Note 1105 Cast to unsigned converted negative integer to it's positive complement
Note 1916 Got overflow when converting '-1.7976931348623e308' to UNSIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '1.7976931348623e308' to UNSIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '-1' to UNSIGNED BIGINT. Value truncated
DROP VIEW v1;
@ -2965,8 +2963,8 @@ NULL NULL 1
0 0 4
-1 -1 5
Warnings:
Warning 1916 Got overflow when converting '-1.7976931348623e308' to INT. Value truncated
Warning 1916 Got overflow when converting '1.7976931348623e308' to INT. Value truncated
Note 1916 Got overflow when converting '-1.7976931348623e308' to SIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '1.7976931348623e308' to SIGNED BIGINT. Value truncated
SHOW CREATE VIEW v1;
View Create View character_set_client collation_connection
v1 CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `v1` AS select cast(`t1_values`.`my_double` as signed) AS `CAST(my_double AS SIGNED INTEGER)`,`t1_values`.`my_double` AS `my_double`,`t1_values`.`id` AS `id` from `t1_values` latin1 latin1_swedish_ci
@ -2980,8 +2978,8 @@ NULL NULL 1
0 0 4
-1 -1 5
Warnings:
Warning 1916 Got overflow when converting '-1.7976931348623e308' to INT. Value truncated
Warning 1916 Got overflow when converting '1.7976931348623e308' to INT. Value truncated
Note 1916 Got overflow when converting '-1.7976931348623e308' to SIGNED BIGINT. Value truncated
Note 1916 Got overflow when converting '1.7976931348623e308' to SIGNED BIGINT. Value truncated
DROP VIEW v1;

34
sql/item.cc
View file

@ -265,6 +265,40 @@ longlong Item::val_int_unsigned_typecast_from_str()
}
longlong Item::val_int_signed_typecast_from_real()
{
double nr= val_real();
if (null_value)
return 0;
Converter_double_to_longlong conv(nr, false);
if (conv.error())
{
THD *thd= current_thd;
push_warning_printf(thd, Sql_condition::WARN_LEVEL_NOTE,
ER_DATA_OVERFLOW, ER_THD(thd, ER_DATA_OVERFLOW),
ErrConvDouble(nr).ptr(), "SIGNED BIGINT");
}
return conv.result();
}
longlong Item::val_int_unsigned_typecast_from_real()
{
double nr= val_real();
if (null_value)
return 0;
Converter_double_to_longlong conv(nr, true);
if (conv.error())
{
THD *thd= current_thd;
push_warning_printf(thd, Sql_condition::WARN_LEVEL_NOTE,
ER_DATA_OVERFLOW, ER_THD(thd, ER_DATA_OVERFLOW),
ErrConvDouble(nr).ptr(), "UNSIGNED BIGINT");
}
return conv.result();
}
longlong Item::val_int_signed_typecast_from_int()
{
longlong value= val_int();

2
sql/item.h
View file

@ -1247,12 +1247,14 @@ public:
}
longlong val_int_unsigned_typecast_from_int();
longlong val_int_unsigned_typecast_from_str();
longlong val_int_unsigned_typecast_from_real();
/**
Get a value for CAST(x AS UNSIGNED).
Huge positive unsigned values are converted to negative complements.
*/
longlong val_int_signed_typecast_from_int();
longlong val_int_signed_typecast_from_real();
/*
This is just a shortcut to avoid the cast. You should still use

32
sql/sql_type.cc
View file

@ -4490,7 +4490,7 @@ void Type_handler_temporal_result::Item_get_date(THD *thd, Item *item,
longlong Type_handler_real_result::
Item_val_int_signed_typecast(Item *item) const
{
return item->val_int_signed_typecast_from_int();
return item->val_int_signed_typecast_from_real();
}
longlong Type_handler_int_result::
@ -4502,7 +4502,7 @@ longlong Type_handler_int_result::
longlong Type_handler_decimal_result::
Item_val_int_signed_typecast(Item *item) const
{
return item->val_int();
return VDec(item).to_longlong(false);
}
longlong Type_handler_temporal_result::
@ -4522,7 +4522,7 @@ longlong Type_handler_string_result::
longlong Type_handler_real_result::
Item_val_int_unsigned_typecast(Item *item) const
{
return item->val_int_unsigned_typecast_from_int();
return item->val_int_unsigned_typecast_from_real();
}
longlong Type_handler_int_result::
@ -4537,6 +4537,32 @@ longlong Type_handler_temporal_result::
return item->val_int_unsigned_typecast_from_int();
}
longlong Type_handler_time_common::
Item_val_int_unsigned_typecast(Item *item) const
{
/*
TODO: this should eventually be fixed to do rounding
when TIME_ROUND_FRACTIONAL is enabled, together with
Field_{tiny|short|long|longlong}::store_time_dec().
See MDEV-19502.
*/
THD *thd= current_thd;
Time tm(thd, item);
DBUG_ASSERT(!tm.is_valid_time() == item->null_value);
if (!tm.is_valid_time())
return 0;
longlong res= tm.to_longlong();
if (res < 0)
{
push_warning_printf(thd, Sql_condition::WARN_LEVEL_NOTE,
ER_DATA_OVERFLOW, ER_THD(thd, ER_DATA_OVERFLOW),
ErrConvTime(tm.get_mysql_time()).ptr(),
"UNSIGNED BIGINT");
return 0;
}
return res;
}
longlong Type_handler_string_result::
Item_val_int_unsigned_typecast(Item *item) const
{

1
sql/sql_type.h
View file

@ -5199,6 +5199,7 @@ public:
int Item_save_in_field(Item *item, Field *field, bool no_conversions) const;
String *print_item_value(THD *thd, Item *item, String *str) const;
Item_cache *Item_get_cache(THD *thd, const Item *item) const;
longlong Item_val_int_unsigned_typecast(Item *item) const;
bool Item_hybrid_func_fix_attributes(THD *thd,
const char *name,
Type_handler_hybrid_field_type *,