From 85111f0a953aaecdd4dc70e7a4a77cd91d0e89fd Mon Sep 17 00:00:00 2001
From: "mhansson@dl145s.mysql.com" <>
Date: Wed, 23 May 2007 14:43:06 +0200
Subject: [PATCH] Bug #28250: Run-Time Check Failure #3 - The variable 'value'
 is being used without being def

Inside method Item_func_unsigned::val_int, the variable value
can be returned without being initialized when the CAST argument
is of type DECIMAL and has a NULL value. This gives a run-time
error when building debug binaries using Visual C++ 2005.

Solution: Initialize value to 0
---
 mysql-test/t/cast.test | 8 +++++++-
 sql/item_func.cc       | 2 ++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/mysql-test/t/cast.test b/mysql-test/t/cast.test
index 004ef69182d..b665eb86656 100644
--- a/mysql-test/t/cast.test
+++ b/mysql-test/t/cast.test
@@ -10,7 +10,13 @@ select cast(-5 as unsigned) -1, cast(-5 as unsigned) + 1;
 select ~5, cast(~5 as signed);
 explain extended select ~5, cast(~5 as signed);
 select cast(5 as unsigned) -6.0;
-select cast(NULL as signed), cast(1/0 as signed); 
+select cast(NULL as signed), cast(1/0 as signed);
+#
+# Bug #28250: Run-Time Check Failure #3 - The variable 'value' is being used 
+# without being def
+# 
+# The following line causes Run-Time Check Failure on 
+# binaries built with Visual C++ 2005
 select cast(NULL as unsigned), cast(1/0 as unsigned); 
 select cast("A" as binary) = "a", cast(BINARY "a" as CHAR) = "A";
 select cast("2001-1-1" as DATE), cast("2001-1-1" as DATETIME);
diff --git a/sql/item_func.cc b/sql/item_func.cc
index c0a9647e382..2a081add234 100644
--- a/sql/item_func.cc
+++ b/sql/item_func.cc
@@ -996,6 +996,8 @@ longlong Item_func_unsigned::val_int()
     my_decimal tmp, *dec= args[0]->val_decimal(&tmp);
     if (!(null_value= args[0]->null_value))
       my_decimal2int(E_DEC_FATAL_ERROR, dec, 1, &value);
+    else
+      value= 0;
     return value;
   }
   else if (args[0]->cast_to_int_type() != STRING_RESULT ||