mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2026-05-14 19:07:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Bug#48295: explain extended crash with subquery and ONLY_FULL_GROUP_BY sql

Browse source 
If an outer query is broken, a subquery might not even get set up.
EXPLAIN EXTENDED did not expect this and merrily tried to de-ref all
of the half-setup info.

We now catch this case and print as much as we have, as it doesn't cost us
anything (doesn't make regular execution slower).

backport from 5.1

mysql-test/r/explain.result:
  Show that EXPLAIN EXTENDED with subquery and illegal out query doesn't crash.
  Show also that SHOW WARNINGS will render an additional Note in the hope of
  being, well, helpful.
mysql-test/t/explain.test:
  If we have only half a query for EXPLAIN EXTENDED to print (i.e.,
  incomplete subquery info as outer query is illegal), we should
  provide the user with as much info as we easily can if they ask
  for it. What we should not do is crash when they come asking for
  help, that violates etiquette in some countries.
sql/item_subselect.cc:
  If the sub-query's actually set up, print it. Otherwise, elide.
This commit is contained in:
Tatiana A. Nurnberg 2010-03-02 18:00:53 +00:00
commit c610e9783a
3 changed files with 46 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
sql/item_subselect.cc
View file

@ -262,9 +262,14 @@ void Item_subselect::update_used_tables()
void Item_subselect::print(String *str)
{
str->append('(');
engine->print(str);
str->append(')');
if (engine)
{
str->append('(');
engine->print(str);
str->append(')');
}
else
str->append("(...)");
}