mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-17 20:42:30 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

BUG#8786 - ndb_autodiscover, post review

Browse source 
More explicit naming of variables


ndb/include/kernel/signaldata/AlterIndx.hpp:
  Add union to indicate where master node is passed in ref
ndb/include/kernel/signaldata/BuildIndx.hpp:
  Add union to indicate where master node is passed in ref
ndb/include/kernel/signaldata/CreateIndx.hpp:
  Add union to indicate where master node is passed in ref
ndb/include/kernel/signaldata/CreateTrig.hpp:
  Add union to indicate where master node is passed in ref
ndb/include/kernel/signaldata/DropIndx.hpp:
  Add union to indicate where master node is passed in ref
ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
  Set error/master node also on BuildIndxRef
ndb/src/ndbapi/NdbDictionaryImpl.cpp:
  Use masterNodeId instead of errornode
This commit is contained in:
unknown 2005-02-25 09:10:35 +01:00
parent 6b38100d61
commit b89feadf56
7 changed files with 21 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ndb/include/kernel/signaldata/AlterIndx.hpp
View file

@ -201,8 +201,10 @@ private:
//Uint32 m_indexVersion;
Uint32 m_errorCode;
Uint32 m_errorLine;
Uint32 m_errorNode;
union {
Uint32 m_errorNode;
Uint32 masterNodeId; // if NotMaster
};
public:
AlterIndxConf* getConf() {
return &m_conf;

4
ndb/include/kernel/signaldata/BuildIndx.hpp
View file

@ -242,9 +242,8 @@ public:
AllocationFailure = 4252,
InternalError = 4346
};
STATIC_CONST( SignalLength = BuildIndxConf::SignalLength + 1 );
STATIC_CONST( SignalLength = BuildIndxConf::SignalLength + 2 );
private:
//Uint32 m_userRef;
//Uint32 m_connectionPtr;
//Uint32 m_requestInfo;
@ -253,6 +252,7 @@ private:
//Uint32 m_indexId;
BuildIndxConf m_conf;
Uint32 m_errorCode;
Uint32 masterNodeId;
public:
BuildIndxConf* getConf() {

6
ndb/include/kernel/signaldata/CreateIndx.hpp
View file

@ -220,8 +220,10 @@ public:
//Uint32 m_indexVersion;
Uint32 m_errorCode;
Uint32 m_errorLine;
Uint32 m_errorNode;
union {
Uint32 m_errorNode;
Uint32 masterNodeId; // If NotMaster
};
public:
CreateIndxConf* getConf() {
return &m_conf;

6
ndb/include/kernel/signaldata/CreateTrig.hpp
View file

@ -311,8 +311,10 @@ private:
//Uint32 m_triggerInfo;
Uint32 m_errorCode;
Uint32 m_errorLine;
Uint32 m_errorNode;
union {
Uint32 m_errorNode;
Uint32 masterNodeId; // When NotMaster
};
public:
CreateTrigConf* getConf() {
return &m_conf;

6
ndb/include/kernel/signaldata/DropIndx.hpp
View file

@ -185,8 +185,10 @@ public:
//Uint32 m_indexVersion;
Uint32 m_errorCode;
Uint32 m_errorLine;
Uint32 m_errorNode;
union {
Uint32 m_errorNode;
Uint32 masterNodeId;
};
public:
DropIndxConf* getConf() {
return &m_conf;

1
ndb/src/kernel/blocks/dbdict/Dbdict.cpp
View file

@ -10237,6 +10237,7 @@ Dbdict::buildIndex_sendReply(Signal* signal, OpBuildIndexPtr opPtr,
rep->setIndexId(opPtr.p->m_request.getIndexId());
if (sendRef) {
rep->setErrorCode(opPtr.p->m_errorCode);
rep->masterNodeId = opPtr.p->m_errorNode;
gsn = GSN_BUILDINDXREF;
length = BuildIndxRef::SignalLength;
}

4
ndb/src/ndbapi/NdbDictionaryImpl.cpp
View file

@ -2123,7 +2123,7 @@ NdbDictInterface::execCREATE_INDX_REF(NdbApiSignal * signal,
const CreateIndxRef* const ref = CAST_CONSTPTR(CreateIndxRef, signal->getDataPtr());
m_error.code = ref->getErrorCode();
if(m_error.code == ref->NotMaster)
m_masterNodeId= ref->m_errorNode;
m_masterNodeId= ref->masterNodeId;
m_waiter.signal(NO_WAIT);
}
@ -2249,7 +2249,7 @@ NdbDictInterface::execDROP_INDX_REF(NdbApiSignal * signal,
const DropIndxRef* const ref = CAST_CONSTPTR(DropIndxRef, signal->getDataPtr());
m_error.code = ref->getErrorCode();
if(m_error.code == ref->NotMaster)
m_masterNodeId= ref->m_errorNode;
m_masterNodeId= ref->masterNodeId;
m_waiter.signal(NO_WAIT);
}