mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 20:12:31 +01:00
bug: ha_heap was unilaterally increasing reclength
MEMORY engine needs the record length to be at least sizeof(void*), because it stores a pointer there (linking deleted records into a list). So when the reclength is less than sizeof(void*), it's set to sizeof(void*). That is done inside heap_create(), and the upper layer doesn't know that the engine writes beyond share->reclength. While it's usually safe (in-memory record size is rounded up to sizeof(double), so even if share->reclength is too small, share->rec_buff_len is not), it could cause problems in the code that copies records and expects them to fix in share->reclength, e.g. in partitioning.
This commit is contained in:
parent
444587d8a3
commit
b80fa4000d
1 changed files with 1 additions and 0 deletions
|
@ -100,6 +100,7 @@ const char **ha_heap::bas_ext() const
|
|||
|
||||
int ha_heap::open(const char *name, int mode, uint test_if_locked)
|
||||
{
|
||||
set_if_bigger(table->s->reclength, sizeof (uchar*));
|
||||
internal_table= test(test_if_locked & HA_OPEN_INTERNAL_TABLE);
|
||||
if (internal_table || (!(file= heap_open(name, mode)) && my_errno == ENOENT))
|
||||
{
|
||||
|
|
Loading…
Reference in a new issue