mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2026-05-16 20:07:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

MDEV-27398 DESC index causes wrong (empty) result on Federated tables

Browse source 
take descending indexes into account when generating a query
This commit is contained in:
Sergei Golubchik 2022-01-01 17:20:52 +01:00
commit b18697fd3e
3 changed files with 61 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

33
mysql-test/suite/federated/indexes.result Normal file
View file

@ -0,0 +1,33 @@
#
# MDEV-27398 DESC index causes wrong (empty) result on Federated tables
#
create table t (a int);
insert into t values (1),(5),(2),(3),(4);
create table tf (a int, key(a desc)) connection 'mysql://root@127.0.0.1:$MASTER_MYPORT/test/t' engine=Federated;
select * from tf;
a
1
2
3
4
5
select * from tf where a > 2;
a
3
4
5
select * from tf where a < 3;
a
1
2
select * from tf where a >= 3;
a
3
4
5
select * from tf where a <= 3;
a
1
2
3
drop table tf, t;

22
mysql-test/suite/federated/indexes.test Normal file
View file

@ -0,0 +1,22 @@
--source include/not_embedded.inc
--source suite/federated/have_federatedx.inc
--echo #
--echo # MDEV-27398 DESC index causes wrong (empty) result on Federated tables
--echo #
create table t (a int);
insert into t values (1),(5),(2),(3),(4);
--evalp create table tf (a int, key(a desc)) connection 'mysql://root@127.0.0.1:$MASTER_MYPORT/test/t' engine=Federated
--sorted_result
select * from tf;
--sorted_result
select * from tf where a > 2;
--sorted_result
select * from tf where a < 3;
--sorted_result
select * from tf where a >= 3;
--sorted_result
select * from tf where a <= 3;
drop table tf, t;

11
storage/federatedx/ha_federatedx.cc
View file

@ -1261,6 +1261,7 @@ bool ha_federatedx::create_where_from_key(String *to,
uint store_length= key_part->store_length;
uint part_length= MY_MIN(store_length, length);
bool needs_quotes= field->str_needs_quotes();
bool reverse= key_part->key_part_flag & HA_REVERSE_SORT;
static const LEX_CSTRING lt={STRING_WITH_LEN(" < ") };
static const LEX_CSTRING gt={STRING_WITH_LEN(" > ") };
static const LEX_CSTRING le={STRING_WITH_LEN(" <= ") };
@ -1338,12 +1339,12 @@ bool ha_federatedx::create_where_from_key(String *to,
if (i > 0) /* end key */
{
if (tmp.append(le))
if (tmp.append(reverse ? ge : le))
goto err;
}
else /* start key */
{
if (tmp.append(gt))
if (tmp.append(reverse ? lt : gt))
goto err;
}
@ -1358,7 +1359,7 @@ bool ha_federatedx::create_where_from_key(String *to,
case HA_READ_KEY_OR_NEXT:
DBUG_PRINT("info", ("federatedx HA_READ_KEY_OR_NEXT %d", i));
if (emit_key_part_name(&tmp, key_part) ||
tmp.append(ge) ||
tmp.append(reverse ? le : ge) ||
emit_key_part_element(&tmp, key_part, needs_quotes, 0, ptr,
part_length))
goto err;
@ -1368,7 +1369,7 @@ bool ha_federatedx::create_where_from_key(String *to,
if (store_length >= length)
{
if (emit_key_part_name(&tmp, key_part) ||
tmp.append(lt) ||
tmp.append(reverse ? gt : lt) ||
emit_key_part_element(&tmp, key_part, needs_quotes, 0, ptr,
part_length))
goto err;
@ -1378,7 +1379,7 @@ bool ha_federatedx::create_where_from_key(String *to,
case HA_READ_KEY_OR_PREV:
DBUG_PRINT("info", ("federatedx HA_READ_KEY_OR_PREV %d", i));
if (emit_key_part_name(&tmp, key_part) ||
tmp.append(le) ||
tmp.append(reverse ? ge : le) ||
emit_key_part_element(&tmp, key_part, needs_quotes, 0, ptr,
part_length))
goto err;