mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2026-05-16 20:07:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

MDEV-19514 fixup: Simplify buf_page_read_complete()

Browse source 
False positives for buf_page_t::ibuf_exist are acceptable,
because it does not hurt to unnecessarily invoke
ibuf_merge_or_delete_for_page().

Invoking buf_page_get_gen() in a read completion function
is a definite no-no, because it could trigger a page flush
or cause the server to run out of buffer pool.

With some MDEV-23855 changes present, the test innodb.purge_secondary
occasionally failed due to the table having been dropped while
ibuf_page_exists() invoked buf_page_get_gen().

Reviewed by: Thirunarayanan Balathandayuthapani
This commit is contained in:
Marko Mäkelä 2020-10-15 13:27:09 +03:00
commit abb678b618
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
storage/innobase/buf/buf0buf.cc
View file

@ -4325,7 +4325,7 @@ release_page:
if (bpage->state() == BUF_BLOCK_FILE_PAGE && !recv_no_ibuf_operations &&
(!id.space() || !is_predefined_tablespace(id.space())) &&
fil_page_get_type(frame) == FIL_PAGE_INDEX &&
page_is_leaf(frame) && ibuf_page_exists(id, bpage->zip_size()))
page_is_leaf(frame))
bpage->ibuf_exist= true;
if (UNIV_UNLIKELY(MONITOR_IS_ON(MONITOR_MODULE_BUF_PAGE)))