mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2026-05-07 07:35:32 +02:00
Code Issues Projects Releases Packages Wiki Activity

MDEV-16264: Remove IORequest::IGNORE_MISSING

Browse source 
After MDEV-11556, not even crash recovery should attempt to access
non-existing pages. But, buf_load() is not validating its input
and must thus be able to ignore missing pages, so that is why
buf_read_page_background() does that.
This commit is contained in:
Marko Mäkelä 2019-11-15 19:55:40 +02:00
commit a69cff295c
4 changed files with 19 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

20
storage/innobase/include/os0file.h
View file

@ -215,12 +215,8 @@ public:
/** Disable partial read warnings */
DISABLE_PARTIAL_IO_WARNINGS = 32,
/** Ignore failed reads of non-existent pages */
IGNORE_MISSING = 128,
/** Use punch hole if available*/
PUNCH_HOLE = 256,
PUNCH_HOLE = 64,
};
/** Default constructor */
@ -269,13 +265,6 @@ public:
/** Destructor */
~IORequest() { }
/** @return true if ignore missing flag is set */
static bool ignore_missing(ulint type)
MY_ATTRIBUTE((warn_unused_result))
{
return((type & IGNORE_MISSING) == IGNORE_MISSING);
}
/** @return true if it is a read request */
bool is_read() const
MY_ATTRIBUTE((warn_unused_result))
@ -317,13 +306,6 @@ public:
m_type |= DISABLE_PARTIAL_IO_WARNINGS;
}
/** @return true if missing files should be ignored */
bool ignore_missing() const
MY_ATTRIBUTE((warn_unused_result))
{
return(ignore_missing(m_type));
}
/** @return true if punch hole should be used */
bool punch_hole() const
MY_ATTRIBUTE((warn_unused_result))