mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-27 01:04:19 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Added more information to errors reported by report_reply_packet()

Browse source 
In particular ""Read semi-sync reply magic number error" now prints out
what was wrong with the packet.

Reviewed-by: Sergei Golubchik <serg@mariadb.org>
This commit is contained in:
Monty 2024-12-04 11:31:00 +02:00
parent 996e7fd7d5
commit a0bfdef5e6
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
sql/semisync_master.cc
View file

@ -608,13 +608,17 @@ int Repl_semi_sync_master::report_reply_packet(uint32 server_id,
DBUG_RETURN(-1); DBUG_RETURN(-1);
} }
else else
sql_print_error("Read semi-sync reply magic number error"); sql_print_error("Read semi-sync reply magic number error. "
"Got magic: %u command %u length: %lu",
(uint) packet[REPLY_MAGIC_NUM_OFFSET], (uint) packet[0],
packet_len);
goto l_end; goto l_end;
} }
if (unlikely(packet_len < REPLY_BINLOG_NAME_OFFSET)) if (unlikely(packet_len < REPLY_BINLOG_NAME_OFFSET))
{ {
sql_print_error("Read semi-sync reply length error: packet is too small"); sql_print_error("Read semi-sync reply length error: packet is too small: %lu",
packet_len);
goto l_end; goto l_end;
} }
@ -622,7 +626,8 @@ int Repl_semi_sync_master::report_reply_packet(uint32 server_id,
log_file_len = packet_len - REPLY_BINLOG_NAME_OFFSET; log_file_len = packet_len - REPLY_BINLOG_NAME_OFFSET;
if (unlikely(log_file_len >= FN_REFLEN)) if (unlikely(log_file_len >= FN_REFLEN))
{ {
sql_print_error("Read semi-sync reply binlog file length too large"); sql_print_error("Read semi-sync reply binlog file length too large: %llu",
(ulonglong) log_file_pos);
goto l_end; goto l_end;
} }
strncpy(log_file_name, (const char*)packet + REPLY_BINLOG_NAME_OFFSET, log_file_len); strncpy(log_file_name, (const char*)packet + REPLY_BINLOG_NAME_OFFSET, log_file_len);