mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-27 09:14:17 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDEV-31095 tpool - do not create new worker, if thread creation is pending.

Browse source 
Use an std::atomic_flag to track thread creation in progress.
This is mainly a cleanup, the effect of this change was not measureable
in my tests.
This commit is contained in:
Vladislav Vaintroub 2023-04-25 14:24:39 +02:00 • committed by Vladislav Vaintroub
parent e33e2fa949
commit 9e62ab7aaf
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tpool/tpool_generic.cc
View file

@ -278,6 +278,7 @@ class thread_pool_generic : public thread_pool
/* maintenance related statistics (see maintenance()) */ /* maintenance related statistics (see maintenance()) */
size_t m_last_thread_count; size_t m_last_thread_count;
unsigned long long m_last_activity; unsigned long long m_last_activity;
std::atomic_flag m_thread_creation_pending= ATOMIC_FLAG_INIT;
void worker_main(worker_data *thread_data); void worker_main(worker_data *thread_data);
void worker_end(worker_data* thread_data); void worker_end(worker_data* thread_data);
@ -575,6 +576,7 @@ void thread_pool_generic::worker_main(worker_data *thread_var)
m_worker_init_callback(); m_worker_init_callback();
tls_worker_data = thread_var; tls_worker_data = thread_var;
m_thread_creation_pending.clear();
while (get_task(thread_var, &task) && task) while (get_task(thread_var, &task) && task)
{ {
@ -720,11 +722,13 @@ static int throttling_interval_ms(size_t n_threads,size_t concurrency)
/* Create a new worker.*/ /* Create a new worker.*/
bool thread_pool_generic::add_thread() bool thread_pool_generic::add_thread()
{ {
if (m_thread_creation_pending.test_and_set())
return false;
size_t n_threads = thread_count(); size_t n_threads = thread_count();
if (n_threads >= m_max_threads) if (n_threads >= m_max_threads)
return false; return false;
if (n_threads >= m_min_threads) if (n_threads >= m_min_threads)
{ {
auto now = std::chrono::system_clock::now(); auto now = std::chrono::system_clock::now();