mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-16 03:52:35 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDEV-25606: Concurrent CREATE TRIGGER statements mix up in binlog and break replication

Browse source 
The bug is that we don't have a a lock on the trigger name, so it is
possible for two threads to try to create the same trigger at the same
time and both thinks that they have succeed.
Same thing can happen with drop trigger or a combinations of create and
drop trigger.

Fixed by adding a mdl lock for the trigger name for the duration of the
create/drop.
This commit is contained in:
Monty 2021-05-10 18:36:13 +03:00 committed by Oleksandr Byelkin
parent 81ad6787cc
commit 99e14aa592
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sql/sql_trigger.cc
View file

@ -471,7 +471,7 @@ bool mysql_create_or_drop_trigger(THD *thd, TABLE_LIST *tables, bool create)
} }
/* Protect against concurrent create/drop */ /* Protect against concurrent create/drop */
MDL_REQUEST_INIT(&mdl_request_for_trn, MDL_key::TABLE, MDL_REQUEST_INIT(&mdl_request_for_trn, MDL_key::TRIGGER,
create ? tables->db.str : thd->lex->spname->m_db.str, create ? tables->db.str : thd->lex->spname->m_db.str,
thd->lex->spname->m_name.str, thd->lex->spname->m_name.str,
MDL_EXCLUSIVE, MDL_EXPLICIT); MDL_EXCLUSIVE, MDL_EXPLICIT);