From 91e79dff54c00bc46c66c8e0fb73da8552e047d9 Mon Sep 17 00:00:00 2001 From: Sergei Golubchik Date: Sun, 12 Apr 2020 22:11:22 +0200 Subject: [PATCH] cleanup: comments --- sql/sql_insert.cc | 2 -- sql/sql_update.cc | 2 +- storage/myisam/myisamdef.h | 8 ++++---- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/sql/sql_insert.cc b/sql/sql_insert.cc index e99a5804952..2a2b74405f3 100644 --- a/sql/sql_insert.cc +++ b/sql/sql_insert.cc @@ -1996,8 +1996,6 @@ int write_record(THD *thd, TABLE *table, COPY_INFO *info, select_result *sink) tables which have ON UPDATE but have no ON DELETE triggers, we just should not expose this fact to users by invoking ON UPDATE triggers. - For system versioning wa also use path through delete since we would - save nothing through this cheating. */ if (last_uniq_key(table,key_nr) && !table->file->referenced_by_foreign_key() && diff --git a/sql/sql_update.cc b/sql/sql_update.cc index f3ceb50c8c5..0b1313f02ab 100644 --- a/sql/sql_update.cc +++ b/sql/sql_update.cc @@ -2036,7 +2036,7 @@ int multi_update::prepare(List ¬_used_values, DBUG_RETURN(1); /* - Save tables beeing updated in update_tables + Save tables being updated in update_tables update_table->shared is position for table Don't use key read on tables that are updated */ diff --git a/storage/myisam/myisamdef.h b/storage/myisam/myisamdef.h index c5975f42315..281f118b472 100644 --- a/storage/myisam/myisamdef.h +++ b/storage/myisam/myisamdef.h @@ -234,11 +234,11 @@ typedef struct st_mi_isam_share struct st_myisam_info { - MYISAM_SHARE *s; /* Shared between open:s */ + MYISAM_SHARE *s; /* Shared between opens */ MI_STATUS_INFO *state, save_state; MI_BLOB *blobs; /* Pointer to blobs */ MI_BIT_BUFF bit_buff; - /* accumulate indexfile changes between write's */ + /* accumulate indexfile changes between writes */ TREE *bulk_insert; DYNAMIC_ARRAY *ft1_to_ft2; /* used only in ft1->ft2 conversion */ MEM_ROOT ft_memroot; /* used by the parser */ @@ -256,7 +256,7 @@ struct st_myisam_info uint32 int_keytree_version; /* -""- */ int (*read_record)(struct st_myisam_info*, my_off_t, uchar*); invalidator_by_filename invalidator; /* query cache invalidator */ - ulong this_unique; /* uniq filenumber or thread */ + ulong this_unique; /* unique filenumber or thread */ ulong last_unique; /* last unique number */ ulong this_loop; /* counter for this open */ ulong last_loop; /* last used counter */ @@ -269,7 +269,7 @@ struct st_myisam_info my_off_t dupp_key_pos; ha_checksum checksum; /* Temp storage for row checksum */ /* - QQ: the folloing two xxx_length fields should be removed, + QQ: the following two xxx_length fields should be removed, as they are not compatible with parallel repair */ ulong packed_length, blob_length; /* Length of found, packed record */