mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 03:52:35 +01:00
Bug#47768 pthread_cond_timedwait() is broken on windows
The pthread_cond_wait implementations for windows might dead lock in some rare circumstances. 1) One thread (I) enter a timed wait and at a point in time ends up after mutex unlock and before WaitForMultipleObjects(...) 2) Another thread (II) enters pthread_cond_broadcast. Grabs the mutex and discovers one waiter. It set the broadcast event and closes the broadcast gate then unlocks the mutex. 3) A third thread (III) issues a pthread_cond_signal. It grabs the mutex, discovers one waiter, sets the signal event then unlock the mutex. 4) The first threads (I) enters WaitForMultipleObjects and finds out that the signal object is in a signalled state and exits the wait. 5) Thread (I) grabs the mutex and checks result status. The number of waiters is decreased and becomes equal to 0. The event returned was a signal event so the broadcast gate isn't opened. The mutex is released. 6) Thread (II) issues a new broadcast. The mutex is acquired but the number of waiters are 0 hence the broadcast gate remains closed. 7) Thread (I) enters the wait again but is blocked by the broadcast gate. This fix resolves the above issue by always resetting broadcast gate when there are no more waiters in th queue. mysys/my_wincond.c: * Always reset the broadcast gate if there are no more waiters left.
This commit is contained in:
parent
df2122a262
commit
9098e2997b
1 changed files with 1 additions and 1 deletions
|
@ -126,7 +126,7 @@ int pthread_cond_timedwait(pthread_cond_t *cond, pthread_mutex_t *mutex,
|
||||||
EnterCriticalSection(&cond->lock_waiting);
|
EnterCriticalSection(&cond->lock_waiting);
|
||||||
cond->waiting--;
|
cond->waiting--;
|
||||||
|
|
||||||
if (cond->waiting == 0 && result == (WAIT_OBJECT_0+BROADCAST))
|
if (cond->waiting == 0)
|
||||||
{
|
{
|
||||||
/*
|
/*
|
||||||
We're the last waiter to be notified or to stop waiting, so
|
We're the last waiter to be notified or to stop waiting, so
|
||||||
|
|
Loading…
Reference in a new issue