mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-21 22:34:18 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix a data race in debug build (#523)

Browse source 
* fix a data race in debug build
This commit is contained in:
Eugene Kosov 2017-12-25 18:40:06 +03:00 • committed by Sergey Vojtovich
parent 1761e38208
commit 8307fc9d6c
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
storage/innobase/fil/fil0fil.cc
View file

@ -188,19 +188,19 @@ bool
fil_validate_skip(void)
/*===================*/
{
/** The fil_validate() call skip counter. Use a signed type
because of the race condition below. */
/** The fil_validate() call skip counter. */
static int fil_validate_count = FIL_VALIDATE_SKIP;
/* There is a race condition below, but it does not matter,
because this call is only for heuristic purposes. We want to
reduce the call frequency of the costly fil_validate() check
in debug builds. */
if (--fil_validate_count > 0) {
/* We want to reduce the call frequency of the costly fil_validate()
check in debug builds. */
int count = my_atomic_add32_explicit(&fil_validate_count, -1,
MY_MEMORY_ORDER_RELAXED);
if (count > 0) {
return(true);
}
fil_validate_count = FIL_VALIDATE_SKIP;
my_atomic_store32_explicit(&fil_validate_count, FIL_VALIDATE_SKIP,
MY_MEMORY_ORDER_RELAXED);
return(fil_validate());
}
#endif /* UNIV_DEBUG */