mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-17 12:32:27 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add documentation about intricacies of MgmtSrvr::versionNode and ::status

Browse source 
ndb/src/mgmsrv/MgmtSrvr.cpp:
  Document why getOwnNodeID==nodeId is different in ::versionNode
ndb/src/mgmsrv/MgmtSrvr.hpp:
  Document the usage of the address pointer returned from status()
This commit is contained in:
unknown 2005-09-22 21:55:10 +10:00
parent 90b102daa6
commit 7d325ef2b3
2 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ndb/src/mgmsrv/MgmtSrvr.cpp
View file

@ -695,6 +695,16 @@ MgmtSrvr::versionNode(int nodeId, Uint32 &version, const char **address)
version= 0;
if (getOwnNodeId() == nodeId)
{
/**
* If we're inquiring about our own node id,
* We know what version we are (version implies connected for mgm)
* but would like to find out from elsewhere what address they're using
* to connect to us. This means that secondary mgm servers
* can list ip addresses for mgm servers.
*
* If we don't get an address (i.e. no db nodes),
* we get the address from the configuration.
*/
sendVersionReq(nodeId, version, address);
version= NDB_VERSION;
if(!*address)

10
ndb/src/mgmsrv/MgmtSrvr.hpp
View file

@ -201,8 +201,14 @@ public:
~MgmtSrvr();
int status(int processId,
ndb_mgm_node_status * status,
/**
* Get status on a node.
* address may point to a common area (e.g. from inet_addr)
* There is no gaurentee that it is preserved across calls.
* Copy the string if you are not going to use it immediately.
*/
int status(int nodeId,
ndb_mgm_node_status * status,
Uint32 * version,
Uint32 * phase,
bool * systemShutdown,