From ca34c9c925d25fdf393ab0e84508fc4c303c21d7 Mon Sep 17 00:00:00 2001 From: unknown Date: Fri, 19 May 2006 16:08:06 -0400 Subject: [PATCH 1/7] New test case --- mysql-test/t/partition.test | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/mysql-test/t/partition.test b/mysql-test/t/partition.test index 272cdc27af6..d6b96167214 100644 --- a/mysql-test/t/partition.test +++ b/mysql-test/t/partition.test @@ -1009,4 +1009,21 @@ select auto_increment from information_schema.tables where table_name='t1'; select * from t1; drop table t1; +# +# BUG 19122 Crash after ALTER TABLE t1 REBUILD PARTITION p1 +# +create table t1 (a int) +partition by key (a) +(partition p1 engine = innodb); + +alter table t1 rebuild partition p1; +alter table t1 rebuild partition p1; +alter table t1 rebuild partition p1; +alter table t1 rebuild partition p1; +alter table t1 rebuild partition p1; +alter table t1 rebuild partition p1; +alter table t1 rebuild partition p1; + +drop table t1; + --echo End of 5.1 tests From a29e59e00c772f08995d74978a7ded2e8d05c3e9 Mon Sep 17 00:00:00 2001 From: unknown Date: Fri, 26 May 2006 18:44:52 -0400 Subject: [PATCH 2/7] BUG#19122: MySQL Server crashes when ALTER TABLE t1 REBUILD PARTITION on InnoDB table mysql-test/r/partition.result: New test case sql/lock.cc: Added new flag to lock_table_name to ensure we get proper name lock even when we already have lock on table. sql/mysql_priv.h: Added new flag to lock_table_name to ensure we get proper name lock even when we already have lock on table. Added table_list to ALTER_PARTITION_PARAM_TYPE and changed some const char * to char* sql/sql_base.cc: Added new flag to lock_table_name to ensure we get proper name lock even when we already have lock on table. Added table_list to ALTER_PARTITION_PARAM_TYPE and changed some const char * to char* sql/sql_partition.cc: New methods to 1) Get a name lock even when we already have one 2) New method that unlocks table and closes the handlers. 3) Release name lock Integrated those new methods to ensure that handlers are unlocked and closed when drop or rename is called on them. There is still some work to update the comments to reflect the last changes. --- mysql-test/r/partition.result | 11 +++ sql/lock.cc | 45 ++++++---- sql/mysql_priv.h | 7 +- sql/sql_base.cc | 2 +- sql/sql_partition.cc | 159 ++++++++++++++++++++++++++-------- 5 files changed, 170 insertions(+), 54 deletions(-) diff --git a/mysql-test/r/partition.result b/mysql-test/r/partition.result index 0da071374ea..9a430ed39f6 100644 --- a/mysql-test/r/partition.result +++ b/mysql-test/r/partition.result @@ -886,4 +886,15 @@ s1 2 3 drop table t1; +create table t1 (a int) +partition by key (a) +(partition p1 engine = innodb); +alter table t1 rebuild partition p1; +alter table t1 rebuild partition p1; +alter table t1 rebuild partition p1; +alter table t1 rebuild partition p1; +alter table t1 rebuild partition p1; +alter table t1 rebuild partition p1; +alter table t1 rebuild partition p1; +drop table t1; End of 5.1 tests diff --git a/sql/lock.cc b/sql/lock.cc index 5a6cd58dd56..3a0aa99218f 100644 --- a/sql/lock.cc +++ b/sql/lock.cc @@ -828,7 +828,7 @@ int lock_and_wait_for_table_name(THD *thd, TABLE_LIST *table_list) if (wait_if_global_read_lock(thd, 0, 1)) DBUG_RETURN(1); VOID(pthread_mutex_lock(&LOCK_open)); - if ((lock_retcode = lock_table_name(thd, table_list)) < 0) + if ((lock_retcode = lock_table_name(thd, table_list, TRUE)) < 0) goto end; if (lock_retcode && wait_for_locked_table_names(thd, table_list)) { @@ -851,6 +851,7 @@ end: lock_table_name() thd Thread handler table_list Lock first table in this list + check_in_use Do we need to check if table already in use by us WARNING If you are going to update the table, you should use @@ -870,7 +871,7 @@ end: > 0 table locked, but someone is using it */ -int lock_table_name(THD *thd, TABLE_LIST *table_list) +int lock_table_name(THD *thd, TABLE_LIST *table_list, bool check_in_use) { TABLE *table; char key[MAX_DBKEY_LENGTH]; @@ -882,17 +883,22 @@ int lock_table_name(THD *thd, TABLE_LIST *table_list) key_length= create_table_def_key(thd, key, table_list, 0); - /* Only insert the table if we haven't insert it already */ - for (table=(TABLE*) hash_first(&open_cache, (byte*)key, key_length, &state); - table ; - table = (TABLE*) hash_next(&open_cache,(byte*) key,key_length, &state)) + if (check_in_use) { - if (table->in_use == thd) + /* Only insert the table if we haven't insert it already */ + for (table=(TABLE*) hash_first(&open_cache, (byte*)key, + key_length, &state); + table ; + table = (TABLE*) hash_next(&open_cache,(byte*) key, + key_length, &state)) { - DBUG_PRINT("info", ("Table is in use")); - table->s->version= 0; // Ensure no one can use this - table->locked_by_name= 1; - DBUG_RETURN(0); + if (table->in_use == thd) + { + DBUG_PRINT("info", ("Table is in use")); + table->s->version= 0; // Ensure no one can use this + table->locked_by_name= 1; + DBUG_RETURN(0); + } } } /* @@ -917,10 +923,17 @@ int lock_table_name(THD *thd, TABLE_LIST *table_list) my_free((gptr) table,MYF(0)); DBUG_RETURN(-1); } - - /* Return 1 if table is in use */ - DBUG_RETURN(test(remove_table_from_cache(thd, db, table_list->table_name, - RTFC_NO_FLAG))); + + if (!check_in_use) + { + DBUG_RETURN(0); + } + else + { + /* Return 1 if table is in use */ + DBUG_RETURN(test(remove_table_from_cache(thd, db, table_list->table_name, + RTFC_NO_FLAG))); + } } @@ -1003,7 +1016,7 @@ bool lock_table_names(THD *thd, TABLE_LIST *table_list) for (lock_table= table_list; lock_table; lock_table= lock_table->next_local) { int got_lock; - if ((got_lock=lock_table_name(thd,lock_table)) < 0) + if ((got_lock=lock_table_name(thd,lock_table, TRUE)) < 0) goto end; // Fatal error if (got_lock) got_all_locks=0; // Someone is using table diff --git a/sql/mysql_priv.h b/sql/mysql_priv.h index 127aa6c5acd..d00addb9f6d 100644 --- a/sql/mysql_priv.h +++ b/sql/mysql_priv.h @@ -1169,7 +1169,7 @@ uint fast_alter_partition_table(THD *thd, TABLE *table, HA_CREATE_INFO *create_info, TABLE_LIST *table_list, List *create_list, - List *key_list, const char *db, + List *key_list, char *db, const char *table_name, uint fast_alter_partition); uint prep_alter_part_table(THD *thd, TABLE *table, ALTER_INFO *alter_info, @@ -1199,6 +1199,7 @@ void create_subpartition_name(char *out, const char *in1, typedef struct st_lock_param_type { + TABLE_LIST table_list; ulonglong copied; ulonglong deleted; THD *thd; @@ -1209,7 +1210,7 @@ typedef struct st_lock_param_type List new_key_list; TABLE *table; KEY *key_info_buffer; - const char *db; + char *db; const char *table_name; const void *pack_frm_data; enum thr_lock_type old_lock_type; @@ -1676,7 +1677,7 @@ void unset_protect_against_global_read_lock(void); /* Lock based on name */ int lock_and_wait_for_table_name(THD *thd, TABLE_LIST *table_list); -int lock_table_name(THD *thd, TABLE_LIST *table_list); +int lock_table_name(THD *thd, TABLE_LIST *table_list, bool check_in_use); void unlock_table_name(THD *thd, TABLE_LIST *table_list); bool wait_for_locked_table_names(THD *thd, TABLE_LIST *table_list); bool lock_table_names(THD *thd, TABLE_LIST *table_list); diff --git a/sql/sql_base.cc b/sql/sql_base.cc index 77d2b165881..37060a315af 100644 --- a/sql/sql_base.cc +++ b/sql/sql_base.cc @@ -2680,7 +2680,7 @@ retry: goto err; // Code below is for repairing a crashed file - if ((error= lock_table_name(thd, table_list))) + if ((error= lock_table_name(thd, table_list, TRUE))) { if (error < 0) goto err; diff --git a/sql/sql_partition.cc b/sql/sql_partition.cc index 71b8e9b1d95..381231144c4 100644 --- a/sql/sql_partition.cc +++ b/sql/sql_partition.cc @@ -5349,6 +5349,79 @@ static void release_log_entries(partition_info *part_info) } +/* + Get a lock on table name to avoid that anyone can open the table in + a critical part of the ALTER TABLE. + SYNOPSIS + get_name_lock() + lpt Struct carrying parameters + RETURN VALUES + FALSE Success + TRUE Failure +*/ + +static int get_name_lock(ALTER_PARTITION_PARAM_TYPE *lpt) +{ + int error= 0; + DBUG_ENTER("get_name_lock"); + + bzero(&lpt->table_list, sizeof(lpt->table_list)); + lpt->table_list.db= lpt->db; + lpt->table_list.table= lpt->table; + lpt->table_list.table_name= (char*)lpt->table_name; + pthread_mutex_lock(&LOCK_open); + error= lock_table_name(lpt->thd, &lpt->table_list, FALSE); + pthread_mutex_unlock(&LOCK_open); + DBUG_RETURN(error); +} + + +/* + Unlock and close table before renaming and dropping partitions + SYNOPSIS + alter_close_tables() + lpt Struct carrying parameters + RETURN VALUES + 0 +*/ + +static int alter_close_tables(ALTER_PARTITION_PARAM_TYPE *lpt) +{ + THD *thd= lpt->thd; + TABLE *table= lpt->table; + DBUG_ENTER("alter_close_tables"); + /* + We need to also unlock tables and close all handlers. + We set lock to zero to ensure we don't do this twice + and we set db_stat to zero to ensure we don't close twice. + */ + mysql_unlock_tables(thd, thd->lock); + thd->lock= 0; + table->file->close(); + table->db_stat= 0; + DBUG_RETURN(0); +} + + +/* + Release a lock name + SYNOPSIS + release_name_lock() + lpt + RETURN VALUES + 0 +*/ + +static int release_name_lock(ALTER_PARTITION_PARAM_TYPE *lpt) +{ + DBUG_ENTER("release_name_lock"); + pthread_mutex_lock(&LOCK_open); + unlock_table_name(lpt->thd, &lpt->table_list); + pthread_mutex_unlock(&LOCK_open); + DBUG_RETURN(0); +} + + /* Handle errors for ALTER TABLE for partitioning SYNOPSIS @@ -5499,7 +5572,7 @@ uint fast_alter_partition_table(THD *thd, TABLE *table, HA_CREATE_INFO *create_info, TABLE_LIST *table_list, List *create_list, - List *key_list, const char *db, + List *key_list, char *db, const char *table_name, uint fast_alter_partition) { @@ -5639,8 +5712,16 @@ uint fast_alter_partition_table(THD *thd, TABLE *table, 2) Write the ddl log to ensure that the operation is completed even in the presence of a MySQL Server crash 3) Lock the table in TL_WRITE_ONLY to ensure all other accesses to - the table have completed - 4) Write the bin log + the table have completed. This ensures that other threads can not + execute on the table in parallel. + 4) Get a name lock on the table. This ensures that we can release all + locks on the table and since no one can open the table, there can + be no new threads accessing the table. They will be hanging on the + name lock. + 5) Close all tables that have already been opened but didn't stumble on + the abort locked previously. + 6) We are now ready to release all locks we got in this thread. + 7) Write the bin log Unfortunately the writing of the binlog is not synchronised with other logging activities. So no matter in which order the binlog is written compared to other activities there will always be cases @@ -5651,14 +5732,13 @@ uint fast_alter_partition_table(THD *thd, TABLE *table, require writing the statement first in the ddl log and then when recovering from the crash read the binlog and insert it into the binlog if not written already. - 5) Install the previously written shadow frm file - 6) Ensure that any users that has opened the table but not yet - reached the abort lock do that before downgrading the lock. - 7) Prepare MyISAM handlers for drop of partitions - 8) Drop the partitions - 9) Remove entries from ddl log - 10) Wait until all accesses using the old frm file has completed - 11) Complete query + 8) Install the previously written shadow frm file + 9) Prepare handlers for drop of partitions + 10) Drop the partitions + 11) Remove entries from ddl log + 12) Release name lock so that all other threads can access the table + again. + 13) Complete query We insert Error injections at all places where it could be interesting to test if recovery is properly done. @@ -5671,22 +5751,26 @@ uint fast_alter_partition_table(THD *thd, TABLE *table, ERROR_INJECT_CRASH("crash_drop_partition_3") || (not_completed= FALSE) || abort_and_upgrade_lock(lpt) || /* Always returns 0 */ + ERROR_INJECT_CRASH("crash_drop_partition_4") || ((!thd->lex->no_write_to_binlog) && (write_bin_log(thd, FALSE, thd->query, thd->query_length), FALSE)) || - ERROR_INJECT_CRASH("crash_drop_partition_4") || - (table->file->extra(HA_EXTRA_PREPARE_FOR_DELETE), FALSE) || ERROR_INJECT_CRASH("crash_drop_partition_5") || ((frm_install= TRUE), FALSE) || mysql_write_frm(lpt, WFRM_INSTALL_SHADOW) || ((frm_install= FALSE), FALSE) || - (close_open_tables_and_downgrade(lpt), FALSE) || ERROR_INJECT_CRASH("crash_drop_partition_6") || - mysql_drop_partitions(lpt) || + get_name_lock(lpt) || /* Always returns 0 */ ERROR_INJECT_CRASH("crash_drop_partition_7") || - (write_log_completed(lpt, FALSE), FALSE) || + (close_open_tables_and_downgrade(lpt), FALSE) || ERROR_INJECT_CRASH("crash_drop_partition_8") || - (mysql_wait_completed_table(lpt, table), FALSE)) + alter_close_tables(lpt) || + ERROR_INJECT_CRASH("crash_drop_partition_9") || + mysql_drop_partitions(lpt) || + ERROR_INJECT_CRASH("crash_drop_partition_10") || + (write_log_completed(lpt, FALSE), FALSE) || + ERROR_INJECT_CRASH("crash_drop_partition_11") || + (release_name_lock(lpt), FALSE)) { handle_alter_part_error(lpt, not_completed, TRUE, frm_install); DBUG_RETURN(TRUE); @@ -5791,16 +5875,20 @@ uint fast_alter_partition_table(THD *thd, TABLE *table, 5) Lock all partitions in TL_WRITE_ONLY to ensure that no users are still using the old partitioning scheme. Wait until all ongoing users have completed before progressing. - 6) Prepare MyISAM handlers for rename and delete of partitions - 7) Rename the reorged partitions such that they are no longer - used and rename those added to their real new names. - 8) Write bin log - 9) Install the shadow frm file - 10) Wait until all accesses using the old frm file has completed - 11) Drop the reorganised partitions - 12) Remove log entry - 13)Wait until all accesses using the old frm file has completed - 14)Complete query + 6) Get a name lock of the table + 7) Close all tables opened but not yet locked, after this call we are + certain that no other thread is in the lock wait queue or has + opened the table. The name lock will ensure that they are blocked + on the open call. + 8) Close all partitions opened by this thread, but retain name lock. + 9) Write bin log + 10) Prepare handlers for rename and delete of partitions + 11) Rename and drop the reorged partitions such that they are no + longer used and rename those added to their real new names. + 12) Install the shadow frm file + 13) Release the name lock to enable other threads to start using the + table again. + 14) Complete query */ if (write_log_add_change_partition(lpt) || ERROR_INJECT_CRASH("crash_change_partition_1") || @@ -5812,22 +5900,25 @@ uint fast_alter_partition_table(THD *thd, TABLE *table, ERROR_INJECT_CRASH("crash_change_partition_4") || (not_completed= FALSE) || abort_and_upgrade_lock(lpt) || /* Always returns 0 */ + ERROR_INJECT_CRASH("crash_change_partition_5") || ((!thd->lex->no_write_to_binlog) && (write_bin_log(thd, FALSE, thd->query, thd->query_length), FALSE)) || - ERROR_INJECT_CRASH("crash_change_partition_5") || - (table->file->extra(HA_EXTRA_PREPARE_FOR_DELETE), FALSE) || ERROR_INJECT_CRASH("crash_change_partition_6") || - mysql_rename_partitions(lpt) || - ((frm_install= TRUE), FALSE) || - ERROR_INJECT_CRASH("crash_change_partition_7") || mysql_write_frm(lpt, WFRM_INSTALL_SHADOW) || + ERROR_INJECT_CRASH("crash_change_partition_7") || + get_name_lock(lpt) || ERROR_INJECT_CRASH("crash_change_partition_8") || (close_open_tables_and_downgrade(lpt), FALSE) || ERROR_INJECT_CRASH("crash_change_partition_9") || - (write_log_completed(lpt, FALSE), FALSE) || + alter_close_tables(lpt) || ERROR_INJECT_CRASH("crash_change_partition_10") || - (mysql_wait_completed_table(lpt, table), FALSE)) + mysql_rename_partitions(lpt) || + ((frm_install= TRUE), FALSE) || + ERROR_INJECT_CRASH("crash_change_partition_11") || + (write_log_completed(lpt, FALSE), FALSE) || + ERROR_INJECT_CRASH("crash_change_partition_12") || + (release_name_lock(lpt), FALSE)) { handle_alter_part_error(lpt, not_completed, FALSE, frm_install); DBUG_RETURN(TRUE); From ce80d6573c28d1e0f05cdad670acc734a5fc4d32 Mon Sep 17 00:00:00 2001 From: unknown Date: Sat, 27 May 2006 20:16:17 -0400 Subject: [PATCH 3/7] BUG#19830: ALTER TABLE REORGANIZE partition crashes New test cases added mysql-test/r/partition_range.result: New test case mysql-test/t/partition_range.test: New test case --- mysql-test/r/partition_range.result | 105 +++++++++++++++++++++++++ mysql-test/t/partition_range.test | 114 ++++++++++++++++++++++++++++ 2 files changed, 219 insertions(+) diff --git a/mysql-test/r/partition_range.result b/mysql-test/r/partition_range.result index c7257db4910..36b8eacda42 100644 --- a/mysql-test/r/partition_range.result +++ b/mysql-test/r/partition_range.result @@ -387,3 +387,108 @@ ALTER TABLE t1 DROP PARTITION p0; ALTER TABLE t1 DROP PARTITION p1; ALTER TABLE t1 DROP PARTITION p2; drop table t1; +create table t1 (a int DEFAULT NULL, +b varchar(30) DEFAULT NULL, +c date DEFAULT NULL) +ENGINE=MYISAM DEFAULT CHARSET=latin1; +insert into t1 values (1, 'abc', '1995-01-01'); +insert into t1 values (1, 'abc', '1995-01-02'); +insert into t1 values (1, 'abc', '1995-01-03'); +insert into t1 values (1, 'abc', '1995-01-04'); +insert into t1 values (1, 'abc', '1995-01-05'); +insert into t1 values (1, 'abc', '1995-01-06'); +insert into t1 values (1, 'abc', '1995-01-07'); +insert into t1 values (1, 'abc', '1995-01-08'); +insert into t1 values (1, 'abc', '1995-01-09'); +insert into t1 values (1, 'abc', '1995-01-10'); +insert into t1 values (1, 'abc', '1995-01-11'); +insert into t1 values (1, 'abc', '1995-01-12'); +insert into t1 values (1, 'abc', '1995-01-13'); +insert into t1 values (1, 'abc', '1995-01-14'); +insert into t1 values (1, 'abc', '1995-01-15'); +insert into t1 values (1, 'abc', '1997-01-01'); +insert into t1 values (1, 'abc', '1997-01-02'); +insert into t1 values (1, 'abc', '1997-01-03'); +insert into t1 values (1, 'abc', '1997-01-04'); +insert into t1 values (1, 'abc', '1997-01-05'); +insert into t1 values (1, 'abc', '1997-01-06'); +insert into t1 values (1, 'abc', '1997-01-07'); +insert into t1 values (1, 'abc', '1997-01-08'); +insert into t1 values (1, 'abc', '1997-01-09'); +insert into t1 values (1, 'abc', '1997-01-10'); +insert into t1 values (1, 'abc', '1997-01-11'); +insert into t1 values (1, 'abc', '1997-01-12'); +insert into t1 values (1, 'abc', '1997-01-13'); +insert into t1 values (1, 'abc', '1997-01-14'); +insert into t1 values (1, 'abc', '1997-01-15'); +insert into t1 values (1, 'abc', '1998-01-01'); +insert into t1 values (1, 'abc', '1998-01-02'); +insert into t1 values (1, 'abc', '1998-01-03'); +insert into t1 values (1, 'abc', '1998-01-04'); +insert into t1 values (1, 'abc', '1998-01-05'); +insert into t1 values (1, 'abc', '1998-01-06'); +insert into t1 values (1, 'abc', '1998-01-07'); +insert into t1 values (1, 'abc', '1998-01-08'); +insert into t1 values (1, 'abc', '1998-01-09'); +insert into t1 values (1, 'abc', '1998-01-10'); +insert into t1 values (1, 'abc', '1998-01-11'); +insert into t1 values (1, 'abc', '1998-01-12'); +insert into t1 values (1, 'abc', '1998-01-13'); +insert into t1 values (1, 'abc', '1998-01-14'); +insert into t1 values (1, 'abc', '1998-01-15'); +insert into t1 values (1, 'abc', '1999-01-01'); +insert into t1 values (1, 'abc', '1999-01-02'); +insert into t1 values (1, 'abc', '1999-01-03'); +insert into t1 values (1, 'abc', '1999-01-04'); +insert into t1 values (1, 'abc', '1999-01-05'); +insert into t1 values (1, 'abc', '1999-01-06'); +insert into t1 values (1, 'abc', '1999-01-07'); +insert into t1 values (1, 'abc', '1999-01-08'); +insert into t1 values (1, 'abc', '1999-01-09'); +insert into t1 values (1, 'abc', '1999-01-10'); +insert into t1 values (1, 'abc', '1999-01-11'); +insert into t1 values (1, 'abc', '1999-01-12'); +insert into t1 values (1, 'abc', '1999-01-13'); +insert into t1 values (1, 'abc', '1999-01-14'); +insert into t1 values (1, 'abc', '1999-01-15'); +insert into t1 values (1, 'abc', '2000-01-01'); +insert into t1 values (1, 'abc', '2000-01-02'); +insert into t1 values (1, 'abc', '2000-01-03'); +insert into t1 values (1, 'abc', '2000-01-04'); +insert into t1 values (1, 'abc', '2000-01-05'); +insert into t1 values (1, 'abc', '2000-01-06'); +insert into t1 values (1, 'abc', '2000-01-07'); +insert into t1 values (1, 'abc', '2000-01-08'); +insert into t1 values (1, 'abc', '2000-01-09'); +insert into t1 values (1, 'abc', '2000-01-15'); +insert into t1 values (1, 'abc', '2000-01-11'); +insert into t1 values (1, 'abc', '2000-01-12'); +insert into t1 values (1, 'abc', '2000-01-13'); +insert into t1 values (1, 'abc', '2000-01-14'); +insert into t1 values (1, 'abc', '2000-01-15'); +insert into t1 values (1, 'abc', '2001-01-01'); +insert into t1 values (1, 'abc', '2001-01-02'); +insert into t1 values (1, 'abc', '2001-01-03'); +insert into t1 values (1, 'abc', '2001-01-04'); +insert into t1 values (1, 'abc', '2001-01-05'); +insert into t1 values (1, 'abc', '2001-01-06'); +insert into t1 values (1, 'abc', '2001-01-07'); +insert into t1 values (1, 'abc', '2001-01-08'); +insert into t1 values (1, 'abc', '2001-01-09'); +insert into t1 values (1, 'abc', '2001-01-15'); +insert into t1 values (1, 'abc', '2001-01-11'); +insert into t1 values (1, 'abc', '2001-01-12'); +insert into t1 values (1, 'abc', '2001-01-13'); +insert into t1 values (1, 'abc', '2001-01-14'); +insert into t1 values (1, 'abc', '2001-01-15'); +alter table t1 +partition by range (year(c)) +(partition p5 values less than (2000), partition p10 values less than (2010)); +alter table t1 +reorganize partition p5 into +(partition p1 values less than (1996), +partition p2 values less than (1997), +partition p3 values less than (1998), +partition p4 values less than (1999), +partition p5 values less than (2000)); +drop table t1; diff --git a/mysql-test/t/partition_range.test b/mysql-test/t/partition_range.test index ef539e2001f..42ce4e0d879 100644 --- a/mysql-test/t/partition_range.test +++ b/mysql-test/t/partition_range.test @@ -416,3 +416,117 @@ ALTER TABLE t1 DROP PARTITION p0; ALTER TABLE t1 DROP PARTITION p1; ALTER TABLE t1 DROP PARTITION p2; drop table t1; + +# +# Bug 19830: ALTER TABLE t1 REORGANIZE PARTITION crashes +# +create table t1 (a int DEFAULT NULL, + b varchar(30) DEFAULT NULL, + c date DEFAULT NULL) +ENGINE=MYISAM DEFAULT CHARSET=latin1; + +insert into t1 values (1, 'abc', '1995-01-01'); +insert into t1 values (1, 'abc', '1995-01-02'); +insert into t1 values (1, 'abc', '1995-01-03'); +insert into t1 values (1, 'abc', '1995-01-04'); +insert into t1 values (1, 'abc', '1995-01-05'); +insert into t1 values (1, 'abc', '1995-01-06'); +insert into t1 values (1, 'abc', '1995-01-07'); +insert into t1 values (1, 'abc', '1995-01-08'); +insert into t1 values (1, 'abc', '1995-01-09'); +insert into t1 values (1, 'abc', '1995-01-10'); +insert into t1 values (1, 'abc', '1995-01-11'); +insert into t1 values (1, 'abc', '1995-01-12'); +insert into t1 values (1, 'abc', '1995-01-13'); +insert into t1 values (1, 'abc', '1995-01-14'); +insert into t1 values (1, 'abc', '1995-01-15'); +insert into t1 values (1, 'abc', '1997-01-01'); +insert into t1 values (1, 'abc', '1997-01-02'); +insert into t1 values (1, 'abc', '1997-01-03'); +insert into t1 values (1, 'abc', '1997-01-04'); +insert into t1 values (1, 'abc', '1997-01-05'); +insert into t1 values (1, 'abc', '1997-01-06'); +insert into t1 values (1, 'abc', '1997-01-07'); +insert into t1 values (1, 'abc', '1997-01-08'); +insert into t1 values (1, 'abc', '1997-01-09'); +insert into t1 values (1, 'abc', '1997-01-10'); +insert into t1 values (1, 'abc', '1997-01-11'); +insert into t1 values (1, 'abc', '1997-01-12'); +insert into t1 values (1, 'abc', '1997-01-13'); +insert into t1 values (1, 'abc', '1997-01-14'); +insert into t1 values (1, 'abc', '1997-01-15'); +insert into t1 values (1, 'abc', '1998-01-01'); +insert into t1 values (1, 'abc', '1998-01-02'); +insert into t1 values (1, 'abc', '1998-01-03'); +insert into t1 values (1, 'abc', '1998-01-04'); +insert into t1 values (1, 'abc', '1998-01-05'); +insert into t1 values (1, 'abc', '1998-01-06'); +insert into t1 values (1, 'abc', '1998-01-07'); +insert into t1 values (1, 'abc', '1998-01-08'); +insert into t1 values (1, 'abc', '1998-01-09'); +insert into t1 values (1, 'abc', '1998-01-10'); +insert into t1 values (1, 'abc', '1998-01-11'); +insert into t1 values (1, 'abc', '1998-01-12'); +insert into t1 values (1, 'abc', '1998-01-13'); +insert into t1 values (1, 'abc', '1998-01-14'); +insert into t1 values (1, 'abc', '1998-01-15'); +insert into t1 values (1, 'abc', '1999-01-01'); +insert into t1 values (1, 'abc', '1999-01-02'); +insert into t1 values (1, 'abc', '1999-01-03'); +insert into t1 values (1, 'abc', '1999-01-04'); +insert into t1 values (1, 'abc', '1999-01-05'); +insert into t1 values (1, 'abc', '1999-01-06'); +insert into t1 values (1, 'abc', '1999-01-07'); +insert into t1 values (1, 'abc', '1999-01-08'); +insert into t1 values (1, 'abc', '1999-01-09'); +insert into t1 values (1, 'abc', '1999-01-10'); +insert into t1 values (1, 'abc', '1999-01-11'); +insert into t1 values (1, 'abc', '1999-01-12'); +insert into t1 values (1, 'abc', '1999-01-13'); +insert into t1 values (1, 'abc', '1999-01-14'); +insert into t1 values (1, 'abc', '1999-01-15'); +insert into t1 values (1, 'abc', '2000-01-01'); +insert into t1 values (1, 'abc', '2000-01-02'); +insert into t1 values (1, 'abc', '2000-01-03'); +insert into t1 values (1, 'abc', '2000-01-04'); +insert into t1 values (1, 'abc', '2000-01-05'); +insert into t1 values (1, 'abc', '2000-01-06'); +insert into t1 values (1, 'abc', '2000-01-07'); +insert into t1 values (1, 'abc', '2000-01-08'); +insert into t1 values (1, 'abc', '2000-01-09'); +insert into t1 values (1, 'abc', '2000-01-15'); +insert into t1 values (1, 'abc', '2000-01-11'); +insert into t1 values (1, 'abc', '2000-01-12'); +insert into t1 values (1, 'abc', '2000-01-13'); +insert into t1 values (1, 'abc', '2000-01-14'); +insert into t1 values (1, 'abc', '2000-01-15'); +insert into t1 values (1, 'abc', '2001-01-01'); +insert into t1 values (1, 'abc', '2001-01-02'); +insert into t1 values (1, 'abc', '2001-01-03'); +insert into t1 values (1, 'abc', '2001-01-04'); +insert into t1 values (1, 'abc', '2001-01-05'); +insert into t1 values (1, 'abc', '2001-01-06'); +insert into t1 values (1, 'abc', '2001-01-07'); +insert into t1 values (1, 'abc', '2001-01-08'); +insert into t1 values (1, 'abc', '2001-01-09'); +insert into t1 values (1, 'abc', '2001-01-15'); +insert into t1 values (1, 'abc', '2001-01-11'); +insert into t1 values (1, 'abc', '2001-01-12'); +insert into t1 values (1, 'abc', '2001-01-13'); +insert into t1 values (1, 'abc', '2001-01-14'); +insert into t1 values (1, 'abc', '2001-01-15'); + +alter table t1 +partition by range (year(c)) +(partition p5 values less than (2000), partition p10 values less than (2010)); + +alter table t1 +reorganize partition p5 into +(partition p1 values less than (1996), + partition p2 values less than (1997), + partition p3 values less than (1998), + partition p4 values less than (1999), + partition p5 values less than (2000)); + +drop table t1; + From d13c5aa3b709c079a0ce83dab49b51d517dfb438 Mon Sep 17 00:00:00 2001 From: unknown Date: Sat, 27 May 2006 20:23:22 -0400 Subject: [PATCH 4/7] BUG#19903: Add partition crashes Added new test cases --- mysql-test/r/partition_innodb.result | 86 ++++++++++++++++++++++++++++ mysql-test/t/partition_innodb.test | 58 +++++++++++++++++++ 2 files changed, 144 insertions(+) create mode 100644 mysql-test/r/partition_innodb.result create mode 100644 mysql-test/t/partition_innodb.test diff --git a/mysql-test/r/partition_innodb.result b/mysql-test/r/partition_innodb.result new file mode 100644 index 00000000000..340d100742b --- /dev/null +++ b/mysql-test/r/partition_innodb.result @@ -0,0 +1,86 @@ +SET @max_row = 20; +DROP TABLE IF EXISTS t0_template; +CREATE TABLE t0_template ( +f_int1 INTEGER, +f_int2 INTEGER, +f_char1 CHAR(20), +f_char2 CHAR(20), +f_charbig VARCHAR(1000) , +PRIMARY KEY(f_int1)) +ENGINE = MEMORY; +INSERT INTO t0_template +SET f_int1 = 20, f_int2 = 20, f_char1 = '20', f_char2 = '20', +f_charbig = '===20==='; +INSERT INTO t0_template +SET f_int1 = 19, f_int2 = 19, f_char1 = '19', f_char2 = '19', +f_charbig = '===19==='; +INSERT INTO t0_template +SET f_int1 = 18, f_int2 = 18, f_char1 = '18', f_char2 = '18', +f_charbig = '===18==='; +INSERT INTO t0_template +SET f_int1 = 17, f_int2 = 17, f_char1 = '17', f_char2 = '17', +f_charbig = '===17==='; +INSERT INTO t0_template +SET f_int1 = 16, f_int2 = 16, f_char1 = '16', f_char2 = '16', +f_charbig = '===16==='; +INSERT INTO t0_template +SET f_int1 = 15, f_int2 = 15, f_char1 = '15', f_char2 = '15', +f_charbig = '===15==='; +INSERT INTO t0_template +SET f_int1 = 14, f_int2 = 14, f_char1 = '14', f_char2 = '14', +f_charbig = '===14==='; +INSERT INTO t0_template +SET f_int1 = 13, f_int2 = 13, f_char1 = '13', f_char2 = '13', +f_charbig = '===13==='; +INSERT INTO t0_template +SET f_int1 = 12, f_int2 = 12, f_char1 = '12', f_char2 = '12', +f_charbig = '===12==='; +INSERT INTO t0_template +SET f_int1 = 11, f_int2 = 11, f_char1 = '11', f_char2 = '11', +f_charbig = '===11==='; +INSERT INTO t0_template +SET f_int1 = 10, f_int2 = 10, f_char1 = '10', f_char2 = '10', +f_charbig = '===10==='; +INSERT INTO t0_template +SET f_int1 = 9, f_int2 = 9, f_char1 = '9', f_char2 = '9', +f_charbig = '===9==='; +INSERT INTO t0_template +SET f_int1 = 8, f_int2 = 8, f_char1 = '8', f_char2 = '8', +f_charbig = '===8==='; +INSERT INTO t0_template +SET f_int1 = 7, f_int2 = 7, f_char1 = '7', f_char2 = '7', +f_charbig = '===7==='; +INSERT INTO t0_template +SET f_int1 = 6, f_int2 = 6, f_char1 = '6', f_char2 = '6', +f_charbig = '===6==='; +INSERT INTO t0_template +SET f_int1 = 5, f_int2 = 5, f_char1 = '5', f_char2 = '5', +f_charbig = '===5==='; +INSERT INTO t0_template +SET f_int1 = 4, f_int2 = 4, f_char1 = '4', f_char2 = '4', +f_charbig = '===4==='; +INSERT INTO t0_template +SET f_int1 = 3, f_int2 = 3, f_char1 = '3', f_char2 = '3', +f_charbig = '===3==='; +INSERT INTO t0_template +SET f_int1 = 2, f_int2 = 2, f_char1 = '2', f_char2 = '2', +f_charbig = '===2==='; +INSERT INTO t0_template +SET f_int1 = 1, f_int2 = 1, f_char1 = '1', f_char2 = '1', +f_charbig = '===1==='; +DROP TABLE IF EXISTS t1; +CREATE TABLE t1 (f_date DATE, f_varchar VARCHAR(30)) engine='InnoDB'; +INSERT INTO t1 (f_date, f_varchar) +SELECT CONCAT(CAST((f_int1 + 999) AS CHAR),'-02-10'), CAST(f_char1 AS CHAR) +FROM t0_template +WHERE f_int1 + 999 BETWEEN 1000 AND 9999; +SELECT IF(9999 - 1000 + 1 > @max_row, @max_row , 9999 - 1000 + 1) +INTO @exp_row_count; +ALTER TABLE t1 PARTITION BY HASH(CAST(YEAR(f_date) AS SIGNED INTEGER)); +# 1.1.5 Add two named partitions + test +ALTER TABLE t1 ADD PARTITION (PARTITION part1, PARTITION part7); +DROP VIEW IF EXISTS v1; +DROP TABLE IF EXISTS t1; +DROP TABLE IF EXISTS t0_aux; +DROP TABLE IF EXISTS t0_definition; +DROP TABLE IF EXISTS t0_template; diff --git a/mysql-test/t/partition_innodb.test b/mysql-test/t/partition_innodb.test new file mode 100644 index 00000000000..0190479d908 --- /dev/null +++ b/mysql-test/t/partition_innodb.test @@ -0,0 +1,58 @@ +-- source include/have_innodb.inc + +SET @max_row = 20; +let $engine= 'InnoDB'; +let $MAX_VALUE= (2147483646); + +let $max_row= `SELECT @max_row`; + +# Column list with definition for all tables to be checked +let $column_list= f_int1 INTEGER, +f_int2 INTEGER, +f_char1 CHAR(20), +f_char2 CHAR(20), +f_charbig VARCHAR(1000); + +let $sub_part_no= 3; +--disable_warnings +DROP TABLE IF EXISTS t0_template; +--enable_warnings +eval CREATE TABLE t0_template ( +$column_list , +PRIMARY KEY(f_int1)) +ENGINE = MEMORY; +let $num= `SELECT @max_row`; +while ($num) +{ + eval INSERT INTO t0_template +SET f_int1 = $num, f_int2 = $num, f_char1 = '$num', f_char2 = '$num', +f_charbig = '===$num==='; + dec $num; +} +# 1. Create the table +--disable_warnings +DROP TABLE IF EXISTS t1; +--enable_warnings +eval CREATE TABLE t1 (f_date DATE, f_varchar VARCHAR(30)) engine=$engine; +# 2. Fill the table t1 with records +INSERT INTO t1 (f_date, f_varchar) +SELECT CONCAT(CAST((f_int1 + 999) AS CHAR),'-02-10'), CAST(f_char1 AS CHAR) +FROM t0_template +WHERE f_int1 + 999 BETWEEN 1000 AND 9999; +# 3. Calculate the number of inserted records. +SELECT IF(9999 - 1000 + 1 > @max_row, @max_row , 9999 - 1000 + 1) + INTO @exp_row_count; +# DEBUG SELECT @exp_row_count; +# 4. Print the layout, check Readability +ALTER TABLE t1 PARTITION BY HASH(CAST(YEAR(f_date) AS SIGNED INTEGER)); +--echo # 1.1.5 Add two named partitions + test +ALTER TABLE t1 ADD PARTITION (PARTITION part1, PARTITION part7); + +--disable_warnings +DROP VIEW IF EXISTS v1; +DROP TABLE IF EXISTS t1; +DROP TABLE IF EXISTS t0_aux; +DROP TABLE IF EXISTS t0_definition; +DROP TABLE IF EXISTS t0_template; +--enable_warnings + From 93cde729c0c57d50283d8602332af22ebbc26110 Mon Sep 17 00:00:00 2001 From: unknown Date: Sat, 27 May 2006 20:30:53 -0400 Subject: [PATCH 5/7] BUG#19310: Add partition using InnoDB crashes MySQL Server Added new test case mysql-test/r/partition_innodb.result: Added new test case mysql-test/t/partition_innodb.test: Added new test case --- mysql-test/r/partition_innodb.result | 8 ++++++++ mysql-test/t/partition_innodb.test | 10 ++++++++++ 2 files changed, 18 insertions(+) diff --git a/mysql-test/r/partition_innodb.result b/mysql-test/r/partition_innodb.result index 340d100742b..5b1221dd64c 100644 --- a/mysql-test/r/partition_innodb.result +++ b/mysql-test/r/partition_innodb.result @@ -79,6 +79,14 @@ INTO @exp_row_count; ALTER TABLE t1 PARTITION BY HASH(CAST(YEAR(f_date) AS SIGNED INTEGER)); # 1.1.5 Add two named partitions + test ALTER TABLE t1 ADD PARTITION (PARTITION part1, PARTITION part7); +drop table t1; +CREATE TABLE t1 (f_date DATE, f_varchar VARCHAR(30)) +ENGINE=InnoDB +PARTITION BY HASH(CAST(YEAR(f_date) AS SIGNED INTEGER)); +# This statement crashes the server. +# CREATE partitioned table with three partitions in one step +# would be harmless. +ALTER TABLE t1 ADD PARTITION PARTITIONS 1; DROP VIEW IF EXISTS v1; DROP TABLE IF EXISTS t1; DROP TABLE IF EXISTS t0_aux; diff --git a/mysql-test/t/partition_innodb.test b/mysql-test/t/partition_innodb.test index 0190479d908..6a95dd7c8b0 100644 --- a/mysql-test/t/partition_innodb.test +++ b/mysql-test/t/partition_innodb.test @@ -47,6 +47,16 @@ SELECT IF(9999 - 1000 + 1 > @max_row, @max_row , 9999 - 1000 + 1) ALTER TABLE t1 PARTITION BY HASH(CAST(YEAR(f_date) AS SIGNED INTEGER)); --echo # 1.1.5 Add two named partitions + test ALTER TABLE t1 ADD PARTITION (PARTITION part1, PARTITION part7); +drop table t1; + +CREATE TABLE t1 (f_date DATE, f_varchar VARCHAR(30)) +ENGINE=InnoDB +PARTITION BY HASH(CAST(YEAR(f_date) AS SIGNED INTEGER)); + +--echo # This statement crashes the server. +--echo # CREATE partitioned table with three partitions in one step +--echo # would be harmless. +ALTER TABLE t1 ADD PARTITION PARTITIONS 1; --disable_warnings DROP VIEW IF EXISTS v1; From 14c0751c30c4f495bddbd0aefe2787897b806fa5 Mon Sep 17 00:00:00 2001 From: unknown Date: Mon, 12 Jun 2006 17:30:32 -0400 Subject: [PATCH 6/7] BUG#19122: Need to close all handlers before rename/drop phase in ALTER TABLE ADD/DROP/REORGANIZE partitions After review fix mysql-test/r/partition.result: Fixes for test mysql-test/t/partition.test: Fixes for test sql/lock.cc: After review fix sql/mysql_priv.h: After review fix sql/sql_partition.cc: After review fix --- mysql-test/r/partition.result | 9 ++++--- mysql-test/t/partition.test | 2 ++ sql/lock.cc | 13 +++------- sql/mysql_priv.h | 2 +- sql/sql_partition.cc | 49 ++++++++++++++++++----------------- 5 files changed, 36 insertions(+), 39 deletions(-) diff --git a/mysql-test/r/partition.result b/mysql-test/r/partition.result index 8bf86056e24..967e30104cf 100644 --- a/mysql-test/r/partition.result +++ b/mysql-test/r/partition.result @@ -890,6 +890,11 @@ s1 2 3 drop table t1; +create table t1 (a int) engine=memory +partition by key(a); +insert into t1 values (1); +create index inx1 on t1(a); +drop table t1; create table t1 (a int) partition by key (a) (partition p1 engine = innodb); @@ -900,10 +905,6 @@ alter table t1 rebuild partition p1; alter table t1 rebuild partition p1; alter table t1 rebuild partition p1; alter table t1 rebuild partition p1; -create table t1 (a int) engine=memory -partition by key(a); -insert into t1 values (1); -create index inx1 on t1(a); drop table t1; create table t1 (a int) partition by key (a) diff --git a/mysql-test/t/partition.test b/mysql-test/t/partition.test index 03c3f6e0a7c..1d3e38a6e16 100644 --- a/mysql-test/t/partition.test +++ b/mysql-test/t/partition.test @@ -1038,6 +1038,8 @@ alter table t1 rebuild partition p1; alter table t1 rebuild partition p1; alter table t1 rebuild partition p1; +drop table t1; + # # BUG 19304 Partitions: MERGE handler not allowed in partitioned tables # diff --git a/sql/lock.cc b/sql/lock.cc index 3a0aa99218f..efb4d696e67 100644 --- a/sql/lock.cc +++ b/sql/lock.cc @@ -924,16 +924,9 @@ int lock_table_name(THD *thd, TABLE_LIST *table_list, bool check_in_use) DBUG_RETURN(-1); } - if (!check_in_use) - { - DBUG_RETURN(0); - } - else - { - /* Return 1 if table is in use */ - DBUG_RETURN(test(remove_table_from_cache(thd, db, table_list->table_name, - RTFC_NO_FLAG))); - } + /* Return 1 if table is in use */ + DBUG_RETURN(test(remove_table_from_cache(thd, db, table_list->table_name, + check_in_use ? RTFC_NO_FLAG : RTFC_WAIT_OTHER_THREAD_FLAG))); } diff --git a/sql/mysql_priv.h b/sql/mysql_priv.h index 443066c5f0c..8c48a84b9f4 100644 --- a/sql/mysql_priv.h +++ b/sql/mysql_priv.h @@ -1206,7 +1206,7 @@ typedef struct st_lock_param_type List new_key_list; TABLE *table; KEY *key_info_buffer; - char *db; + const char *db; const char *table_name; const void *pack_frm_data; enum thr_lock_type old_lock_type; diff --git a/sql/sql_partition.cc b/sql/sql_partition.cc index 36f4144aaff..15e1c42bbf3 100644 --- a/sql/sql_partition.cc +++ b/sql/sql_partition.cc @@ -5389,7 +5389,7 @@ static int get_name_lock(ALTER_PARTITION_PARAM_TYPE *lpt) DBUG_ENTER("get_name_lock"); bzero(&lpt->table_list, sizeof(lpt->table_list)); - lpt->table_list.db= lpt->db; + lpt->table_list.db= (char*)lpt->db; lpt->table_list.table= lpt->table; lpt->table_list.table_name= (char*)lpt->table_name; pthread_mutex_lock(&LOCK_open); @@ -5775,24 +5775,22 @@ uint fast_alter_partition_table(THD *thd, TABLE *table, (not_completed= FALSE) || abort_and_upgrade_lock(lpt) || /* Always returns 0 */ ERROR_INJECT_CRASH("crash_drop_partition_4") || + get_name_lock(lpt) || + ERROR_INJECT_CRASH("crash_drop_partition_5") || + alter_close_tables(lpt) || + ERROR_INJECT_CRASH("crash_drop_partition_6") || ((!thd->lex->no_write_to_binlog) && (write_bin_log(thd, FALSE, thd->query, thd->query_length), FALSE)) || - ERROR_INJECT_CRASH("crash_drop_partition_5") || + ERROR_INJECT_CRASH("crash_drop_partition_7") || ((frm_install= TRUE), FALSE) || mysql_write_frm(lpt, WFRM_INSTALL_SHADOW) || ((frm_install= FALSE), FALSE) || - ERROR_INJECT_CRASH("crash_drop_partition_6") || - get_name_lock(lpt) || /* Always returns 0 */ - ERROR_INJECT_CRASH("crash_drop_partition_7") || - (close_open_tables_and_downgrade(lpt), FALSE) || ERROR_INJECT_CRASH("crash_drop_partition_8") || - alter_close_tables(lpt) || - ERROR_INJECT_CRASH("crash_drop_partition_9") || mysql_drop_partitions(lpt) || - ERROR_INJECT_CRASH("crash_drop_partition_10") || + ERROR_INJECT_CRASH("crash_drop_partition_9") || (write_log_completed(lpt, FALSE), FALSE) || - ERROR_INJECT_CRASH("crash_drop_partition_11") || + ERROR_INJECT_CRASH("crash_drop_partition_10") || (release_name_lock(lpt), FALSE)) { handle_alter_part_error(lpt, not_completed, TRUE, frm_install); @@ -5836,19 +5834,24 @@ uint fast_alter_partition_table(THD *thd, TABLE *table, mysql_change_partitions(lpt) || ERROR_INJECT_CRASH("crash_add_partition_3") || abort_and_upgrade_lock(lpt) || /* Always returns 0 */ + ERROR_INJECT_CRASH("crash_add_partition_3") || + get_name_lock(lpt) || + ERROR_INJECT_CRASH("crash_add_partition_4") || + alter_close_tables(lpt) || + ERROR_INJECT_CRASH("crash_add_partition_5") || ((!thd->lex->no_write_to_binlog) && (write_bin_log(thd, FALSE, thd->query, thd->query_length), FALSE)) || - ERROR_INJECT_CRASH("crash_add_partition_4") || + ERROR_INJECT_CRASH("crash_add_partition_6") || write_log_rename_frm(lpt) || (not_completed= FALSE) || - ERROR_INJECT_CRASH("crash_add_partition_5") || + ERROR_INJECT_CRASH("crash_add_partition_7") || ((frm_install= TRUE), FALSE) || mysql_write_frm(lpt, WFRM_INSTALL_SHADOW) || - ERROR_INJECT_CRASH("crash_add_partition_6") || - (close_open_tables_and_downgrade(lpt), FALSE) || + ERROR_INJECT_CRASH("crash_add_partition_8") || (write_log_completed(lpt, FALSE), FALSE) || - ERROR_INJECT_CRASH("crash_add_partition_7")) + ERROR_INJECT_CRASH("crash_add_partition_9") || + (release_name_lock(lpt), FALSE)) { handle_alter_part_error(lpt, not_completed, FALSE, frm_install); DBUG_RETURN(TRUE); @@ -5924,23 +5927,21 @@ uint fast_alter_partition_table(THD *thd, TABLE *table, (not_completed= FALSE) || abort_and_upgrade_lock(lpt) || /* Always returns 0 */ ERROR_INJECT_CRASH("crash_change_partition_5") || + get_name_lock(lpt) || + ERROR_INJECT_CRASH("crash_change_partition_6") || + alter_close_tables(lpt) || + ERROR_INJECT_CRASH("crash_change_partition_7") || ((!thd->lex->no_write_to_binlog) && (write_bin_log(thd, FALSE, thd->query, thd->query_length), FALSE)) || - ERROR_INJECT_CRASH("crash_change_partition_6") || - mysql_write_frm(lpt, WFRM_INSTALL_SHADOW) || - ERROR_INJECT_CRASH("crash_change_partition_7") || - get_name_lock(lpt) || ERROR_INJECT_CRASH("crash_change_partition_8") || - (close_open_tables_and_downgrade(lpt), FALSE) || + mysql_write_frm(lpt, WFRM_INSTALL_SHADOW) || ERROR_INJECT_CRASH("crash_change_partition_9") || - alter_close_tables(lpt) || - ERROR_INJECT_CRASH("crash_change_partition_10") || mysql_rename_partitions(lpt) || ((frm_install= TRUE), FALSE) || - ERROR_INJECT_CRASH("crash_change_partition_11") || + ERROR_INJECT_CRASH("crash_change_partition_10") || (write_log_completed(lpt, FALSE), FALSE) || - ERROR_INJECT_CRASH("crash_change_partition_12") || + ERROR_INJECT_CRASH("crash_change_partition_11") || (release_name_lock(lpt), FALSE)) { handle_alter_part_error(lpt, not_completed, FALSE, frm_install); From 3166382d054656463cabae57b87e68b33f6c79c8 Mon Sep 17 00:00:00 2001 From: unknown Date: Mon, 12 Jun 2006 17:37:32 -0400 Subject: [PATCH 7/7] BUG#19122: Need to close handlers before drop/rename phase Fixed comments sql/sql_partition.cc: Fixed comments --- sql/sql_partition.cc | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/sql/sql_partition.cc b/sql/sql_partition.cc index 15e1c42bbf3..290a97309f1 100644 --- a/sql/sql_partition.cc +++ b/sql/sql_partition.cc @@ -5742,7 +5742,8 @@ uint fast_alter_partition_table(THD *thd, TABLE *table, be no new threads accessing the table. They will be hanging on the name lock. 5) Close all tables that have already been opened but didn't stumble on - the abort locked previously. + the abort locked previously. This is done as part of the + get_name_lock call. 6) We are now ready to release all locks we got in this thread. 7) Write the bin log Unfortunately the writing of the binlog is not synchronised with @@ -5817,15 +5818,24 @@ uint fast_alter_partition_table(THD *thd, TABLE *table, 3) Lock all partitions in TL_WRITE_ONLY to ensure that no users are still using the old partitioning scheme. Wait until all ongoing users have completed before progressing. - 4) Write binlog - 5) Now the change is completed except for the installation of the + 4) Get a name lock on the table. This ensures that we can release all + locks on the table and since no one can open the table, there can + be no new threads accessing the table. They will be hanging on the + name lock. + 5) Close all tables that have already been opened but didn't stumble on + the abort locked previously. This is done as part of the + get_name_lock call. + 6) Close all table handlers and unlock all handlers but retain name lock + 7) Write binlog + 8) Now the change is completed except for the installation of the new frm file. We thus write an action in the log to change to the shadow frm file - 6) Install the new frm file of the table where the partitions are + 9) Install the new frm file of the table where the partitions are added to the table. - 7) Wait until all accesses using the old frm file has completed - 8) Remove entries from ddl log - 9) Complete query + 10)Wait until all accesses using the old frm file has completed + 11)Remove entries from ddl log + 12)Release name lock + 13)Complete query */ if (write_log_add_change_partition(lpt) || ERROR_INJECT_CRASH("crash_add_partition_1") || @@ -5905,7 +5915,7 @@ uint fast_alter_partition_table(THD *thd, TABLE *table, 7) Close all tables opened but not yet locked, after this call we are certain that no other thread is in the lock wait queue or has opened the table. The name lock will ensure that they are blocked - on the open call. + on the open call. This is achieved also by get_name_lock call. 8) Close all partitions opened by this thread, but retain name lock. 9) Write bin log 10) Prepare handlers for rename and delete of partitions