mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-16 03:52:35 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix for bug #22824: strict, datetime, NULL, wrong warning

Browse source 
During optimization we replace NULL with 0 for not null 
date{time} fields, so uset MODE_NO_ZERO_DATE flag for a while 
as we don't want to give extra warnings.


mysql-test/r/strict.result:
  Fix for bug #22824: strict, datetime, NULL, wrong warning
    - test result.
mysql-test/t/strict.test:
  Fix for bug #22824: strict, datetime, NULL, wrong warning
    - test case.
sql/item_cmpfunc.cc:
  Fix for bug #22824: strict, datetime, NULL, wrong warning
    - turn off MODE_NO_ZERO_DATE in order not to get extra warinings
      in the save_in_field().
This commit is contained in:
unknown 2006-12-21 13:53:34 +04:00
parent 6cf0571a97
commit 2f11f1d3a9
3 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
mysql-test/r/strict.result
View file

@ -1352,3 +1352,10 @@ t1 CREATE TABLE `t1` (
`i` int(11) default NULL
) ENGINE=MyISAM DEFAULT CHARSET=latin1 COMMENT='123456789*123456789*123456789*123456789*123456789*123456789*'
drop table t1;
set @@sql_mode='NO_ZERO_DATE';
create table t1(a datetime not null);
select count(*) from t1 where a is null;
count(*)
0
drop table t1;
End of 5.0 tests

11
mysql-test/t/strict.test
View file

@ -1208,3 +1208,14 @@ create table t1 (i int)
comment '123456789*123456789*123456789*123456789*123456789*123456789*';
show create table t1;
drop table t1;
#
# Bug #22824: strict, datetime, NULL, wrong warning
#
set @@sql_mode='NO_ZERO_DATE';
create table t1(a datetime not null);
select count(*) from t1 where a is null;
drop table t1;
--echo End of 5.0 tests

3
sql/item_cmpfunc.cc
View file

@ -241,7 +241,8 @@ static bool convert_constant_item(THD *thd, Field *field, Item **item)
{
/* For comparison purposes allow invalid dates like 2000-01-32 */
ulong orig_sql_mode= thd->variables.sql_mode;
thd->variables.sql_mode|= MODE_INVALID_DATES;
thd->variables.sql_mode= (orig_sql_mode & ~MODE_NO_ZERO_DATE) |
MODE_INVALID_DATES;
if (!(*item)->save_in_field(field, 1) && !((*item)->null_value))
{
Item *tmp=new Item_int_with_ref(field->val_int(), *item,