mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2026-05-16 11:57:38 +02:00
Code Issues Projects Releases Packages Wiki Activity

Don't flush pinned pages in checkpoint (fix for my last push)

Browse source 
storage/maria/unittest/ma_pagecache_single.c:
  Check if we can flush write locked page for normal flush
  Check that we can't flush read locked page with FLUSH_KEEP_LAZY (used by checkpoint)
This commit is contained in:
Michael Widenius 2010-06-16 00:39:28 +03:00
commit 26968d68a9
2 changed files with 103 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

13
storage/maria/ma_pagecache.c
View file

@ -4188,12 +4188,15 @@ static int flush_cached_blocks(PAGECACHE *pagecache,
PAGECACHE_BLOCK_LINK *block= *cache;
/*
This code is only run for non transactional tables.
We may have other threads reading the block during flush,
as non transactional tables can have many readers while the
one writer is doing the flush.
In the case of non_transactional tables we want to flush also
block pinned with reads. This is becasue we may have other
threads reading the block during flush, as non transactional
tables can have many readers while the one writer is doing the
flush.
We don't want to do flush pinned blocks during checkpoint.
We detect the checkpoint case by checking if type is LAZY.
*/
if (block->wlocks)
if ((type == FLUSH_KEEP_LAZY && block->pins) || block->wlocks)
{
KEYCACHE_DBUG_PRINT("flush_cached_blocks",
("block: %u (0x%lx) pinned",