mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 12:32:27 +01:00
Bug#39932 "create table fails if column for FK is in different
case than in corr index". Server was unable to find existing or explicitly created supporting index for foreign key if corresponding statement clause used field names in case different than one used in key specification and created yet another supporting index. In cases when name of constraint (and thus name of generated index) was the same as name of existing/explicitly created index this led to duplicate key name error. The problem was that unlike all other code Key_part_spec::operator==() compared field names in case sensitive fashion. As result routines responsible for getting rid of redundant generated supporting indexes for foreign key were not working properly for versions of field names using different cases. (backported from mysql-trunk)
This commit is contained in:
parent
a73b734949
commit
24fc7ca4c8
3 changed files with 41 additions and 1 deletions
|
@ -2588,3 +2588,23 @@ Extra Using index
|
||||||
DROP TABLE t1;
|
DROP TABLE t1;
|
||||||
#
|
#
|
||||||
End of 5.1 tests
|
End of 5.1 tests
|
||||||
|
#
|
||||||
|
# Test for bug #39932 "create table fails if column for FK is in different
|
||||||
|
# case than in corr index".
|
||||||
|
#
|
||||||
|
drop tables if exists t1, t2;
|
||||||
|
create table t1 (pk int primary key) engine=InnoDB;
|
||||||
|
# Even although the below statement uses uppercased field names in
|
||||||
|
# foreign key definition it still should be able to find explicitly
|
||||||
|
# created supporting index. So it should succeed and should not
|
||||||
|
# create any additional supporting indexes.
|
||||||
|
create table t2 (fk int, key x (fk),
|
||||||
|
constraint x foreign key (FK) references t1 (PK)) engine=InnoDB;
|
||||||
|
show create table t2;
|
||||||
|
Table Create Table
|
||||||
|
t2 CREATE TABLE `t2` (
|
||||||
|
`fk` int(11) DEFAULT NULL,
|
||||||
|
KEY `x` (`fk`),
|
||||||
|
CONSTRAINT `x` FOREIGN KEY (`fk`) REFERENCES `t1` (`pk`)
|
||||||
|
) ENGINE=InnoDB DEFAULT CHARSET=latin1
|
||||||
|
drop table t2, t1;
|
||||||
|
|
|
@ -813,3 +813,21 @@ DROP TABLE t1;
|
||||||
|
|
||||||
|
|
||||||
--echo End of 5.1 tests
|
--echo End of 5.1 tests
|
||||||
|
|
||||||
|
|
||||||
|
--echo #
|
||||||
|
--echo # Test for bug #39932 "create table fails if column for FK is in different
|
||||||
|
--echo # case than in corr index".
|
||||||
|
--echo #
|
||||||
|
--disable_warnings
|
||||||
|
drop tables if exists t1, t2;
|
||||||
|
--enable_warnings
|
||||||
|
create table t1 (pk int primary key) engine=InnoDB;
|
||||||
|
--echo # Even although the below statement uses uppercased field names in
|
||||||
|
--echo # foreign key definition it still should be able to find explicitly
|
||||||
|
--echo # created supporting index. So it should succeed and should not
|
||||||
|
--echo # create any additional supporting indexes.
|
||||||
|
create table t2 (fk int, key x (fk),
|
||||||
|
constraint x foreign key (FK) references t1 (PK)) engine=InnoDB;
|
||||||
|
show create table t2;
|
||||||
|
drop table t2, t1;
|
||||||
|
|
|
@ -91,7 +91,9 @@ extern "C" void free_user_var(user_var_entry *entry)
|
||||||
|
|
||||||
bool Key_part_spec::operator==(const Key_part_spec& other) const
|
bool Key_part_spec::operator==(const Key_part_spec& other) const
|
||||||
{
|
{
|
||||||
return length == other.length && !strcmp(field_name, other.field_name);
|
return length == other.length &&
|
||||||
|
!my_strcasecmp(system_charset_info, field_name,
|
||||||
|
other.field_name);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
Loading…
Reference in a new issue