merging with mysql-5.0-bugteam

This commit is contained in:
V Narayanan 2009-07-17 14:25:09 +05:30
commit 18cc9fd478

View file

@ -32,11 +32,11 @@
DESCRIPTION DESCRIPTION
init_dynamic_array() initiates array and allocate space for init_dynamic_array() initiates array and allocate space for
init_alloc eilements. init_alloc eilements.
Array is usable even if space allocation failed. Array is usable even if space allocation failed, hence, the
function never returns TRUE.
Static buffers must begin immediately after the array structure. Static buffers must begin immediately after the array structure.
RETURN VALUE RETURN VALUE
TRUE my_malloc_ci() failed
FALSE Ok FALSE Ok
*/ */
@ -63,12 +63,12 @@ my_bool init_dynamic_array2(DYNAMIC_ARRAY *array, uint element_size,
array->size_of_element=element_size; array->size_of_element=element_size;
if ((array->buffer= init_buffer)) if ((array->buffer= init_buffer))
DBUG_RETURN(FALSE); DBUG_RETURN(FALSE);
if (!(array->buffer=(uchar*) my_malloc_ci(element_size*init_alloc, /*
MYF(MY_WME)))) Since the dynamic array is usable even if allocation fails here malloc
{ should not throw an error
*/
if (!(array->buffer= (char*) my_malloc_ci(element_size*init_alloc, MYF(0))))
array->max_element=0; array->max_element=0;
DBUG_RETURN(TRUE);
}
DBUG_RETURN(FALSE); DBUG_RETURN(FALSE);
} }